Raise errors from run_training #151
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Completely untested, just spitballing since I noticed that training failure doesn't break workflow tests for some reason. |
5 tasks
booxter
force-pushed
the
raise-on-error
branch
3 times, most recently
from
d0ff0ac to
a1f56f3
Compare
booxter
commented
Jul 24, 2024
booxter
changed the title
The library shouldn't (just) print errors; it should raise errors and let callers deal with them. This patch also makes the function raise RuntimeError when training process returns a non-zero return code, or when it times out on waiting for exit. ilab cli already handles all Exceptions raised by the function. KeyboardInterrupt won't be caught by this exception handler since it's not Exception (but BaseException), but it's handled by click library instead [1]. The intent of this patch is to make `ilab train` fail with non-zero return code when training routine failed. [1] https://click.palletsprojects.com/en/7.x/exceptions/#where-are-errors-handled Signed-off-by: Ihar Hrachyshka <[email protected]>
|
This pull request has been automatically marked as stale because it has not had activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. |
|
This pull request has merge conflicts that must be resolved before it can be |
|
This pull request has merge conflicts that must be resolved before it can be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.