Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default skills sampling size during datamixing to "1.0" from "30" #420

Closed
bbrowning opened this issue Nov 29, 2024 · 2 comments
Closed
Assignees
Labels

Comments

@bbrowning
Copy link
Contributor

We had a hardcoded sampling size of 30 samples per leaf node of custom skills. That's a very specific number that may be appropriate in some cases, but we're seeing more commonly users having only 1 or a few skill nodes and wanting more of their generated skill data in the mixed output. So, change the default sampling size of custom skills to "1.0", which will include all their generated skill data in the mixed output per skill leaf node instead of truncating it to 30 per skill leaf node.

@ktam3
Copy link

ktam3 commented Jan 8, 2025

Based on discussion during today's Data team call, Ben will be closing this Issue

@bbrowning
Copy link
Contributor Author

Yes - for more context, while we do default sampling to 30 today we'll be exposing a data mixing API that users can use to tweak those mixing recipes and adjust this from 30 to whatever value they want. In light of that, leaving this at some default number for now seems fine (and 30 is as good as any).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants