Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Objectbrick class with first letter always uppercase #430

Conversation

chm0815
Copy link
Contributor

@chm0815 chm0815 commented Dec 12, 2024

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no

Even if the name of an objectbrick is in lowercase, the generated class in var/classes/DataObject/Objectbrick/Data is always in uppercase. The ObjectBrickSetter now loads the class with the first letter in uppercase.

Copy link
Contributor

github-actions bot commented Dec 12, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@dpfaffenbauer
Copy link
Collaborator

@chm0815 please sign the cla

@chm0815
Copy link
Contributor Author

chm0815 commented Dec 12, 2024

I have read the CLA Document and I hereby sign the CLA

@chm0815
Copy link
Contributor Author

chm0815 commented Dec 12, 2024

recheck

github-actions bot added a commit that referenced this pull request Dec 12, 2024
@dpfaffenbauer dpfaffenbauer merged commit 54ff862 into instride-ch:5.0 Dec 13, 2024
20 checks passed
@dpfaffenbauer
Copy link
Collaborator

@chm0815 thanks :)

@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants