-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Choose specific percentiles from histogram #69
Comments
Would this be a per-metric option? i.e, for histogram X, export the 75th and 99th percentiles, but for histogram Y, export everything? Adding a global option to only export select percentiles for all histograms is relatively easy. Having a per-metic option is somewhat more difficult with the current project architecture. |
Adding a global option makes sense to me. Limiting percentiles per-metric basis doesn't seem to be a wider use-case. |
Right now there is no code path or infrastructure in place to filter metrics based on labels. Currently, filtering is done at "registration time", which is when the exporter is notified that C* has created a new MBean (see the It probably wouldn't be terribly difficult to filter the stream of metrics as they're being collected, especially since Java Streams do in-fact have a Label-level filtering would have the side effect of filtering certain percentiles for different histograms. |
Thank you, I will go through the code and crate a PR to provide option to only export select percentiles for all histograms. |
I'd be interested in this functionality as well. |
The PR Percentile filter #73 contains the implementation is still Open |
Euhm, right! Not sure how I could miss that! @zegelin , any plans to merge this any time soon? |
Currently there is a vast number of metrics at node level as well as table level. Every metrics is important and has its own significance. However, capturing every thing will leads to space issues in case of large clusters. Though there are option to filter out some metrics, I don't see an option to capture only a specific percentiles from histogram metrics. Having this option saves a lot of space in case of bigger clusters with huge tables. For example, cassandra_table_coordinator_latency_seconds contains many number of metrics, out of them I may need only 99th percentile and 75 percentile metrics.
The text was updated successfully, but these errors were encountered: