Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set frame to NOOP if compressor can't match the error provided. #127

Open
cjrolo opened this issue Nov 4, 2024 · 0 comments
Open

Set frame to NOOP if compressor can't match the error provided. #127

cjrolo opened this issue Nov 4, 2024 · 0 comments

Comments

@cjrolo
Copy link
Collaborator

cjrolo commented Nov 4, 2024

Describe the Bug

If a compressor is selected with a given error level (e.g. 1%) and the compressor can't do that error level or less, the compressor should default to NOOP (No compressor) instead of returning a compressed set but above the error requested.

Currently it works as a "best effort" to get the error provided but I think it should be mandatory to be below the error provided in the input.

To Reproduce

Steps to reproduce the behavior:

  1. Compress a file that is not very compressible with a low error like 1%
  2. Check the output error level
  3. Error will be higher than 1%

Expected Behavior

If a file can't be compressed with an error below the one provided, WARN and use a NOOP frame.

@cjrolo cjrolo changed the title Set frame to NOOP if compressor can Set frame to NOOP if compressor can't match the error provided. Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant