Huge Amounts Of memory Leaks reported in XCode

[BarryDuggan]

Running on iOS 14.6
XCode 12.4

Related Issue

According to XCode there's a ton of retain cycles causing leaks in this Library.
Please see the attached screen shot for a better idea of what I'm talking about.

[DispoKen]

+1

[santanaNogueira]

Did anyone find the solution to this issue? Thanks in advance!

[zh-ios]

I had fixed it

final class NTPConnection {
let address: SocketAddress
let timeout: TimeInterval
let maxRetries: Int
var logger: LogCallback?
private var throttleConnections: (() -> Void)?
func query(addresses: [SocketAddress],
config: NTPConfig,
logger: LogCallback?,
callbackQueue: DispatchQueue,
progress: @escaping NTPConnectionCallback) -> [NTPConnection] {
let connections = addresses.flatMap { address in
(0..<config.numberOfSamples).map { _ in
NTPConnection(address: address,
timeout: config.timeout,
maxRetries: config.maxRetries,
logger: logger)
}
}

    let onComplete: NTPConnectionCallback = {[weak self] connection, result in
        guard let self = self else {return}
        progress(connection, result)
        self.throttleConnections?()
    }

    self.throttleConnections = {
        let remainingConnections = connections.filter { $0.canRetry }
        let activeConnections = Array(remainingConnections[0..<min(config.maxConnections,
                                                                   remainingConnections.count)])
        activeConnections.forEach { $0.start(callbackQueue, onComplete: onComplete) }
    }
    self.throttleConnections?()
    return connections
}

query method you should use instance method and user weak self in the block .

NTPClient class

func query(addresses: [SocketAddress], host: String) {
var results: [String: [FrozenNetworkTimeResult]] = [:]
////// self.con = .....
self.con = NTPConnection(address: addresses[0], timeout: config.timeout, maxRetries: 3, logger: nil)
// / weak self
connections = self.con!.query(addresses: addresses, config: config, logger: logger, callbackQueue: queue, progress: {[weak self] connection , result in
guard let self = self else {return}
guard self.started && !self.finished else {
self.debugLog("Got NTP response after queue stopped: (result)")
return
}
.....

in the stop queue func you should set self.con = nil
func stopQueue() {
debugLog("Stopping queue")
startTime = nil
connections.forEach { $0.close(waitUntilFinished: true) }
connections = []
self.con = nil
}