Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contao 4.12+ compatibility #1

Open
fritzmg opened this issue Mar 25, 2021 · 3 comments
Open

Contao 4.12+ compatibility #1

fritzmg opened this issue Mar 25, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@fritzmg
Copy link
Contributor

fritzmg commented Mar 25, 2021

This extension will no longer work with Contao 4.12+ (see contao/contao#2917). To fix this it needs to implement its own search module.

@fritzmg fritzmg added the bug Something isn't working label Mar 25, 2021
@fritzmg fritzmg self-assigned this Mar 25, 2021
@gmpf
Copy link

gmpf commented Jun 22, 2022

Wouldn't it make sense to add a constraint to composer.json to reflect the incompatibility for as long as it lasts? Like, instead of ^4.4, have >=4.4.0 <4.12.0 or something to that effect.

With regard to a broader outlook, it would be really cool to have a hook in the core that would allow for filtering of search results. I know that wouldn't solve the issue for ^4.12, but it would be a lot better than having to copy the entire module in a bundle or add a patch in an application.

@fritzmg
Copy link
Contributor Author

fritzmg commented Jun 23, 2022

Wouldn't it make sense to add a constraint to composer.json to reflect the incompatibility for as long as it lasts? Like, instead of ^4.4, have >=4.4.0 <4.12.0 or something to that effect.

That won't matter as a version that is unlocked for Contao 4.12+ has already been released.

@gmpf
Copy link

gmpf commented Jun 23, 2022

Oh, yeah, that's right, that version would always be picked then, never mind. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants