-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add constraint to ActiveSupport gem to use version lower than 7.1 #751
Conversation
Signed-off-by: Sonu Saha <[email protected]>
The omnibus build fails because Mocha ~1.1 is incompatible with minitest v5.19 and later with an error as:
Build link here: https://buildkite.com/chef-oss/inspec-train-main-verify/builds/876 This would require upgrade to mocha and rename the occurence of |
Signed-off-by: Sonu Saha <[email protected]>
Signed-off-by: Sonu Saha <[email protected]>
Signed-off-by: Sonu Saha <[email protected]>
Build where it failed for windows on ruby lower than 3.1 with mocha ~1.1: https://buildkite.com/chef-oss/inspec-train-main-verify/builds/880 |
Taking care of |
Signed-off-by: Sonu Saha <[email protected]>
Just as a headsup, ActiveSupport 7.1 as released is stable. Rafael from the core team gives a bit more clarification around this here (which is why the issue was closed as not planned) :
Hope this context helps! :) |
Thanks @Schwad! Requiring |
Closing this PR. As it is getting addressed on inspec-k8s resource pack's end here: inspec/inspec-k8s#37 |
Description
The latest version of ActiveSupport i.e. 7.1.0 - released on October 05, 2023 results to an issue as:
More details on the issue can be found here: rails/rails#49495
We plan to remove the version constraint post stable release of ActiveSupport 7.1
Related Issue
Fixes #750
Types of changes
Checklist: