Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3pt] Clean up webpack/babel #167

Open
NSeydoux opened this issue Dec 9, 2019 · 1 comment
Open

[3pt] Clean up webpack/babel #167

NSeydoux opened this issue Dec 9, 2019 · 1 comment
Assignees
@NSeydoux

Comments

@NSeydoux
Copy link
Contributor

NSeydoux commented Dec 9, 2019 •
edited
Loading

Webpack/babel versions are hard-coded in the ArtifactGenerator class. These versions should not be needed inside the source code, but potentially as dependencies in the package.json, if at all.

If there are prerequisites for webpack/babel, they should be also specified in the README.
@NSeydoux NSeydoux self-assigned this Dec 11, 2019
@NSeydoux
Copy link
Contributor Author

The babel/webpack versions are explicitly copied over the template data in DatasetHandler, when the YAML configuration should be sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NSeydoux NSeydoux

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NSeydoux