Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DsConfPolicy and DsConfValidator redundant #2

Open
AltiMario opened this issue Jun 19, 2023 · 0 comments
Open

DsConfPolicy and DsConfValidator redundant #2

AltiMario opened this issue Jun 19, 2023 · 0 comments
Labels
refactoring Code cleanups and improvements versioning Script and data versioning systems

Comments

@AltiMario
Copy link

AltiMario commented Jun 19, 2023 •
edited by szg251
Loading

DsConfPolicy and DsConfValidator are implementing an oracle, very similar to the VersionOraclePolicy and VersionOracleValidator itself. This means that the VersionOracle scripts could cover all the functionality needed, potentially simplifying the protocol.
As scriptIds should not change through versions, to maintain backwards compatibility, we must never use the ids of DsConfPolicy and DsConfValidator. However, if we remove them now, before any kind of release or deployment, we can still reorder scriptIds to our liking.
@AltiMario AltiMario added bug Incorrect program behaviour enhancement Add or improve a user-facing feature and removed bug Incorrect program behaviour labels Jun 19, 2023
@jstolarek jstolarek removed their assignment Jun 20, 2023
@szg251 szg251 changed the title dsconfpolicy and dsconfvalidator redundant DsConfPolicy and DsConfValidator redundant Jun 29, 2023
@szg251 szg251 changed the title DsConfPolicy and DsConfValidator redundant DsConfPolicy and DsConfValidator redundant Jun 29, 2023
@jstolarek jstolarek removed the enhancement Add or improve a user-facing feature label Dec 21, 2023
@gilligan gilligan transferred this issue from another repository Jul 15, 2024
tgunnoe pushed a commit that referenced this issue Jul 25, 2024
@NeilBurgess42
Merge pull request #2 from input-output-hk/ETCM-3802-add-disclaimer
78ce0f7 
ETCM-3802 Add standard disclaimer as approved by Legal
@jstolarek jstolarek added refactoring Code cleanups and improvements versioning Script and data versioning systems labels Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Code cleanups and improvements versioning Script and data versioning systems
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AltiMario @jstolarek