Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use dynamic ruby even in static variants #174

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sgillespie
Copy link
Contributor

@sgillespie sgillespie commented Nov 18, 2024

Static shell variants are currently failing with

In file included from bigdecimal.h:14,
                 from bigdecimal.c:11:
missing.h:127:1: error: static declaration of 'rb_rational_num' follows non-static declaration
  127 | rb_rational_num(VALUE rat)
      | ^~~~~~~~~~~~~~~

But It's not important to use static ruby anyways, because we are interested in producing static artifacts, not the build tools themselves.

So, this change

  • Removes static ruby in favor of the regular one
  • Removes patches that fixes static ruby

find $out/${old.passthru.gemPath} -name exts.mk -delete
'';
});
ruby = prev.pkgsBuildBuild.ruby;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should document why it doesn't matter that ruby is not static. We ultimately care about producing static outputs, not that the build tools closure is necessarily static.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants