-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LW-11697 Browser compatible Blockfrost Providers #1532
Conversation
722b30e
to
2cbfc8d
Compare
|
e938c69
to
ed3bf6a
Compare
fecc31d
to
9e3ab8d
Compare
9e3ab8d
to
c0c8904
Compare
packages/cardano-services-client/src/UtxoProvider/BlockfrostUtxoProvider.ts
Outdated
Show resolved
Hide resolved
d29bd01
to
b9592a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me @mkazlauskas, nice work with the refinement 🙌. Let's squash and press on with the Lace integration for testing
b9592a0
to
54a8954
Compare
…include body Needed for transaction submission Co-authored-by: Rhys Bartels-Waller <[email protected]> Co-authored-by: Martynas Kazlauskas <[email protected]>
54a8954
to
8a5742c
Compare
refactor them to be browser-compatible - BlockfrostNetworkInfoProvider - BlockfrostUtxoProvider - BlockfrostChainHistoryProvider - BlockfrostRewardsProvider - BlockfrostTxSubmitProvider (missing submission error mapping) Additional changes: - test(cardano-services-client): throw error responses from mockResponses util Co-authored-by: Rhys Bartels-Waller <[email protected]> Co-authored-by: Martynas Kazlauskas <[email protected]>
…frostRewardsProvider it had it's own logic duplicated with the util
some other conway parameters are still not mapped, but they aren't currently used by the wallet
6e57f91
to
4aaf01d
Compare
…ders also delete 'blockfrost-providers' test suite as it overlaps with wallet test suites
4aaf01d
to
6f1acc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work @rhyslbw and @mkazlauskas 🥇!
It’s so satisfying to see how the modular design of Providers
enabled such elegant and minimal changes.
Continuation of the work started in #1528
AssetThere's currently no integration test for tx submit, given it's better handled as an e2e test scenario.
Set up e2e to run against blockfrost-ryo with all new providers (except for tx submit which is unsupported by blockfrost-ryo)