Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: (YouTube/Hide ads) Store ads below the video is not hidden #2447

Closed
6 tasks done
smed79 opened this issue Oct 21, 2024 · 12 comments
Closed
6 tasks done

bug: (YouTube/Hide ads) Store ads below the video is not hidden #2447

smed79 opened this issue Oct 21, 2024 · 12 comments
Labels
Bug report Something isn't working

Comments

@smed79
Copy link

smed79 commented Oct 21, 2024 •
edited
Loading

Type

Other (ads)

Tools used

  • RVX Manager v1.22.2
  • RVX Patches v4.15.1

Application

  • YouTube 19.16.39

Bug description

I see store ads below the video player.

horizontal_shelf_content

Error logs

Solution

Adding the below custom filter hide the ads.

  • horizontal_shelf_content.eml

Device Environment

Android 14

Acknowledgements

  • This issue does not reproduce on unpatched YouTube or YT Music.
  • This issue is not a duplicate of an existing bug report.
  • I didn't use any settings marked as Experimental Flags.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@smed79 smed79 added the Bug report Something isn't working label Oct 21, 2024
@ghost
Copy link

ghost commented Oct 21, 2024

Did you try clean install? Uninstall, repatch, reinstall.

@nick-77
Copy link

nick-77 commented Oct 21, 2024

I can confirm this, having the same issue with 4.15.1 patches version

@smed79
Copy link
Author

smed79 commented Oct 21, 2024 •
edited
Loading

Did you try clean install? Uninstall, repatch, reinstall.

For sure Yes.

At first I thought the problem was from restored rvx settings and for that reason i did a clean install.

I can confirm this, having the same issue

Did you try the custom filter that i provided?

Settings > ReVanced Extended > General > Custom filter > Custom filter

@nick-77
Copy link

nick-77 commented Oct 21, 2024

Did you try the custom filter that i provided?

Didn't realise i could use it that way sorry, but yes just tried the custom filter method and it works 👍

@inotia00
Copy link
Owner

It's not reproduced on my side, but maybe Hide movies shelves is what hides this

@inotia00
Copy link
Owner

Nevertheless, if it is not hidden, please provide debug log according to #2437 (comment)

@smed79
Copy link
Author

smed79 commented Oct 21, 2024 •
edited
Loading

@inotia00

but maybe Hide movies shelves is what hides this

Hide movies shelves is already enabled in my settings.

provide debug log

Already provided in my first messages (Error logs) !

--

@nick-77

The filter i have provided horizontal_shelf_content.eml have the side effects to hide the horizontal Playlists in your profile tab 😞

@nick-77
Copy link

nick-77 commented Oct 22, 2024

@nick-77

The filter i have provided horizontal_shelf_content.eml have the side effects to hide the horizontal Playlists in your profile tab 😞

Oh yes, I didn't notice till you mentioned it
Still, thankyou for trying to help 👍

It's not reproduced on my side, but maybe Hide movies shelves is what hides this

Just tried enabling 'hide movie shelves', store ads are still visible

@ILoveOpenSourceApplications
Copy link

ILoveOpenSourceApplications commented Oct 22, 2024 •
edited
Loading

First, try adding shopping_item_card.eml (I believe this will leave the title "Fireship store" behind) and check if it works, if not try ^horizontal_shelf.eml$shopping_item_card.eml to hide it. Please check it out as I am no longer seeing it for some reason.

10-22 17:47:05.292 22419 22419 D Extended: LithoFilterPatch: Path: horizontal_shelf.eml|54b86fe45af5d3c1|CellType|horizontal_shelf_content.eml|d6c99df52af65671|ContainerType|ContainerType|CollectionType|shopping_item_card_list.eml|f8346fb6d9d34ace|CellType|shopping_item_card.eml|18462e928a7ba534|ContainerType|ContainerType|ContainerType|shopping_content_line.eml|3f1d5a2f482c2c38|ContainerType|shopping_content_line_item.eml|fa962b9552a7fe74|ContainerType|
10-22 17:47:05.292 22419 22419 D Extended: LithoFilterPatch: BufferStrings: shopping_content_line_item_key_0Γ¥Ö2,437.40Γ¥Ösans-serifΓ¥Ösans-serifΓ¥Ö
10-22 17:47:05.292 22419 22581 D Extended: LithoFilterPatch: Path: horizontal_shelf.eml|54b86fe45af5d3c1|CellType|horizontal_shelf_content.eml|d6c99df52af65671|ContainerType|ContainerType|CollectionType|shopping_item_card_list.eml|f8346fb6d9d34ace|CellType|shopping_item_card.eml|18462e928a7ba534|ContainerType|ContainerType|ContainerType|shopping_content_line.eml|3f1d5a2f482c2c38|ContainerType|
10-22 17:47:05.292 22419 22581 D Extended: LithoFilterPatch: BufferStrings: shopping_item_card_metadata_line_2Γ¥Öshopping_content_line_item_key_1Γ¥Öshopping_content_line_item.eml|fa962b9552a7fe74Γ¥Öshopping_content_line_item_key_0Γ¥Öshopping_content_line_item.eml|fa962b9552a7fe74Γ¥Ö

@smed79
Copy link
Author

smed79 commented Oct 22, 2024

Both filters hide the ads but leave the title "... store".

store_ads

@KobeW50 KobeW50 mentioned this issue Oct 22, 2024
Closed
5 tasks
@KobeW50
Copy link
Contributor

KobeW50 commented Oct 23, 2024

ReVanced just fixed this: ReVanced/revanced-patches#3804

@federicogith
Copy link

And with this: ReVanced/revanced-patches#3806

@smed79 smed79 mentioned this issue Oct 25, 2024
Closed
6 tasks
inotia00 added a commit to inotia00/revanced-integrations that referenced this issue Oct 26, 2024
@inotia00
feat(YouTube/Hide ads): add Hide player shopping shelf setting inot…
8f7540a 
…ia00/ReVanced_Extended#2447
inotia00 added a commit to inotia00/revanced-patches that referenced this issue Oct 26, 2024
@inotia00
feat(YouTube/Hide ads): add Hide player shopping shelf setting inot…
dc379e5 
…ia00/ReVanced_Extended#2447
@smed79 smed79 closed this as completed Oct 29, 2024
@KobeW50 KobeW50 mentioned this issue Oct 29, 2024
Closed
5 tasks
github-actions bot pushed a commit to Laitinlok/revanced-patches that referenced this issue Dec 5, 2024
@semantic-release-bot
chore(release): 4.13.0-dev.1 [skip ci]
1b1bfd0 
# [4.13.0-dev.1](v4.12.1...v4.13.0-dev.1) (2024-12-05)

### Bug Fixes

* add missing code ([675d7e6](675d7e6))
* **BytecodeUtils:** due to structural limitations of ReVanced Patcher, incorrect classes may be retrieved ([40082ce](40082ce))
* **Hide settings menu:** do not use strings for filtering ([98a1cb3](98a1cb3))
* remove chimera reference and disable advertising id ([inotia00#97](https://github.com/Laitinlok/revanced-patches/issues/97)) ([787dd59](787dd59)), closes [inotia00#72](https://github.com/Laitinlok/revanced-patches/issues/72)
* remove unused fingerprint ([38b818e](38b818e))
* **ReturnYouTubeDislike:** show estimated like count for videos with hidden likes ([250641a](250641a))
* **YouTube - Hook download actions:** Video download button was not responding ([inotia00#71](https://github.com/Laitinlok/revanced-patches/issues/71)) ([5038527](5038527))
* **YouTube Music/Custom branding icon:** patch fails on certain versions ([115ff0d](115ff0d))
* **YouTube Music/Disable auto captions:** captions cannot be changed when `Disable forced auto captions` is turned on ([d708f36](d708f36))
* **YouTube Music/Disable Cairo splash animation:** some versions are recognized as unpatchable even though they can be patched ([577f49b](577f49b))
* **YouTube Music/Flyout menu components:** unable to patch due to incorrect format ([96dc5cf](96dc5cf))
* **YouTube Music/GmsCore support:** `Open GmsCore` setting is not added if user only includes `GmsCore support` patch inotia00/ReVanced_Extended#2351 ([3720b4a](3720b4a))
* **YouTube Music/GmsCore support:** can't share the stories to Facebook, Instagram and Snapchat inotia00/ReVanced_Extended#1830 ([a041ca2](a041ca2))
* **YouTube Music/GmsCore support:** YT Music crashes when using the `Open GmsCore` setting inotia00/ReVanced_Extended#2352 ([1205958](1205958))
* **YouTube Music/Player components:** `Hide Audio / Video toggle` setting not working in landscape mode ([5422914](5422914))
* **YouTube Music/Player components:** `Remember shuffle state` setting does not remember the correct state ([8333bf7](8333bf7))
* **YouTube Music/Player components:** patches do not apply properly in certain versions ([a4227ae](a4227ae))
* **YouTube Music/Sanitize sharing links:** tracking parameters are not removed from the system share panel ([4aec1a1](4aec1a1))
* **YouTube Music/SponsorBlock:** SponsorBlock does not skip segment at the beginning when in background inotia00/ReVanced_Extended#2396 ([e25bd10](e25bd10))
* **YouTube Music/SponsorBlock:** SponsorBlock segments at the end of a song cause the player to get stuck inotia00/ReVanced_Extended#2360 ([547fd29](547fd29))
* **YouTube Music/Spoof app version:** ListPreference sometimes selects wrong values ([b219e0d](b219e0d))
* **YouTube/Custom Shorts action buttons:** low image quality for `Cairo` option on YouTube 18.29.38 ([7da0b55](7da0b55))
* **YouTube/Disable force auto captions:** add information to summary that it doesn't work in Shorts inotia00/ReVanced_Extended#2346 ([277133e](277133e))
* **YouTube/Disable force auto captions:** patch doesn't work with Shorts inotia00/ReVanced_Extended#2346 ([9d5998b](9d5998b))
* **YouTube/Hide feed components:** `Hide carousel shelf` setting sometimes hides the library shelf ([1cf3c6d](1cf3c6d))
* **YouTube/Hide feed components:** `Hide Latest videos button` setting does not support tablets ([inotia00#89](https://github.com/Laitinlok/revanced-patches/issues/89)) ([c932956](c932956))
* **YouTube/Hide feed components:** `Hide related videos` setting hides the player flyout component ([4558869](4558869))
* **YouTube/Hide feed components:** change default offset for `Hide related videos` setting ([6fc7680](6fc7680))
* **YouTube/Hook YouTube Music actions:** app crashes when first installed ([1bc0d73](1bc0d73))
* **YouTube/Integrations:** skip patches even in versions where fingerprints are still used ([79bfd1e](79bfd1e))
* **YouTube/Litho filter:** disable obfuscation ([2864fb1](2864fb1))
* **YouTube/Overlay buttons:** paddingBottom is not set when patch option `WiderButtonsSpace` is TRUE inotia00#87 ([30a88bd](30a88bd))
* **YouTube/Overlay buttons:** paddingBottom is not set when patch option `WiderButtonsSpace` is TRUE inotia00#87 ([387891e](387891e))
* **YouTube/Overlay buttons:** support A/B player layout ([a25919b](a25919b))
* **YouTube/Player components:** `Disable player popup panels` setting disables the engagement panel in Mix playlists on certain YouTube version ([6d48ade](6d48ade))
* **YouTube/Player components:** patch is broken in certain versions ([697dc74](697dc74))
* **YouTube/Settings:**  EditTextDialog's background color does not match when `Theme` patch is excluded inotia00/ReVanced_Extended#2422 ([12127d6](12127d6))
* **YouTube/Settings:** `Search bar in settings` can't find `RYD` and `SponsorBlock` settings ([9bd51f7](9bd51f7))
* **YouTube/Settings:** `Swap Create and Notifications button` description cuts off inotia00/ReVanced_Extended#2373 ([357ad60](357ad60))
* **YouTube/Settings:** clarify the description of some settings inotia00/ReVanced_Extended#2393 ([f92cb71](f92cb71))
* **YouTube/Settings:** remove duplicate descriptions ([8d8af80](8d8af80))
* **YouTube/Shorts components:** `Hide paused header` setting does not work ([17cabfb](17cabfb))
* **YouTube/Shorts components:** even if `Hide navigation bar` is turned on, the navigation bar will reappear when the user opens the comments or description panel in Shorts ([2cdc05a](2cdc05a))
* **YouTube/SponsorBlock:** add summary text to 'view my segments' button ([8db7d0e](8db7d0e))
* **YouTube/SponsorBlock:** handle if the user enters an invalid number into any SB settings ([d6739ef](d6739ef))
* **YouTube/Spoof app version:** remove obsolete 17.33.42 spoof target ([823ccf4](823ccf4))
* **YouTube/Spoof streaming data:** Log out the iOS client to allow video playback ([inotia00#100](https://github.com/Laitinlok/revanced-patches/issues/100)) ([0dee7c1](0dee7c1))
* **YouTube/Spoof streaming data:** update side effects ([2980d48](2980d48))
* **YouTube/Spoof streaming data:** wrong register used ([f29fbae](f29fbae))
* **YouTube/Theme:** revert `reverts background color of More comments icon in live chats` inotia00/ReVanced_Extended#2197 ([bd6690c](bd6690c))
* **YouTube/Video information:** app crash when casting inotia00/ReVanced_Extended#2309 ([c805c17](c805c17))
* **YouTube/YT Music - GmsCore support:** unimplemented service in GmsCore causes memory leak ([f999aea](f999aea))
* **YouTube:** String typos and grammar ([inotia00#84](https://github.com/Laitinlok/revanced-patches/issues/84)) ([8119eef](8119eef))

### Features

* **Hide ads:** remove `Close fullscreen ads` setting inotia00/ReVanced_Extended#2017 (comment) ([2d6142b](2d6142b)), closes [/github.com/inotia00/ReVanced_Extended/issues/2017#issuecomment-2351327068](https://github.com//github.com/inotia00/ReVanced_Extended/issues/2017/issues/issuecomment-2351327068)
* **Return YouTube Dislike:** add `Show estimated likes` setting ([40cecc6](40cecc6))
* **Translations:** update translation ([7b0cc3b](7b0cc3b))
* **Translations:** update translation ([c8f9abe](c8f9abe))
* **Translations:** update translation ([606fb1a](606fb1a))
* **Translations:** update translation ([002af89](002af89))
* **Translations:** update translation ([4ad4a8f](4ad4a8f))
* **Translations:** update translation ([a2ee407](a2ee407))
* **Translations:** update translation ([23a0654](23a0654))
* **Translations:** update translation ([34587af](34587af))
* **Translations:** update translation ([231b7f0](231b7f0))
* **Translations:** update translation ([63224c2](63224c2))
* **Translations:** update translation ([a4b926d](a4b926d))
* **Translations:** update translation ([d19978b](d19978b))
* **Translations:** update translation ([fd49621](fd49621))
* **Translations:** update translation ([c0d3cf8](c0d3cf8))
* **Translations:** update translation ([2a75373](2a75373))
* **Translations:** update translation ([49ca584](49ca584))
* **Translations:** update translation ([9eac957](9eac957))
* **Translations:** update translation ([b79372a](b79372a))
* **Translations:** update translation ([72f0970](72f0970))
* **Translations:** update translation ([6a94ada](6a94ada))
* **Translations:** update translation ([51b4efe](51b4efe))
* **Translations:** update translation ([12c3056](12c3056))
* **Translations:** update translation ([54e686c](54e686c))
* **Translations:** update translation ([c35ce40](c35ce40))
* **Translations:** update translation ([a1e34b4](a1e34b4))
* **YouTube Music/Custom branding icon for YouTube Music:** add patch option `RestoreOldSplashIcon` inotia00/ReVanced_Extended#2368 ([cdbd349](cdbd349))
* **YouTube Music/Custom branding icon for YouTube Music:** Update monochrome icon for afn_red & afn_blue ([inotia00#82](https://github.com/Laitinlok/revanced-patches/issues/82)) ([507072d](507072d))
* **YouTube Music/Hide ads:** add `Hide promotion alert banner` setting ([94f7c5b](94f7c5b))
* **YouTube Music/Navigation bar components:** do not use hardcoded color `Enable black navigation bar` setting is turned off inotia00/ReVanced_Extended#2440 ([194ca27](194ca27))
* **YouTube Music/Settings:** add `Open default app settings` setting inotia00/ReVanced_Extended#1861 ([6b5c03b](6b5c03b))
* **YouTube Music/Spoof app version:** add target version 7.16.53 ([3edd8eb](3edd8eb))
* **YouTube Music/Spoof app version:** app crashes when first installed ([4387c55](4387c55))
* **YouTube Music/Video playback:** add an option to disable toasts when changing the default values ([c992f4a](c992f4a))
* **YouTube Music:** add `Visual preferences icons for YouTube Music` patch inotia00/ReVanced_Extended#2216 ([8f5be6f](8f5be6f))
* **YouTube Music:** add support version `6.20.51` ([inotia00#81](https://github.com/Laitinlok/revanced-patches/issues/81)) ([225adc7](225adc7))
* **YouTube Music:** add support versions `7.15.52` ~ `7.16.52` ([010a19f](010a19f))
* **YouTube Music:** add support versions `7.16.53` ~ `7.17.51` ([faa112e](faa112e))
* **YouTube Music:** changes to supported versions - changed `6.29.58` to `6.29.59`, changed `7.16.52` to `7.16.53`, removed `6.33.52` (as it is almost the same as `6.29.59`) ([42ecfa9](42ecfa9))
* **YouTube Music:** drop support version `7.17.51` inotia00/ReVanced_Extended#2382 ([cc71acf](cc71acf))
* **YouTube Music:** rename `Enable Cairo splash animation` to `Disable Cairo splash animation` inotia00/ReVanced_Extended#2366 ([3d331a7](3d331a7))
* **YouTube/Change start page:** add `Change start page type` setting inotia00/ReVanced_Extended#2395 (comment) ([e8ad2e6](e8ad2e6)), closes [/github.com/inotia00/ReVanced_Extended/issues/2395#issuecomment-2368848355](https://github.com//github.com/inotia00/ReVanced_Extended/issues/2395/issues/issuecomment-2368848355)
* **YouTube/Change start page:** change the actual start page instead of redirecting the Url inotia00/ReVanced_Extended#2395 ([37e00d4](37e00d4))
* **YouTube/Custom branding icon:** add patch option `YouTube (Minimal header)` ([inotia00#83](https://github.com/Laitinlok/revanced-patches/issues/83)) ([29f4e06](29f4e06))
* **YouTube/Custom Shorts action buttons:**  add patch option `Cairo` ([e601cca](e601cca))
* **YouTube/Description components:** add `Hide AI-generated video summary section` setting inotia00/ReVanced_Extended#2473 ([200e2b8](200e2b8))
* **YouTube/Hide ads:** add `Hide player shopping shelf` setting inotia00/ReVanced_Extended#2447 ([dc379e5](dc379e5))
* **YouTube/Hide ads:** add `Hide promotion alert banner` setting ([82777db](82777db))
* **YouTube/Hide comments components:** add `Hide highlighted search links` setting inotia00/ReVanced_Extended#2435 ([df53fdf](df53fdf))
* **YouTube/Hide feed components:** add `Hide expandable shelves` setting ([6587ba7](6587ba7))
* **YouTube/Hide feed components:** add `Hide floating button` setting ([e644186](e644186))
* **YouTube/Hide feed components:** add `Hide related videos` setting ([389f414](389f414))
* **YouTube/Hide feed components:** add `Hide UPCOMING video` setting ([0b49445](0b49445))
* **YouTube/Hide feed components:** add offset for `Hide related videos` setting ([907bc9b](907bc9b))
* **YouTube/Hide feed components:** add syntax to match whole keywords and not substrings ([28ede81](28ede81))
* **YouTube/Hide feed components:** remove `Duration filter` setting as it no longer works due to server side changes inotia00/ReVanced_Extended#2389 ([aa78830](aa78830))
* **YouTube/Hide feed components:** remove `Hide UPCOMING video` setting ([b4a67d3](b4a67d3))
* **YouTube/Hide feed components:** selectively hide video by views for Home / Subscription / Search ([780dd0a](780dd0a))
* **YouTube/Hide player flyout menu:** add `Hide 1080p Premium menu` setting ([4eafb40](4eafb40))
* **YouTube/Hide player flyout menu:** add `Hide Sleep timer` setting ([c959612](c959612))
* **YouTube/Hide player flyout menu:** remove `Hide Ambient mode menu` setting ([8250dea](8250dea))
* **YouTube/Hide player flyout menu:** restore `Hide Ambient mode menu` setting ([8b3c44f](8b3c44f))
* **YouTube/Navigation bar components:** add `Hide navigation bar` setting ([6c060c5](6c060c5))
* **YouTube/Overlay buttons:** add `Collapse` button and update thin-type overlay button icons ([inotia00#75](https://github.com/Laitinlok/revanced-patches/issues/75)) ([984cd21](984cd21))
* **YouTube/Overlay buttons:** add patch option `WiderButtonsSpace` ([inotia00#87](https://github.com/Laitinlok/revanced-patches/issues/87)) ([3827424](3827424))
* **YouTube/Overlay buttons:** change patch options inotia00/ReVanced_Extended#2359 ([5823acc](5823acc))
* **YouTube/Overlay buttons:** replace `time-ordered playlist` button with `play all` button ([inotia00#96](https://github.com/Laitinlok/revanced-patches/issues/96)) ([9982245](9982245))
* **YouTube/Player components:** add `Disable switch mix playlists` setting ([fc832e2](fc832e2))
* **YouTube/Player components:** add `Sanitize video subtitle` setting ([8d9da83](8d9da83))
* **YouTube/PlayerTypeHook:** add hooking on Shorts state (whether Shorts is open or not) ([bb4f8bf](bb4f8bf))
* **YouTube/Remove background playback restrictions:** match with ReVanced ([9cb1b4f](9cb1b4f))
* **YouTube/Seekbar components:** add `Disable seekbar chapters` setting ([504998f](504998f))
* **YouTube/Seekbar components:** add `Enable high quality thumbnails` setting ([8af117b](8af117b))
* **YouTube/Seekbar components:** Add info to `Append timestamp information` summary about tapping the appended information ([inotia00#93](https://github.com/Laitinlok/revanced-patches/issues/93)) ([93e0f3b](93e0f3b))
* **YouTube/Seekbar components:** remove `Enable high quality thumbnails` setting inotia00/ReVanced_Extended#2460 ([065854e](065854e))
* **YouTube/Shorts Component:** add `Disable Like button animation` setting ([5a77518](5a77518))
* **YouTube/Shorts Component:** always hide suggested actions if all sub-settings of the suggested actions category are enabled ([ec68f16](ec68f16))
* **YouTube/Shorts components:** add `Height percentage of empty space` setting ([4c824b4](4c824b4))
* **YouTube/Shorts components:** add `Hide in channel` setting (Hide the Shorts shelf on the channel home tab) ([5b45fb8](5b45fb8))
* **YouTube/Shorts components:** add `Hide stickers` setting ([7944107](7944107))
* **YouTube/Shorts components:** add `Hide Use this sound button` setting ([4fff1ca](4fff1ca))
* **YouTube/Shorts components:** add settings - `Hide floating button`, `Hide Trends button`, `Hide Use template button` ([166f1a0](166f1a0))
* **YouTube/Shorts components:** clarify the description of some settings inotia00/ReVanced_Extended#2357 ([de0ccbf](de0ccbf))
* **YouTube/Shorts components:** remove `Hide in watch history` setting ([bc8a586](bc8a586))
* **YouTube/Spoof app version:** add target version `19.13.37 - Restores old style Rolling number animations` inotia00/ReVanced_Extended#2419 (comment) ([bc48f2b](bc48f2b)), closes [/github.com/inotia00/ReVanced_Extended/issues/2419#issuecomment-2408912233](https://github.com//github.com/inotia00/ReVanced_Extended/issues/2419/issues/issuecomment-2408912233)
* **YouTube/Spoof app version:** change the default to off and show the dialog when the app is first installed ([105a9fa](105a9fa))
* **YouTube/Spoof app version:** enabled by default in YouTube 19.16.39+ ([620aeae](620aeae))
* **YouTube/Spoof app version:** remove obsolete 19.13.37 spoof target inotia00/ReVanced_Extended#2477 ([173494d](173494d))
* **YouTube/Spoof client:** allow forcing AVC codec with iOS ([4dd7255](4dd7255))
* **YouTube/Spoof streaming data:** add `iOS Compatibility mode` setting ([47c4aca](47c4aca))
* **YouTube/Spoof streaming data:** match with ReVanced ([9cbc019](9cbc019))
* **YouTube/Spoof streaming data:** match with ReVanced ([088f0eb](088f0eb))
* **YouTube/Spoof streaming data:** match with ReVanced ([1ef8639](1ef8639))
* **YouTube/Spoof streaming data:** update the hardcoded iOS client version inotia00/ReVanced_Extended#2480 ([f0cf292](f0cf292))
* **YouTube/Swipe controls:** add `Swipe sensitivity` settings ([de5ddb9](de5ddb9))
* **YouTube/Toolbar components:** add `Hide YouTube Doodles` setting ([c023138](c023138))
* **YouTube/Video playback:** add `Disable playback speed for music` setting ([73dc0d0](73dc0d0))
* **YouTube/Video playback:** add `Disable VP9 codec` setting inotia00/ReVanced_Extended#2384 ([753a44f](753a44f))
* **YouTube/Video playback:** add an option to disable toasts when changing the default values ([inotia00#78](https://github.com/Laitinlok/revanced-patches/issues/78)) ([4c22853](4c22853))
* **YouTube/Visual preferences icons:** add the patch option `ApplyToAll ` that do not apply to sub-settings inotia00/ReVanced_Extended#2392 ([5e4b56c](5e4b56c))
* **YouTube/YT - GmsCore support:** add patch option `Disable GmsService Broker` inotia00/ReVanced_Extended#2442 (comment) ([19a8677](19a8677)), closes [/github.com/inotia00/ReVanced_Extended/issues/2442#issuecomment-2424694043](https://github.com//github.com/inotia00/ReVanced_Extended/issues/2442/issues/issuecomment-2424694043)
* **YouTube/YT Music - Return YouTube Username:** add `Display format` setting ([828f83a](828f83a))
* **YouTube/YT Music:** add `Return YouTube Username` patch ([9733b60](9733b60))
* **YouTube:** add `Change share sheet` patch ([7339479](7339479))
* **YouTube:** add `Hide shortcuts` patch ([63d7b6c](63d7b6c))
* **YouTube:** add `Hook YouTube Music actions` patch ([ce55617](ce55617))
* **YouTube:** add `Spoof streaming data` patch ([15a9d7c](15a9d7c))
* **YouTube:** remove `Spoof client` patch ([0d29ed6](0d29ed6))
* **YouTube:** rename `Visual preferences icons` to `Visual preferences icons for YouTube` ([9be6315](9be6315))
* **YouTube:** replace with a fingerprint that supports a wider range of versions ([41e00d6](41e00d6))
* **YouTube:** revert all changes except minimal-header ([b1a9e04](b1a9e04))

### Performance Improvements

* **YouTube/GmsCore support:** improve performance by using hashsets ([cae2f6c](cae2f6c))

### Reverts

* Revert "feat(YouTube/Custom branding icon): add patch option `YouTube (Minima…" ([inotia00#86](https://github.com/Laitinlok/revanced-patches/issues/86)) ([24395de](24395de))
Laitinlok pushed a commit to Laitinlok/revanced-patches that referenced this issue Dec 6, 2024
@semantic-release-bot
chore(release): 4.13.0-dev.1 [skip ci]
f427c5c 
# [4.13.0-dev.1](v4.12.1...v4.13.0-dev.1) (2024-12-06)

### Bug Fixes

* add missing code ([675d7e6](675d7e6))
* **BytecodeUtils:** due to structural limitations of ReVanced Patcher, incorrect classes may be retrieved ([40082ce](40082ce))
* **Hide settings menu:** do not use strings for filtering ([98a1cb3](98a1cb3))
* remove chimera reference and disable advertising id ([inotia00#97](https://github.com/Laitinlok/revanced-patches/issues/97)) ([787dd59](787dd59)), closes [inotia00#72](https://github.com/Laitinlok/revanced-patches/issues/72)
* remove unused fingerprint ([38b818e](38b818e))
* **ReturnYouTubeDislike:** show estimated like count for videos with hidden likes ([250641a](250641a))
* **YouTube - Hook download actions:** Video download button was not responding ([inotia00#71](https://github.com/Laitinlok/revanced-patches/issues/71)) ([5038527](5038527))
* **YouTube Music/Custom branding icon:** patch fails on certain versions ([115ff0d](115ff0d))
* **YouTube Music/Disable auto captions:** captions cannot be changed when `Disable forced auto captions` is turned on ([d708f36](d708f36))
* **YouTube Music/Disable Cairo splash animation:** some versions are recognized as unpatchable even though they can be patched ([577f49b](577f49b))
* **YouTube Music/Flyout menu components:** unable to patch due to incorrect format ([96dc5cf](96dc5cf))
* **YouTube Music/GmsCore support:** `Open GmsCore` setting is not added if user only includes `GmsCore support` patch inotia00/ReVanced_Extended#2351 ([3720b4a](3720b4a))
* **YouTube Music/GmsCore support:** can't share the stories to Facebook, Instagram and Snapchat inotia00/ReVanced_Extended#1830 ([a041ca2](a041ca2))
* **YouTube Music/GmsCore support:** YT Music crashes when using the `Open GmsCore` setting inotia00/ReVanced_Extended#2352 ([1205958](1205958))
* **YouTube Music/Player components:** `Hide Audio / Video toggle` setting not working in landscape mode ([5422914](5422914))
* **YouTube Music/Player components:** `Remember shuffle state` setting does not remember the correct state ([8333bf7](8333bf7))
* **YouTube Music/Player components:** patches do not apply properly in certain versions ([a4227ae](a4227ae))
* **YouTube Music/Sanitize sharing links:** tracking parameters are not removed from the system share panel ([4aec1a1](4aec1a1))
* **YouTube Music/SponsorBlock:** SponsorBlock does not skip segment at the beginning when in background inotia00/ReVanced_Extended#2396 ([e25bd10](e25bd10))
* **YouTube Music/SponsorBlock:** SponsorBlock segments at the end of a song cause the player to get stuck inotia00/ReVanced_Extended#2360 ([547fd29](547fd29))
* **YouTube Music/Spoof app version:** ListPreference sometimes selects wrong values ([b219e0d](b219e0d))
* **YouTube/Custom Shorts action buttons:** low image quality for `Cairo` option on YouTube 18.29.38 ([7da0b55](7da0b55))
* **YouTube/Disable force auto captions:** add information to summary that it doesn't work in Shorts inotia00/ReVanced_Extended#2346 ([277133e](277133e))
* **YouTube/Disable force auto captions:** patch doesn't work with Shorts inotia00/ReVanced_Extended#2346 ([9d5998b](9d5998b))
* **YouTube/Hide feed components:** `Hide carousel shelf` setting sometimes hides the library shelf ([1cf3c6d](1cf3c6d))
* **YouTube/Hide feed components:** `Hide Latest videos button` setting does not support tablets ([inotia00#89](https://github.com/Laitinlok/revanced-patches/issues/89)) ([c932956](c932956))
* **YouTube/Hide feed components:** `Hide related videos` setting hides the player flyout component ([4558869](4558869))
* **YouTube/Hide feed components:** change default offset for `Hide related videos` setting ([6fc7680](6fc7680))
* **YouTube/Hook YouTube Music actions:** app crashes when first installed ([1bc0d73](1bc0d73))
* **YouTube/Integrations:** skip patches even in versions where fingerprints are still used ([79bfd1e](79bfd1e))
* **YouTube/Litho filter:** disable obfuscation ([2864fb1](2864fb1))
* **YouTube/Overlay buttons:** paddingBottom is not set when patch option `WiderButtonsSpace` is TRUE inotia00#87 ([30a88bd](30a88bd))
* **YouTube/Overlay buttons:** paddingBottom is not set when patch option `WiderButtonsSpace` is TRUE inotia00#87 ([387891e](387891e))
* **YouTube/Overlay buttons:** support A/B player layout ([a25919b](a25919b))
* **YouTube/Player components:** `Disable player popup panels` setting disables the engagement panel in Mix playlists on certain YouTube version ([6d48ade](6d48ade))
* **YouTube/Player components:** patch is broken in certain versions ([697dc74](697dc74))
* **YouTube/Settings:**  EditTextDialog's background color does not match when `Theme` patch is excluded inotia00/ReVanced_Extended#2422 ([12127d6](12127d6))
* **YouTube/Settings:** `Search bar in settings` can't find `RYD` and `SponsorBlock` settings ([9bd51f7](9bd51f7))
* **YouTube/Settings:** `Swap Create and Notifications button` description cuts off inotia00/ReVanced_Extended#2373 ([357ad60](357ad60))
* **YouTube/Settings:** clarify the description of some settings inotia00/ReVanced_Extended#2393 ([f92cb71](f92cb71))
* **YouTube/Settings:** remove duplicate descriptions ([8d8af80](8d8af80))
* **YouTube/Shorts components:** `Hide paused header` setting does not work ([17cabfb](17cabfb))
* **YouTube/Shorts components:** even if `Hide navigation bar` is turned on, the navigation bar will reappear when the user opens the comments or description panel in Shorts ([2cdc05a](2cdc05a))
* **YouTube/SponsorBlock:** add summary text to 'view my segments' button ([8db7d0e](8db7d0e))
* **YouTube/SponsorBlock:** handle if the user enters an invalid number into any SB settings ([d6739ef](d6739ef))
* **YouTube/Spoof app version:** remove obsolete 17.33.42 spoof target ([823ccf4](823ccf4))
* **YouTube/Spoof streaming data:** Log out the iOS client to allow video playback ([inotia00#100](https://github.com/Laitinlok/revanced-patches/issues/100)) ([0dee7c1](0dee7c1))
* **YouTube/Spoof streaming data:** update side effects ([2980d48](2980d48))
* **YouTube/Spoof streaming data:** wrong register used ([f29fbae](f29fbae))
* **YouTube/Theme:** revert `reverts background color of More comments icon in live chats` inotia00/ReVanced_Extended#2197 ([bd6690c](bd6690c))
* **YouTube/Video information:** app crash when casting inotia00/ReVanced_Extended#2309 ([c805c17](c805c17))
* **YouTube/YT Music - GmsCore support:** unimplemented service in GmsCore causes memory leak ([f999aea](f999aea))
* **YouTube:** String typos and grammar ([inotia00#84](https://github.com/Laitinlok/revanced-patches/issues/84)) ([8119eef](8119eef))

### Features

* **Hide ads:** remove `Close fullscreen ads` setting inotia00/ReVanced_Extended#2017 (comment) ([2d6142b](2d6142b)), closes [/github.com/inotia00/ReVanced_Extended/issues/2017#issuecomment-2351327068](https://github.com//github.com/inotia00/ReVanced_Extended/issues/2017/issues/issuecomment-2351327068)
* **Return YouTube Dislike:** add `Show estimated likes` setting ([40cecc6](40cecc6))
* **Translations:** update translation ([7b0cc3b](7b0cc3b))
* **Translations:** update translation ([c8f9abe](c8f9abe))
* **Translations:** update translation ([606fb1a](606fb1a))
* **Translations:** update translation ([002af89](002af89))
* **Translations:** update translation ([4ad4a8f](4ad4a8f))
* **Translations:** update translation ([a2ee407](a2ee407))
* **Translations:** update translation ([23a0654](23a0654))
* **Translations:** update translation ([34587af](34587af))
* **Translations:** update translation ([231b7f0](231b7f0))
* **Translations:** update translation ([63224c2](63224c2))
* **Translations:** update translation ([a4b926d](a4b926d))
* **Translations:** update translation ([d19978b](d19978b))
* **Translations:** update translation ([fd49621](fd49621))
* **Translations:** update translation ([c0d3cf8](c0d3cf8))
* **Translations:** update translation ([2a75373](2a75373))
* **Translations:** update translation ([49ca584](49ca584))
* **Translations:** update translation ([9eac957](9eac957))
* **Translations:** update translation ([b79372a](b79372a))
* **Translations:** update translation ([72f0970](72f0970))
* **Translations:** update translation ([6a94ada](6a94ada))
* **Translations:** update translation ([51b4efe](51b4efe))
* **Translations:** update translation ([12c3056](12c3056))
* **Translations:** update translation ([54e686c](54e686c))
* **Translations:** update translation ([c35ce40](c35ce40))
* **Translations:** update translation ([a1e34b4](a1e34b4))
* **YouTube Music/Custom branding icon for YouTube Music:** add patch option `RestoreOldSplashIcon` inotia00/ReVanced_Extended#2368 ([cdbd349](cdbd349))
* **YouTube Music/Custom branding icon for YouTube Music:** Update monochrome icon for afn_red & afn_blue ([inotia00#82](https://github.com/Laitinlok/revanced-patches/issues/82)) ([507072d](507072d))
* **YouTube Music/Hide ads:** add `Hide promotion alert banner` setting ([94f7c5b](94f7c5b))
* **YouTube Music/Navigation bar components:** do not use hardcoded color `Enable black navigation bar` setting is turned off inotia00/ReVanced_Extended#2440 ([194ca27](194ca27))
* **YouTube Music/Settings:** add `Open default app settings` setting inotia00/ReVanced_Extended#1861 ([6b5c03b](6b5c03b))
* **YouTube Music/Spoof app version:** add target version 7.16.53 ([3edd8eb](3edd8eb))
* **YouTube Music/Spoof app version:** app crashes when first installed ([4387c55](4387c55))
* **YouTube Music/Video playback:** add an option to disable toasts when changing the default values ([c992f4a](c992f4a))
* **YouTube Music:** add `Visual preferences icons for YouTube Music` patch inotia00/ReVanced_Extended#2216 ([8f5be6f](8f5be6f))
* **YouTube Music:** add support version `6.20.51` ([inotia00#81](https://github.com/Laitinlok/revanced-patches/issues/81)) ([225adc7](225adc7))
* **YouTube Music:** add support versions `7.15.52` ~ `7.16.52` ([010a19f](010a19f))
* **YouTube Music:** add support versions `7.16.53` ~ `7.17.51` ([faa112e](faa112e))
* **YouTube Music:** changes to supported versions - changed `6.29.58` to `6.29.59`, changed `7.16.52` to `7.16.53`, removed `6.33.52` (as it is almost the same as `6.29.59`) ([42ecfa9](42ecfa9))
* **YouTube Music:** drop support version `7.17.51` inotia00/ReVanced_Extended#2382 ([cc71acf](cc71acf))
* **YouTube Music:** rename `Enable Cairo splash animation` to `Disable Cairo splash animation` inotia00/ReVanced_Extended#2366 ([3d331a7](3d331a7))
* **YouTube/Change start page:** add `Change start page type` setting inotia00/ReVanced_Extended#2395 (comment) ([e8ad2e6](e8ad2e6)), closes [/github.com/inotia00/ReVanced_Extended/issues/2395#issuecomment-2368848355](https://github.com//github.com/inotia00/ReVanced_Extended/issues/2395/issues/issuecomment-2368848355)
* **YouTube/Change start page:** change the actual start page instead of redirecting the Url inotia00/ReVanced_Extended#2395 ([37e00d4](37e00d4))
* **YouTube/Custom branding icon:** add patch option `YouTube (Minimal header)` ([inotia00#83](https://github.com/Laitinlok/revanced-patches/issues/83)) ([29f4e06](29f4e06))
* **YouTube/Custom Shorts action buttons:**  add patch option `Cairo` ([e601cca](e601cca))
* **YouTube/Description components:** add `Hide AI-generated video summary section` setting inotia00/ReVanced_Extended#2473 ([200e2b8](200e2b8))
* **YouTube/Hide ads:** add `Hide player shopping shelf` setting inotia00/ReVanced_Extended#2447 ([dc379e5](dc379e5))
* **YouTube/Hide ads:** add `Hide promotion alert banner` setting ([82777db](82777db))
* **YouTube/Hide comments components:** add `Hide highlighted search links` setting inotia00/ReVanced_Extended#2435 ([df53fdf](df53fdf))
* **YouTube/Hide feed components:** add `Hide expandable shelves` setting ([6587ba7](6587ba7))
* **YouTube/Hide feed components:** add `Hide floating button` setting ([e644186](e644186))
* **YouTube/Hide feed components:** add `Hide related videos` setting ([389f414](389f414))
* **YouTube/Hide feed components:** add `Hide UPCOMING video` setting ([0b49445](0b49445))
* **YouTube/Hide feed components:** add offset for `Hide related videos` setting ([907bc9b](907bc9b))
* **YouTube/Hide feed components:** add syntax to match whole keywords and not substrings ([28ede81](28ede81))
* **YouTube/Hide feed components:** remove `Duration filter` setting as it no longer works due to server side changes inotia00/ReVanced_Extended#2389 ([aa78830](aa78830))
* **YouTube/Hide feed components:** remove `Hide UPCOMING video` setting ([b4a67d3](b4a67d3))
* **YouTube/Hide feed components:** selectively hide video by views for Home / Subscription / Search ([780dd0a](780dd0a))
* **YouTube/Hide player flyout menu:** add `Hide 1080p Premium menu` setting ([4eafb40](4eafb40))
* **YouTube/Hide player flyout menu:** add `Hide Sleep timer` setting ([c959612](c959612))
* **YouTube/Hide player flyout menu:** remove `Hide Ambient mode menu` setting ([8250dea](8250dea))
* **YouTube/Hide player flyout menu:** restore `Hide Ambient mode menu` setting ([8b3c44f](8b3c44f))
* **YouTube/Navigation bar components:** add `Hide navigation bar` setting ([6c060c5](6c060c5))
* **YouTube/Overlay buttons:** add `Collapse` button and update thin-type overlay button icons ([inotia00#75](https://github.com/Laitinlok/revanced-patches/issues/75)) ([984cd21](984cd21))
* **YouTube/Overlay buttons:** add patch option `WiderButtonsSpace` ([inotia00#87](https://github.com/Laitinlok/revanced-patches/issues/87)) ([3827424](3827424))
* **YouTube/Overlay buttons:** change patch options inotia00/ReVanced_Extended#2359 ([5823acc](5823acc))
* **YouTube/Overlay buttons:** replace `time-ordered playlist` button with `play all` button ([inotia00#96](https://github.com/Laitinlok/revanced-patches/issues/96)) ([9982245](9982245))
* **YouTube/Player components:** add `Disable switch mix playlists` setting ([fc832e2](fc832e2))
* **YouTube/Player components:** add `Sanitize video subtitle` setting ([8d9da83](8d9da83))
* **YouTube/PlayerTypeHook:** add hooking on Shorts state (whether Shorts is open or not) ([bb4f8bf](bb4f8bf))
* **YouTube/Remove background playback restrictions:** match with ReVanced ([9cb1b4f](9cb1b4f))
* **YouTube/Seekbar components:** add `Disable seekbar chapters` setting ([504998f](504998f))
* **YouTube/Seekbar components:** add `Enable high quality thumbnails` setting ([8af117b](8af117b))
* **YouTube/Seekbar components:** Add info to `Append timestamp information` summary about tapping the appended information ([inotia00#93](https://github.com/Laitinlok/revanced-patches/issues/93)) ([93e0f3b](93e0f3b))
* **YouTube/Seekbar components:** remove `Enable high quality thumbnails` setting inotia00/ReVanced_Extended#2460 ([065854e](065854e))
* **YouTube/Shorts Component:** add `Disable Like button animation` setting ([5a77518](5a77518))
* **YouTube/Shorts Component:** always hide suggested actions if all sub-settings of the suggested actions category are enabled ([ec68f16](ec68f16))
* **YouTube/Shorts components:** add `Height percentage of empty space` setting ([4c824b4](4c824b4))
* **YouTube/Shorts components:** add `Hide in channel` setting (Hide the Shorts shelf on the channel home tab) ([5b45fb8](5b45fb8))
* **YouTube/Shorts components:** add `Hide stickers` setting ([7944107](7944107))
* **YouTube/Shorts components:** add `Hide Use this sound button` setting ([4fff1ca](4fff1ca))
* **YouTube/Shorts components:** add settings - `Hide floating button`, `Hide Trends button`, `Hide Use template button` ([166f1a0](166f1a0))
* **YouTube/Shorts components:** clarify the description of some settings inotia00/ReVanced_Extended#2357 ([de0ccbf](de0ccbf))
* **YouTube/Shorts components:** remove `Hide in watch history` setting ([bc8a586](bc8a586))
* **YouTube/Spoof app version:** add target version `19.13.37 - Restores old style Rolling number animations` inotia00/ReVanced_Extended#2419 (comment) ([bc48f2b](bc48f2b)), closes [/github.com/inotia00/ReVanced_Extended/issues/2419#issuecomment-2408912233](https://github.com//github.com/inotia00/ReVanced_Extended/issues/2419/issues/issuecomment-2408912233)
* **YouTube/Spoof app version:** change the default to off and show the dialog when the app is first installed ([105a9fa](105a9fa))
* **YouTube/Spoof app version:** enabled by default in YouTube 19.16.39+ ([620aeae](620aeae))
* **YouTube/Spoof app version:** remove obsolete 19.13.37 spoof target inotia00/ReVanced_Extended#2477 ([173494d](173494d))
* **YouTube/Spoof client:** allow forcing AVC codec with iOS ([4dd7255](4dd7255))
* **YouTube/Spoof streaming data:** add `iOS Compatibility mode` setting ([47c4aca](47c4aca))
* **YouTube/Spoof streaming data:** match with ReVanced ([9cbc019](9cbc019))
* **YouTube/Spoof streaming data:** match with ReVanced ([088f0eb](088f0eb))
* **YouTube/Spoof streaming data:** match with ReVanced ([1ef8639](1ef8639))
* **YouTube/Spoof streaming data:** update the hardcoded iOS client version inotia00/ReVanced_Extended#2480 ([f0cf292](f0cf292))
* **YouTube/Swipe controls:** add `Swipe sensitivity` settings ([de5ddb9](de5ddb9))
* **YouTube/Toolbar components:** add `Hide YouTube Doodles` setting ([c023138](c023138))
* **YouTube/Video playback:** add `Disable playback speed for music` setting ([73dc0d0](73dc0d0))
* **YouTube/Video playback:** add `Disable VP9 codec` setting inotia00/ReVanced_Extended#2384 ([753a44f](753a44f))
* **YouTube/Video playback:** add an option to disable toasts when changing the default values ([inotia00#78](https://github.com/Laitinlok/revanced-patches/issues/78)) ([4c22853](4c22853))
* **YouTube/Visual preferences icons:** add the patch option `ApplyToAll ` that do not apply to sub-settings inotia00/ReVanced_Extended#2392 ([5e4b56c](5e4b56c))
* **YouTube/YT - GmsCore support:** add patch option `Disable GmsService Broker` inotia00/ReVanced_Extended#2442 (comment) ([19a8677](19a8677)), closes [/github.com/inotia00/ReVanced_Extended/issues/2442#issuecomment-2424694043](https://github.com//github.com/inotia00/ReVanced_Extended/issues/2442/issues/issuecomment-2424694043)
* **YouTube/YT Music - Return YouTube Username:** add `Display format` setting ([828f83a](828f83a))
* **YouTube/YT Music:** add `Return YouTube Username` patch ([9733b60](9733b60))
* **YouTube:** add `Change share sheet` patch ([7339479](7339479))
* **YouTube:** add `Hide shortcuts` patch ([63d7b6c](63d7b6c))
* **YouTube:** add `Hook YouTube Music actions` patch ([ce55617](ce55617))
* **YouTube:** add `Spoof streaming data` patch ([15a9d7c](15a9d7c))
* **YouTube:** remove `Spoof client` patch ([0d29ed6](0d29ed6))
* **YouTube:** rename `Visual preferences icons` to `Visual preferences icons for YouTube` ([9be6315](9be6315))
* **YouTube:** replace with a fingerprint that supports a wider range of versions ([41e00d6](41e00d6))
* **YouTube:** revert all changes except minimal-header ([b1a9e04](b1a9e04))

### Performance Improvements

* **YouTube/GmsCore support:** improve performance by using hashsets ([cae2f6c](cae2f6c))

### Reverts

* Revert "feat(YouTube/Custom branding icon): add patch option `YouTube (Minima…" ([inotia00#86](https://github.com/Laitinlok/revanced-patches/issues/86)) ([24395de](24395de))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug report Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@smed79 @nick-77 @KobeW50 @inotia00 @ILoveOpenSourceApplications @federicogith