From 4ce883ae217aad5d3261926e8ca0ccecffbfdc66 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mikel=20Mart=C3=ADn?= Date: Wed, 13 Dec 2023 09:56:24 +0100 Subject: [PATCH] MDL-75670 theme: Refactor form-group helper class dropped in BS5 - Replace .form-group Boostrap helper class with .mb-3. The .form-group class was only adding margin bottom styles, so it is an straightforward change. - Replace .form-group references in SCSS files with .fitem now .form-group has been removed. - There were some other .form-group occurrences in the code that were using it not for styling but incorrectly for managing some logic. These have been also replaced with .fitem or removed. --- .../classes/define_role_table_advanced.php | 2 +- .../setting_courselist_frontpage.mustache | 4 +- admin/templates/setting_emoticons.mustache | 2 +- .../templates/setting_gradecat_combo.mustache | 2 +- admin/tests/behat/behat_admin.php | 1 - .../templates/category_purpose_form.mustache | 6 +-- .../langimport/templates/langimport.mustache | 8 ++-- .../site_competencies_form_element.php | 2 +- .../lp/templates/competency_picker.mustache | 2 +- .../competency_picker_competencyform.mustache | 2 +- .../competency_picker_user_plans.mustache | 2 +- .../templates/competency_rule_config.mustache | 4 +- auth/shibboleth/templates/login_form.mustache | 2 +- ...odle-availability_completion-form-debug.js | 2 +- .../moodle-availability_completion-form.js | 2 +- .../completion/yui/src/form/js/form.js | 2 +- .../moodle-availability_grade-form-debug.js | 6 +-- .../moodle-availability_grade-form.js | 6 +-- .../condition/grade/yui/src/form/js/form.js | 6 +-- blocks/login/block_login.php | 8 ++-- .../templates/export_calendar_url.mustache | 2 +- enrol/yui/rolemanager/rolemanager.js | 2 +- .../grades/grader/gradingpanel.mustache | 4 +- .../grades/grader/gradingpanel.mustache | 2 +- .../grades/grader/gradingpanel/point.mustache | 2 +- .../grades/grader/gradingpanel/scale.mustache | 2 +- group/templates/index.mustache | 22 +++++----- .../moodle-atto_media-button-debug.js | 4 +- .../moodle-atto_media-button.js | 4 +- .../plugins/media/yui/src/button/js/button.js | 4 +- .../moodle-atto_table-button-debug.js | 22 +++++----- .../moodle-atto_table-button.js | 22 +++++----- .../plugins/table/yui/src/button/js/button.js | 22 +++++----- .../embed_media_modal_audio.mustache | 40 ++++++++--------- .../embed_media_modal_video.mustache | 40 ++++++++--------- .../templates/element-advcheckbox.mustache | 2 +- lib/form/templates/element-checkbox.mustache | 2 +- lib/form/templates/element-radio.mustache | 2 +- .../element-template-inline.mustache | 2 +- lib/form/templates/element-template.mustache | 2 +- .../filemanager_default_searchform.mustache | 2 +- lib/templates/filemanager_fileselect.mustache | 16 +++---- lib/templates/filemanager_loginform.mustache | 12 ++--- .../filemanager_selectlayout.mustache | 10 ++--- lib/templates/filemanager_uploadform.mustache | 8 ++-- lib/templates/loginform.mustache | 10 ++--- mod/chat/gui_ajax/index.php | 6 +-- mod/data/preset/imagegallery/addtemplate.html | 6 +-- .../preset/imagegallery/asearchtemplate.html | 8 ++-- mod/data/preset/journal/addtemplate.html | 4 +- mod/data/preset/journal/asearchtemplate.html | 8 ++-- mod/data/preset/proposals/addtemplate.html | 8 ++-- .../preset/proposals/asearchtemplate.html | 12 ++--- mod/data/preset/resources/addtemplate.html | 12 ++--- .../preset/resources/asearchtemplate.html | 14 +++--- .../defaulttemplate_addtemplate.mustache | 4 +- .../defaulttemplate_asearchtemplate.mustache | 8 ++-- mod/forum/classes/output/big_search_form.php | 20 ++++----- mod/glossary/editcategories.html | 10 ++--- .../classes/form/preview_options_form.php | 2 +- .../templates/tag_condition.mustache | 2 +- tag/templates/add_tag_collection.mustache | 4 +- tag/templates/add_tags.mustache | 2 +- tag/templates/combine_tags.mustache | 2 +- .../amd/build/form-display-errors.min.js | 2 +- .../amd/build/form-display-errors.min.js.map | 2 +- theme/boost/amd/src/form-display-errors.js | 2 +- theme/boost/scss/moodle/backup-restore.scss | 2 +- theme/boost/scss/moodle/forms.scss | 6 +-- theme/boost/scss/moodle/modules.scss | 2 +- theme/boost/scss/moodle/question.scss | 2 +- theme/boost/scss/moodle/reportbuilder.scss | 8 ++-- theme/boost/style/moodle.css | 44 +++++++++---------- theme/boost/upgrade.txt | 1 + theme/classic/style/moodle.css | 44 +++++++++---------- .../behat/behat_theme_classic_behat_admin.php | 1 - 76 files changed, 290 insertions(+), 291 deletions(-) diff --git a/admin/roles/classes/define_role_table_advanced.php b/admin/roles/classes/define_role_table_advanced.php index f230e0eb905c7..57b449f7aa24e 100644 --- a/admin/roles/classes/define_role_table_advanced.php +++ b/admin/roles/classes/define_role_table_advanced.php @@ -645,7 +645,7 @@ protected function get_role_risks_info() { protected function print_field($name, $caption, $field, $helpicon = null) { global $OUTPUT; // Attempt to generate HTML like formslib. - echo '
'; + echo '
'; echo '
'; if ($name) { echo '