Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.1.2 appears to have removed some zip codes? #13

Open
garethson opened this issue Nov 26, 2024 · 3 comments
Open

5.1.2 appears to have removed some zip codes? #13

garethson opened this issue Nov 26, 2024 · 3 comments

Comments

@garethson
Copy link

When updating the version of this gem to 5.1.2, it appears as though quite a few zip codes where removed. Doing

select count(*) from zip_codes

5.1.1 gives us 40998 codes, 5.1.2 gives us 39211.

Not sure how many examples it would take, but one we've found is "12345" which does appear to be a valid code. I'm not 100% sure of the source of the data, otherwise we'd try to fix, but this appears to have been introduced a couple day ago in 35c7e48.

Thanks!

@mr-notorious
Copy link

Looks like unique zip codes were removed (e.g., organization's mail rooms).

@garethson
Copy link
Author

Interesting, so my assumption that 12345 is a valid ZIP is not actually true. I just found what appears to be a canonical list of ZIP codes at least via USPS, and 12345 is not present. That being said, there are currently 44196 records, I'm curious as to the difference here.

@mr-notorious
Copy link

From my limited understanding, 12345 is a valid delivery ZIP code. It is row 560 on the "Unique-ZIP_DETAIL" sheet.

The reason why the counts are not matching between this project and USPS is because USPS has duplicates. I guess this means the mail can be routed to more-than-one post office.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants