Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(input.azure_monitor): Use default azure credentials chain when no secret provided #15395

Merged
merged 2 commits into from
Jun 5, 2024
Merged

feat(input.azure_monitor): Use default azure credentials chain when no secret provided #15395

merged 2 commits into from
Jun 5, 2024

Conversation

redbaron
Copy link
Contributor

Summary

This allows Telegraf authenticating with Workload Identity on K8S or with
VM identity when running directly on a virtual machine.

Checklist

  • No AI generated code was used in this PR

redbaron
redbaron commented May 23, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@redbaron redbaron force-pushed the azure-wi branch 3 times, most recently from 6d942d2 to 98d1cd9 Compare May 23, 2024 12:29
@redbaron redbaron changed the title input.azure_monitor: use default azure creds chain when no secret provided feat(input.azure_monitor): use default azure creds chain when no secret provided May 23, 2024
@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels May 23, 2024
@redbaron redbaron force-pushed the azure-wi branch 2 times, most recently from e92378a to 9764c74 Compare May 23, 2024 12:50
@powersj
Copy link
Contributor

powersj commented May 23, 2024

Thanks for the PR and doing the work for the library! I'd obviously prefer we get this landed in the upstream library, so I will let this sit over the weekend and revisit then.

@redbaron
feat(input.azure_monitor): use default azure creds chain when no secr…
3d818d9 
…et provided

This allows Telegraf authenticating with Workload Identity on K8S or with
VM identity when running directly on a virtual machine.
powersj
powersj approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 4, 2024
@powersj powersj assigned srebhan and DStrand1 and unassigned powersj Jun 4, 2024
@redbaron
Copy link
Contributor Author

redbaron commented Jun 4, 2024

Test failure seems to be unrelated

@DStrand1 DStrand1 removed their assignment Jun 4, 2024
@srebhan srebhan changed the title feat(input.azure_monitor): use default azure creds chain when no secret provided feat(input.azure_monitor): Use default azure credentials chain when no secret provided Jun 5, 2024
srebhan
srebhan reviewed Jun 5, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@redbaron just one comment/simplification...

plugins/inputs/azure_monitor/azure_monitor.go Outdated Show resolved Hide resolved
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jun 5, 2024

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

srebhan
srebhan approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update and your contribution @redbaron!

@srebhan srebhan merged commit c663680 into influxdata:master Jun 5, 2024
26 of 27 checks passed
@github-actions github-actions bot added this to the v1.31.0 milestone Jun 5, 2024
@redbaron redbaron deleted the azure-wi branch June 5, 2024 22:01
@BrewTestBot BrewTestBot mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DStrand1 DStrand1 DStrand1 approved these changes

@srebhan srebhan srebhan approved these changes

@powersj powersj powersj approved these changes

Assignees

@srebhan srebhan

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.31.0
Development

Successfully merging this pull request may close these issues.
4 participants
@redbaron @powersj @srebhan @DStrand1