Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redfish enable/disable specific metrics categories #14140

Closed
rismoney opened this issue Oct 18, 2023 · 5 comments · Fixed by #14143
Closed

redfish enable/disable specific metrics categories #14140

rismoney opened this issue Oct 18, 2023 · 5 comments · Fixed by #14143
Labels
feature request Requests for new plugin and for new features to existing plugins

Comments

@rismoney
Copy link

Use Case

It can be quite expensive on big systems to query thermals, power, voltage, etc.

Expected behavior

Be able to just enable power collection

Actual behavior

You get all metrics thermals, power, voltage.

Additional info

Not sure what the best way to do this, but filtering, if I understand correctly is performed after the input is collected, and doesn't alleviate the https queries going out for all the additional calls.

@rismoney rismoney added the feature request Requests for new plugin and for new features to existing plugins label Oct 18, 2023
@powersj
Copy link
Contributor

powersj commented Oct 18, 2023

Hi,

Looking at the Gather function, there really is only two things we could break this down into:

  • Thermal - which produces temperatures and fans
  • Power - which produces power control, power supplies, and voltages

Generally, we have a config option that is used to specify which parts you would want to collect. Something like:

## Specify the metrics to collect
# collection = ["thermal", "power"]

You could possibly also disable the call to getChassis if the tagSetChassisLocation is not set.

Is this what you are after? Would you be willing to put up a PR?

@powersj powersj added the waiting for response waiting for response from contributor label Oct 18, 2023
@rismoney
Copy link
Author

That is definitely what I am after!

collection = ["power"] would totally work and reduce a huge burden across the 1000s of systems interrogated. Unfortunately I don't think I can contribute a PR at this time.

@powersj
Copy link
Contributor

powersj commented Oct 18, 2023

I put up a quick PR in #14143. In 20-30mins there will be artifacts attached to that PR that you could download. Could you give the new option a try and confirm you get what you expect:

include_metrics = ["power"]

Thanks!

@powersj powersj added the waiting for response waiting for response from contributor label Oct 18, 2023
@rismoney
Copy link
Author

Wow that was fast! I will attempt to do this now. Will report back shortly.

@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Oct 18, 2023
@rismoney
Copy link
Author

I tested exactly this, and it worked 100% as expected! I am so thankful and kudos to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants