Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go test -v ./... failures #214

Open
jdstrand opened this issue Nov 18, 2022 · 1 comment
Open

go test -v ./... failures #214

jdstrand opened this issue Nov 18, 2022 · 1 comment

Comments

@jdstrand
Copy link
Contributor

Trying to run the tests, it fails:

$ go test -v ./...
...
cmd/bulk_load_timescale/main.go:20:2: module github.com/jackc/pgx@latest found (v3.6.2+incompatible), but does not contain package github.com/jackc/pgx/pgxpool

Googling, this should be github.com/jackc/pgx/v4/pgxpool now.

So apply the following diff:

$ git diff
diff --git a/cmd/bulk_load_timescale/main.go b/cmd/bulk_load_timescale/main.go
index e366584..6303b71 100644
--- a/cmd/bulk_load_timescale/main.go
+++ b/cmd/bulk_load_timescale/main.go
@@ -16,8 +16,8 @@ import (
 
        "github.com/influxdata/influxdb-comparisons/bulk_load"
        "github.com/influxdata/influxdb-comparisons/util/report"
-       "github.com/jackc/pgx"
-       "github.com/jackc/pgx/pgxpool"
+       "github.com/jackc/pgx/v4"
+       "github.com/jackc/pgx/v4/pgxpool"
 
        "bytes"
        "context"
diff --git a/cmd/query_benchmarker_timescale/main.go b/cmd/query_benchmarker_timescale/main.go
index 3c79f4c..74f0ee6 100644
--- a/cmd/query_benchmarker_timescale/main.go
+++ b/cmd/query_benchmarker_timescale/main.go
@@ -22,8 +22,8 @@ import (
        "strings"
 
        "github.com/influxdata/influxdb-comparisons/util/report"
-       "github.com/jackc/pgx"
-       "github.com/jackc/pgx/pgxpool"
+       "github.com/jackc/pgx/v4"
+       "github.com/jackc/pgx/v4/pgxpool"
 )
 
 type TimescaleQueryBenchmarker struct {

Then run go mod tidy. Now we can get some test results but still see failures (apparently need a V1 and and V2 influxdb running?):

# github.com/gocql/gocql
../../go/pkg/mod/github.com/gocql/[email protected]/dial.go:79:18: tconn.HandshakeContext undefined (type *tls.Conn has no field or method HandshakeContext)
?   	github.com/influxdata/influxdb-comparisons/bulk_data_gen/common	[no test files]
?   	github.com/influxdata/influxdb-comparisons/bulk_data_gen/dashboard	[no test files]
?   	github.com/influxdata/influxdb-comparisons/bulk_data_gen/devops	[no test files]
?   	github.com/influxdata/influxdb-comparisons/bulk_data_gen/iot	[no test files]
?   	github.com/influxdata/influxdb-comparisons/bulk_data_gen/metaqueries	[no test files]
?   	github.com/influxdata/influxdb-comparisons/bulk_data_gen/multi_measurement	[no test files]
# github.com/influxdata/influxdb-comparisons/bulk_query/http
bulk_query/http/http_client.go:124:14: Fprintf format %s has arg pretty of wrong type bytes.Buffer
?   	github.com/influxdata/influxdb-comparisons/bulk_load	[no test files]
# github.com/influxdata/influxdb-comparisons/bulk_query
vet: bulk_query/query.go:431:2: waitFinished declared but not used
=== RUN   TestResultsInfluxDbV1
    result_test.go:29: 
        	Error Trace:	/home/ubuntu/code/influxdb-comparisons.git/util/report/result_test.go:29
        	Error:      	Received unexpected error:
        	            	dial tcp4 127.0.0.1:8086: connect: connection refused
        	Test:       	TestResultsInfluxDbV1
--- FAIL: TestResultsInfluxDbV1 (0.00s)
=== RUN   TestResultsInfluxDbV2
    result_test.go:52: 
        	Error Trace:	/home/ubuntu/code/influxdb-comparisons.git/util/report/result_test.go:52
        	Error:      	Received unexpected error:
        	            	dial tcp4 127.0.0.1:9999: connect: connection refused
        	Test:       	TestResultsInfluxDbV2
--- FAIL: TestResultsInfluxDbV2 (0.00s)
FAIL
FAIL	github.com/influxdata/influxdb-comparisons/util/report	0.003s
@jdstrand
Copy link
Contributor Author

cc @MaduMitha-Ravi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant