Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta, links, and errors Inside Included Block are ignored #71

Open
thisAAY opened this issue Aug 9, 2024 · 2 comments
Open

Meta, links, and errors Inside Included Block are ignored #71

thisAAY opened this issue Aug 9, 2024 · 2 comments

Comments

@thisAAY
Copy link
Collaborator

thisAAY commented Aug 9, 2024

Issue: Ignoring meta, links, and errors Inside included Block

Description

After the PR has been merged, the issue of crashes caused by meta fields inside the included block has been resolved. However, the underlying problem persists in that the library is currently ignoring meta, links, and errors fields when they appear inside the included block.

Current Behavior

  • meta, links, and errors in the included Block:
    • The library is currently configured to ignore meta, links, and errors fields when they are found inside the included block.
    • While this prevents crashes from occurring, it means that any data within these fields is not being processed or utilized, which could lead to incomplete data handling in applications.

Expected Behavior

The library should consistently process meta, links, and errors fields across all parts of the JSON:API structure, including within the included block. Specifically:

  • These fields should not be ignored within the included block.
  • If these fields are present, they should be properly deserialized and handled just like they are in the root or data blocks.
@KCeh
Copy link
Collaborator

KCeh commented Sep 6, 2024

@thisAAY can we close this?

@thisAAY
Copy link
Collaborator Author

thisAAY commented Sep 6, 2024

I will resume working on it, after vacation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants