Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CliHelpers as trait #382

Open
iruzevic opened this issue Oct 31, 2023 · 0 comments
Open

Remove CliHelpers as trait #382

iruzevic opened this issue Oct 31, 2023 · 0 comments
Labels
improvement Small improvement fixes, either readability or performance improvements wpcli Issues regarding WP-CLI

Comments

@iruzevic
Copy link
Member 

          why is `CliHelpers` a trait to begin with? converting classes to traits just to instantiate anonymous classes implementing them to call trait methods smells a lot. if you want ping me and we can talk about what you want to achieve with this

Originally posted by @mbmjertan in #381 (comment)
@iruzevic iruzevic mentioned this issue Oct 31, 2023
Merged
@iruzevic iruzevic added improvement Small improvement fixes, either readability or performance improvements wpcli Issues regarding WP-CLI labels Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Small improvement fixes, either readability or performance improvements wpcli Issues regarding WP-CLI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iruzevic