Ostruct related spec failures #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specs from #152 passed just fine until we merged, and then began to mysteriously fail. The passing specs from the PR offer a clue:
It would appear that our test suite was relying on Ruby's json library to load OpenStruct. They stopped explicitly requiring it earlier this year. Github Actions' Ruby 3.3.6 (which is now used in the 3.3 part of the test matrix) must be using that version of the library, so it never gets loaded, causing our error.
This PR just requires openstruct to get things working. it won't be included in the Ruby standard library in 3.5.0, so long term we'll either need to add it to the Gemfile or refactor the specs using it to use something like the new
Dataclass.