Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure ArrayContext is not hashable #203

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Ensure ArrayContext is not hashable #203

merged 1 commit into from
Oct 14, 2022

Conversation

alexfikl
Copy link
Collaborator

@alexfikl alexfikl commented Oct 14, 2022 •
edited
Loading

Custom objects have some hash based on their id()
https://docs.python.org/3/glossary.html#term-hashable

x-ref: inducer/meshmode#354
cc: @kaushikcfd

kaushikcfd
kaushikcfd approved these changes Oct 14, 2022
View reviewed changes
Copy link
Collaborator

@kaushikcfd kaushikcfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@inducer inducer merged commit c19ddb4 into inducer:main Oct 14, 2022
@inducer
Copy link
Owner

inducer commented Oct 14, 2022

Thanks!

@alexfikl alexfikl deleted the unhashable-context branch October 14, 2022 14:49
@inducer inducer mentioned this pull request Oct 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushikcfd kaushikcfd kaushikcfd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexfikl @inducer @kaushikcfd