From 9e7bb281c12940ae8c795cb1b46e3fef917a5430 Mon Sep 17 00:00:00 2001 From: Gregory J Thomas Date: Tue, 26 Nov 2024 13:08:56 -0500 Subject: [PATCH 1/3] LMSA-9500 - edit text on decrosslist page --- src/main/resources/templates/findParentCourse.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/resources/templates/findParentCourse.html b/src/main/resources/templates/findParentCourse.html index 2a376fb..aec60eb 100644 --- a/src/main/resources/templates/findParentCourse.html +++ b/src/main/resources/templates/findParentCourse.html @@ -107,9 +107,9 @@

- Select sections to remove, then activate De-cross-list selected sections to de-cross-list - them from the course. Unavailable sections are due to either not having a SIS ID or it is - the course's original section. + Select sections to remove, then activate the 'De-cross-list selected sections' button to + remove those sections from the course. Unavailable sections are those that do not have an + SIS ID, or it is the course's original section. From f10daff7470a949800328aeb4c6a5a4e3f24b4e7 Mon Sep 17 00:00:00 2001 From: Gregory J Thomas Date: Tue, 26 Nov 2024 14:51:46 -0500 Subject: [PATCH 2/3] LMSA-9499 - force sisSectionId passed to Canvas to be uppercase --- .../edu/iu/uits/lms/crosslist/service/CrosslistService.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/main/java/edu/iu/uits/lms/crosslist/service/CrosslistService.java b/src/main/java/edu/iu/uits/lms/crosslist/service/CrosslistService.java index ee14bb6..f5177f4 100644 --- a/src/main/java/edu/iu/uits/lms/crosslist/service/CrosslistService.java +++ b/src/main/java/edu/iu/uits/lms/crosslist/service/CrosslistService.java @@ -399,6 +399,9 @@ public FindParentResult processSisLookup(String sisSectionId) { return findParentResult; } + // this style of Canvas search is case-sensitive, so let's force the upper case that will be accurate for SIS + sisSectionId = sisSectionId.toUpperCase(); + Section section = sectionService.getSection(String.format("sis_section_id:%s", sisSectionId)); if (section == null) { From ea10662945ca56758c57a5fe4b5a4a4b7bf6b9d1 Mon Sep 17 00:00:00 2001 From: Gregory J Thomas Date: Tue, 3 Dec 2024 09:30:42 -0500 Subject: [PATCH 3/3] LMSA-9499 - efficiency change for uppercase --- .../edu/iu/uits/lms/crosslist/service/CrosslistService.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/main/java/edu/iu/uits/lms/crosslist/service/CrosslistService.java b/src/main/java/edu/iu/uits/lms/crosslist/service/CrosslistService.java index f5177f4..1e71b5f 100644 --- a/src/main/java/edu/iu/uits/lms/crosslist/service/CrosslistService.java +++ b/src/main/java/edu/iu/uits/lms/crosslist/service/CrosslistService.java @@ -400,9 +400,7 @@ public FindParentResult processSisLookup(String sisSectionId) { } // this style of Canvas search is case-sensitive, so let's force the upper case that will be accurate for SIS - sisSectionId = sisSectionId.toUpperCase(); - - Section section = sectionService.getSection(String.format("sis_section_id:%s", sisSectionId)); + Section section = sectionService.getSection(String.format("sis_section_id:%s", sisSectionId.toUpperCase())); if (section == null) { findParentResult.setShowCourseInfo(false);