Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate improvements to the binary woke update cycle within vs-code extension #19

Open
1 of 3 tasks
mkcomer opened this issue Jul 21, 2021 · 2 comments
Open
1 of 3 tasks
Labels
enhancement New feature or request vscode-woke-repo

Comments

@mkcomer
Copy link

mkcomer commented Jul 21, 2021

Description
Currently the vs-code woke extension doesn't manage the installation of woke. Rather, you need to install it yourself and it will use whatever it can find in your $PATH, or what you define in the extension setting woke.executablePath.

There is a disableVersionCheck on the vs-code woke extension that checks that your woke is up to date with the latest version. However, when I ran the VS Code extension on woke 0.9.0 and woke's latest is on version 0.16.0- nothing prompted me to update my woke binary.

Is the disableVersionCheck checking the vs-code woke extension version and not the woke binary version? Do we need a version check on the woke binary as well?

This could create compatibility issues, as well as confusion for why certain feature enhancements are not functional in the extension (if you are running your extension off an old binary woke).

Links/Additional Suggestions:

Acceptance Criteria:

Investigate improvements and enhance the woke update cycle:

  • Investigate disableVersionCheck - is there a bug in the check? Is it checking the vs-code-extension version or the woke binary version?
  • Implement check for woke binary version (if needed), and prompt the user to update if outdated ( disableVersionCheck in the vs-code-woke extension).
  • (Stretch) Investigate managing the woke update cycle directly from the extension - Is there a way to automate that when woke binary releases a new version, the vs-code-extension looks for the latest binary? Do we want this automated?
@mkcomer mkcomer added the enhancement New feature or request label Jul 21, 2021
@mkcomer mkcomer changed the title Enrich debug logging for vscode-woke to log out version of woke you are running Enrich vscode-woke to check and log out which binary version of woke you are running Oct 13, 2021
@mkcomer mkcomer changed the title Enrich vscode-woke to check and log out which binary version of woke you are running Investigate improvements to the binary woke update cycle within vs-code extension Oct 13, 2021
@mkcomer
Copy link
Author

mkcomer commented Oct 19, 2021

After investigating the disableVersionCheck, it appears that the vs-code-extension is checking the underlying woke binary. There is logic to compare the local binary vs. the BEST_TOOL_VERSION (the latest version of woke binary you should be on). If local binary version < BEST_TOOL_VERSION --> prompt user to update woke binary.

The BEST_TOOL_VERSION is hardcoded to 0.2.0. This explains why when I was running the extension on 0.9.0 and woke's latest is on version 0.16.0, I was not prompted to update my woke binary.

Is this desired functionality? Or a bug? Do we want to update the hardcoded version or automate this update cycle?

@mkcomer
Copy link
Author

mkcomer commented Oct 19, 2021

Opened issue with the maintainer to get early feedback re: if this is desired functionality, if we want to update the "BEST_TOOL_VERSION" or look into better ways to automate woke update cycle from woke releases to vs-code extension.

get-woke/vscode-woke#10

Will wait for feedback & continue updating this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vscode-woke-repo
Projects
None yet
Development

No branches or pull requests

1 participant