Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich error logging when adding custom configs (rule sets) #16

Closed
mkcomer opened this issue Jul 21, 2021 · 1 comment
Closed

Enrich error logging when adding custom configs (rule sets) #16

mkcomer opened this issue Jul 21, 2021 · 1 comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@mkcomer
Copy link

mkcomer commented Jul 21, 2021

When setting a custom config, I noticed:

if rule set contents is just "hello" --> we get error
FTL error="yaml: unmarshal errors:\n line 1: cannot unmarshal !!str hello into config.Config"
exit status 1

if rule set contents is "404: Not Found" --> no error, believes it is a valid yaml in general, but it is not a valid rule set yaml --> therefore doesn't add the custom rules and doesn't log this out. None of this information is provided in error logs.

Add enriched error logging when parsing of custom config (rule sets) fails.

I noticed this when designing this story: #1

@mkcomer mkcomer added the enhancement New feature or request label Jul 21, 2021
@mkcomer
Copy link
Author

mkcomer commented Oct 13, 2021

Duplicate issue to inclusive-dev-tools/#17

@mkcomer mkcomer closed this as completed Oct 13, 2021
@mkcomer mkcomer added the duplicate This issue or pull request already exists label Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant