Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for woke ignore files in subfolders #10

Open
1 of 4 tasks
armanrahman22 opened this issue Jul 14, 2021 · 3 comments
Open
1 of 4 tasks

Add support for woke ignore files in subfolders #10

armanrahman22 opened this issue Jul 14, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request High Priority pending upstream issue exists Add this label when there is a duplicate issue on the upstream repo

Comments

@armanrahman22
Copy link

armanrahman22 commented Jul 14, 2021

Original Issue: get-woke#98

Add support for woke ignore files in subfolders. For example, with git, you can have .gitignore files in subfolders that only apply to that folder and its descendants. Ignore rules from parent folders should also apply additively. This will involve building an ignore list by properly traversing subfolders.

Acceptance Criteria:

  • Implement Woke ignore files can be added to subfolders and only apply to that folder and its descendants.
  • Review comments from maintainer on the PR
  • Apply code changes (some of these might require changing to use git-go package, or make upstream changes to git-go package itself)
  • Ensure PR is merged in source repo
@armanrahman22 armanrahman22 added enhancement New feature or request upstream issue exists Add this label when there is a duplicate issue on the upstream repo labels Jul 14, 2021
@armanrahman22 armanrahman22 self-assigned this Jul 19, 2021
@mkcomer
Copy link

mkcomer commented Oct 13, 2021

PR is still open with comments from the maintainer to resolve: get-woke#117

@mkcomer
Copy link

mkcomer commented Oct 13, 2021

This PR may also solve issue: get-woke#137

Moving this issue to Coding as the PR needs some code changes.

@jeremydelacruz
Copy link

Work item remains blocked in get-woke#117. More investigation and comments to maintainer has been added to that PR thread and is waiting on guidance for how to move forward.

This work item should continue to be tracked primarily/solely here in this GitHub issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request High Priority pending upstream issue exists Add this label when there is a duplicate issue on the upstream repo
Projects
None yet
Development

No branches or pull requests

3 participants