Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially change the value for the "query" key into a string rather than a list #6

Open
nicholsn opened this issue Oct 31, 2015 · 4 comments

Comments

@nicholsn
Copy link
Contributor

Maybe there is a good reason for storing the query as a list rather than a string. If not, I propose it be stored as a string so it can be executed directly w/o preprocessing.

@vsoch
Copy link
Member

vsoch commented Oct 31, 2015

I don't understand - with the current standard it is stored as a list... see here!

https://github.com/incf-nidash/nidm-query/blob/master/results/b73b423e-0660-42a1-a7d3-48e300f44872.json#L7

You mean there is good reason to store as a string rather than a list?

@vsoch
Copy link
Member

vsoch commented Oct 31, 2015

The benefit of a list is that it ensures readability when you look at the structure from within python, or just as a file. If we were to scrunch it into a string with newline characters, that would not be possible. I think there is always going to be some pre-processing given that the query is in a json file period, and the vision of nidm-api is that we can serve it somewhere and the query is executed from a URL anyway.

@vsoch
Copy link
Member

vsoch commented Oct 31, 2015

@nicholsn don't forget about the nidmviewer sparql query! I am hoping to finalize the integration of the viewer into NeuroVault, and that is the last missing component. Then we can pretty much take over the world:

image

@nicholsn
Copy link
Contributor Author

nicholsn commented Nov 2, 2015

Do you have a way of formatting queries? I was hoping to preserve the formatting for readability, but can see where that could be a mess with new line chars. It would be nice if there was a way to pretty print sparql.. might be possible though rdflib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants