Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bidsmri2nidm - Conversion of Author lists #397

Open
ckindermann opened this issue Apr 22, 2024 · 2 comments
Open

bidsmri2nidm - Conversion of Author lists #397

ckindermann opened this issue Apr 22, 2024 · 2 comments

Comments

@ckindermann
Copy link

Hi,

A list of distinct authors in BIDS gets converted into a single string in NIDM.

For example, the following dataset_description.json

{ 
    "Name": "Example Dataset Name",
    "BIDSVersion": "1.9.0",
    "License": "CC0",
    "Authors": [
        "Jane Doe",
        "John Doe",
        "Adam Smith"
    ]
}

gets converted into the following RDF (serialized in Turtle - prefixes omitted):

niiri:id123 a bids:Dataset,
       prov:Collection,
       prov:Entity ;
    bids:BIDSVersion "1.9.0"^^xsd:string ;
    dcterms:license "CC0"^^xsd:string ;
    dcat:author "Jane DoeJohn DoeAdam Smith"^^xsd:string .

I would have expected the following:

niiri:id123 a bids:Dataset,
       prov:Collection,
       prov:Entity ;
    bids:BIDSVersion "1.9.0"^^xsd:string ;
    dcterms:license "CC0"^^xsd:string ;
    dcat:author "Jane Doe"^^xsd:string, 
                "John Doe"^^xsd:string,
                "Adam Smith"^^xsd:string .
@yarikoptic
Copy link
Member

sounds like a bug indeed... if you get a chance/time to dig it to fix it and send PR -- would be appreciated. Should be an easy fix I hope

@ckindermann
Copy link
Author

I suspect the bug is introduced here. The join seems problematic in general, but perhaps I'm overlooking something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants