Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News: some fixes #11

Closed
wants to merge 2 commits into from
Closed

News: some fixes #11

wants to merge 2 commits into from

Conversation

florisvdh
Copy link
Member

No description provided.

hansvancalster and others added 2 commits August 30, 2023 15:02
I believe all comments have been addressed. Thanks @florisvdh  and @ThierryO  for reviewing! And thanks @florisvdh for contributing new functions!
@florisvdh
Copy link
Member Author

florisvdh commented Aug 30, 2023

@hansvancalster is main branch restricted to released versions, or do dev version x.y.z.9000 also go in there? In the former case, above commit is to be integrated in the current merge commit on main (I can do so if I have the rights to force-push to main). In the latter case (dev number on main), I can just update the version number here and refactor this PR.

@hansvancalster
Copy link
Collaborator

@hansvancalster is main branch restricted to released versions, or do dev version x.y.z.9000 also go in there? In the former case, above commit is to be integrated in the current merge commit on main (I can do so if I have the rights to force-push to main). In the latter case (dev number on main), I can just update the version number here and refactor this PR.

Yes, the main branch is restricted to released versions. Since the updates in this PR should belong to today's release, a force-push is the best option I guess. I will check if you have the rights to do so. (Alternative is postpone this update and merge it with a branch destined for the next release - I haven't made one yet)

@hansvancalster
Copy link
Collaborator

@florisvdh you have admin rights

@florisvdh
Copy link
Member Author

OK, it's been added in main. Not sure whether the site will rebuild (although I think it should), maybe it only builds on a new release.

@florisvdh florisvdh closed this Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants