Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add population UI #72

Merged
merged 1 commit into from
Feb 21, 2020
Merged

add population UI #72

merged 1 commit into from
Feb 21, 2020

Conversation

anitanh
Copy link
Contributor

@anitanh anitanh commented Feb 20, 2020

partly fix #57 only the UI

In this PR, the function to fetch population data from database is still not use (commented). I will uncomment those lines when the table is ready.

Peek 2020-02-20 17-59

@lucernae
Copy link
Contributor

Thanks @Ann26 .
Table name conventions are correct.
As for the columns, based on #57
We will have population, females, males, unemployed, elderly.
However since this columns are not disjoint by nature,
If you sum all of it it, it might adds up to more than the total population, so for population tab, let's just disable all total sum counting if it is possible.
We will then think on how's best to show the data.

@anitanh
Copy link
Contributor Author

anitanh commented Feb 21, 2020

oh okay @lucernae or maybe can we have the number of the total population in the summary? so we don't need to sum

@lucernae
Copy link
Contributor

I'm going to merge this to check the UI with local db instance

@lucernae lucernae merged commit 4aaac36 into inasafe:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding population to the summary tables
2 participants