Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UpdateFingerprintRelationsUpgradeWizard is broken #64

Open
Mabahe opened this issue Nov 13, 2024 · 1 comment · May be fixed by #65
Open

UpdateFingerprintRelationsUpgradeWizard is broken #64

Mabahe opened this issue Nov 13, 2024 · 1 comment · May be fixed by #65

Comments

@Mabahe
Copy link

Mabahe commented Nov 13, 2024

Two issues:

  1. visitor WHERE is missing
    https://github.com/in2code-de/lux/blob/develop/Classes/Update/UpdateFingerprintRelationsUpgradeWizard.php#L50

  2. In a second run (first was not finished) also visitors get selected where fingerprints colums already contains the count, which scrambles the relations.
    https://github.com/in2code-de/lux/blob/develop/Classes/Update/UpdateFingerprintRelationsUpgradeWizard.php#L62

PR follows
@einpraegsam
Copy link
Contributor

Thx for digging into this issue

Mabahe added a commit to Mabahe/typo3-extension-lux that referenced this issue Nov 14, 2024
@Mabahe
[BUGFIX] UpdateFingerprintRelationsUpgradeWizard
e507d40 
* Change fingerprints count only for single visitor
* select only visitors that not already have a fingerprint
  relation in visitor column. Prevents broken relations
  on a second run, if the first was not finished.

Resolves: in2code-de#64
@Mabahe Mabahe linked a pull request Nov 14, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX] UpdateFingerprintRelationsUpgradeWizard Mabahe/typo3-extension-lux
2 participants
@einpraegsam @Mabahe