-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Linked Verifiable Presentations #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 9, 2024
nanderstabel
force-pushed
the
feat/linked-vp
branch
from
November 25, 2024 13:02
b921301
to
ec50ddb
Compare
daniel-mader
approved these changes
Nov 25, 2024
nanderstabel
changed the title
feat: add support for linked verifiable presentations
feat: add support for Linked Verifiable Presentations
Nov 25, 2024
🎉 This PR is included in version 1.0.0-beta.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds (dynamic) Linked Verifiable Presentation support to UniCore
Links to any relevant issues
How the change has been tested
The updated Postman Collection can be used to test this added functionality manually:
make sure did web and domain linkage are enabled (and preferred) in the config (or .env) file:
Since local IP addresses are not valid identifiers for the DID Web method, the easiest way of testing this is by setting the
UNICORE__URL
env var tohttp://localhost:3033
.Also, when spinning up the docker container, make sure to build from source and not use the published image on DockerHub (
compose.yaml
):Issuance:
These first steps ensure that the Issuer, creates the Credential and Offer and sends the Offer to the Holder (via the
target_url
)Holder:
4. execute GET Holder/offers (the collection will automatically set the
RECEIVED_OFFER_ID
env var)5. execute Holder/offers_accept
6. execute GET Holder/credentials (the collection will automatically set the
HOLDER_CREDENTIAL_ID
env var)7. execute POST Holder/presentations
8. execute GET Holder/presentations (the collection will automatically set the
PRESENTATION_ID
env var)Identity:
9. execute Identity/linked-vp
To check whether the linked VP was successfully added, execute .well-known/did:web. You should see that two services are added to the Document, one of them has the LinkedVerifiablePresentation type. The serviceEndpoint should be pointing at the endpoint where the Linked VP is hosted
This branch can also be validated against this branch in UniMe: impierce/identity-wallet#256 (or against
ci/release-0.7
)Since
UNICORE__URL
is set tohttp://localhost:3033
, you can only test this against UniMe running on desktop.After 'scanning' the Credential Offer UniMe should prompt something like this:
Definition of Done checklist
Add an
x
to the boxes that are relevant to your changes.