Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wakelock Issue on IOS 13 #44

Open
danrossi opened this issue Jul 1, 2020 · 9 comments
Open

Wakelock Issue on IOS 13 #44

danrossi opened this issue Jul 1, 2020 · 9 comments

Comments

@danrossi
Copy link

danrossi commented Jul 1, 2020

I believe there is a wakelock issue for IOS 13 and it requires this NoSleep forked project which has the fixes.

https://github.com/Domratchev/NoSleep.js

@danrossi
Copy link
Author

danrossi commented Jul 6, 2020

I believe the change to this branch doesn't work. Wakelock broken in IOS 13.

@jsantell
Copy link
Contributor

jsantell commented Jul 6, 2020

Wakelock on iOS has always been a challenging pile of hacks. I don't have access to an iOS 13 device at the moment, hopefully there's some possible solution

@danrossi
Copy link
Author

danrossi commented Jul 7, 2020

Please hold I have a client testing the updated branch, they claim the live demo version is working not sure which build that is. Ive been between 3 different forks and the fork changes might be an issue. The version built into vr cardboard display is def broken. IOS 13 has broken many things indeed. I may close

@danrossi
Copy link
Author

danrossi commented Jul 7, 2020

master branch is working with IOS 13. The forks I tried and manually merged cause issues. Updated the github dependency in the cardboard display project.

@danrossi danrossi closed this as completed Jul 7, 2020
@jsantell
Copy link
Contributor

jsantell commented Jul 7, 2020

What version of nosleep.js did you pin/update to that worked for you?

@danrossi
Copy link
Author

danrossi commented Jul 7, 2020

The github master branch. I've got it in my fork which I had to also fix IOS 13 detection properly.

https://github.com/danrossi/cardboard-vr-display

@jsantell
Copy link
Contributor

jsantell commented Jul 7, 2020

@danrossi thanks for the update; looks like iOS 13 was fixed for the 0.11.0 release, we can try pinning cardboard-vr-display to that upstream (should be currently the same as pinning to the master branch)

@danrossi
Copy link
Author

danrossi commented Jul 8, 2020

The branch on its own does work. They are claiming its still going to sleep within vr display. Have to debug further.

@danrossi
Copy link
Author

danrossi commented Jul 8, 2020

I think I found the problem. If I make a pull request it might be complicated as it may be out of sync. There is still IOS 13 detection issues. See this ?

export const isIOS = (function() {
  var isIOS = ((/iP(hone|ad)/i).test(navigator.platform) || (navigator.platform === 'MacIntel' && navigator.maxTouchPoints > 1));
  return function() {
    return isIOS;
  };
})();

isMobile I don't think detects IOS 13

if (USE_WAKELOCK && Util.isMobile()) {
    this.wakelock_ = new NoSleep();
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants