Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any runtime alternatives to DPDB? #26

Open
devasur opened this issue Jun 28, 2018 · 1 comment
Open

Any runtime alternatives to DPDB? #26

devasur opened this issue Jun 28, 2018 · 1 comment

Comments

@devasur
Copy link

devasur commented Jun 28, 2018

It will be great if the split screen could be constructed without a DPDB entry. If we could discuss constraints may be we could at least come up with a better approximation for a runtime defaukt when a device could not be matched.

@jsantell
Copy link
Contributor

It does use defaults if no entry is found:

// Fallback Android device (based on Nexus 5 measurements) for use when
// we can't recognize an Android device.
var DEFAULT_ANDROID = new Device({
widthMeters: 0.110,
heightMeters: 0.062,
bevelMeters: 0.004
});
// Fallback iOS device (based on iPhone6) for use when
// we can't recognize an Android device.
var DEFAULT_IOS = new Device({
widthMeters: 0.1038,
heightMeters: 0.0584,
bevelMeters: 0.004
});

Are you seeing a failure when no device data is found?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants