-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error with unique case.weights and quantile regression #564
Comments
That's expected behavior. The However, thinking about that, shouldn't we make this a warning instead of an error and just assign |
Ah, I see. Yes, a warning + BTW, I just installed the dev version and I'm blown away by the speed improvements for quantile regression! |
First of all, thank you @mnwright for this package. Its performance is especially noticeable for quantile regression. Except if I missed something, the issue is still the same. NA's would help a great deal, as suggested. In particular, it can be very tricky to find an appropriate number of trees and, even then, there is no guarantee that it would work. In my case 370 000 observations, with 320 000 having same weight 1 and the rest having weights ranging from 2 to 874. |
Here's an issue I can't quite narrow down. It seems that
ranger
fails when all three of these are fulfilled: (1) there are uniquecase.weights
, (2)quantreg = TRUE
, andkeep.inbag = TRUE
:It runs with
mtcars$cyl[1:2] = 99
.However,
ranger
has no problems with uniquecase.weights
here:I'm experiencing the former error in a number of analyses I'm currently running. Thanks for an awesome package!
The text was updated successfully, but these errors were encountered: