Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad coding #14

Open
keithbriggs opened this issue Jun 15, 2020 · 0 comments
Open

bad coding #14

keithbriggs opened this issue Jun 15, 2020 · 0 comments

Comments

@keithbriggs
Copy link

return math.sqrt((self.x-BS.x)**2+(self.y-BS.y)**2)

should be

return math.hypot(self.x-BS.x,self.y-BS.y)

Also:

if BS.omnidirectionalAntenna == True:

should be

 if BS.omnidirectionalAntenna:

Also:

    if BS.angle > ue_angle:
        alpha_diff = BS.angle - ue_angle
    else:
        alpha_diff = ue_angle - BS.angle:

should be

        alpha_diff = abs(BS.angle - ue_angle)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant