About formatting source codes

[cool0707]

I'm thinking of using VS code's "Beautify" plugin to format the code, since custom_ofmeet.js etc. doesn't have consistent formatting rules.
I'm thinking of adding a ".jsbeautifyrc" file to the project root, but we need to decide whether to use the K&R style or the Allman style.
Most of custom_ofmeet.js is written in the Allman style, but the mainstream JavaScript nowadays is K&R style.

[gjaekel]

Personally, I hate the Allman style. I bend myself as expected in a project. I think it's because the first serious programming language I was educated in was Pascal with it's block terminating keyword syntax.

👍 for Allman!

I also tend to violate K&R for "one-liners" like if (....) { some simple things } as found in the ...settings.java

[deleolajide]

I am not fussed about any style. I started with a K&R-ish style from my earliest days of coding Fortran on a mainframe. Somewhere between coding C, Basic and Java I picked up Allman. In general I try and maintain the coding style I find, but resort to Allman when I code something new.

[cool0707]

I'm not particularly fussy about style either, so I tend to follow the default rules of the IDE formatter.
Jitsi Meet and other libraries are also K&R, so I'll use K&R.

By the way, "Beautify" confuses of variable in custom_ofmeet.js with the of keyword of for...of statement and adds a space before and after it.
For this reason, I'm going to rename it to ofm, etc.

[gjaekel]

For this reason, I'm going to rename it to ofm, etc.

There's the variable named APP; what's about to use OF (or OFM)?

[cool0707]

It is used in this area.
I don't particularly feel the need to add recording etc. as properties of of, but I think @deleolajide is using it with some intention.

openfire-pade-plugin/src/webapp/custom_ofmeet.js

Line 1 in a817859

var ofmeet = (function(of)

openfire-pade-plugin/src/webapp/custom_ofmeet.js

Lines 159 to 187 in a817859

	window.addEventListener("beforeunload", function(event)
	{
	console.debug("custom_ofmeet.js beforeunload");
	if (APP.connection && !config.webinar)
	{
	if (dbnames.length > 0 || of.recording)
	{
	event.preventDefault();
	event.returnValue = '';
	}
	if (of.recording) stopRecorder();
	dbnames.forEach(function(dbname)
	{
	const deleteRequest = indexedDB.deleteDatabase(dbname)
	deleteRequest.onsuccess = function(event) {
	console.debug("custom_ofmeet.js me database deleted successfully", dbname);
	};
	});
	if (dbnames.length > 0 || of.recording)
	{
	return event.returnValue;
	}
	}
	});

[deleolajide]

There's the variable named APP; what's about to use OF (or OFM)?

APP has global scope. thatis why all caps is used. OF or OFM would be wrong because of.recording has scope only within the ofmeet module. To use it outside of the module, you would use ofmeet.recording.

The need to access ofmeet.recording externally is no more needed. In the past when it was part of the Pade chrome extension client, it was used in the background page on the window close event handler to cleanup an active recording. Now this is handled in the ofmeet module itself.

In any case, I think we should apply this later this week on next week after I release 1.3.3