Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable jitsi-meet's screen sharing feature in Ofmeet #74

Open
Yyuzu opened this issue Jun 26, 2018 · 17 comments
Open

Enable jitsi-meet's screen sharing feature in Ofmeet #74

Yyuzu opened this issue Jun 26, 2018 · 17 comments

Comments

@Yyuzu
Copy link

Yyuzu commented Jun 26, 2018

Hello,

I've just updated Ofmeet and focus to 0.9.4, as the changelog seemed to indicate screen sharing had received fixes:

Replaced old desktop sharing config options with the new variants

Now whenever I connect to ofmeet, I have the new layout (much closer to upstream jitsi meet), but I the screen share icon is missing (should be left to the Raise hand icon).

I checked in the admin panel and Start / Stop screen sharing option is properly ticked in Meetings, User Interface section.

What could I have missed here ?
Is there an option somewhere to enable screen sharing feature ?

Kind regards.

@guusdk
Copy link
Member

guusdk commented Jun 26, 2018

Screen sharing features are unlikely to work. Likely, custom browser extensions are needed, although I didn't test this at all. What 0.9.4 did was remove and replace some configuration options that were no longer applicable, but the replacement options are currently not used (their default values are mostly empty).

@guusdk guusdk closed this as completed Jun 26, 2018
@Yyuzu
Copy link
Author

Yyuzu commented Jun 26, 2018

Hi @guusdk , thank you for your reply.

Do you know if adding screen sharing features from upstream is planned somehow ? Screen sharing works out of the box with no extension on jitsi meet demo, using Firefox 60.0.2 at least.

@guusdk
Copy link
Member

guusdk commented Jun 26, 2018

I must admit that I've simply not had the time to look into this myself. From what I seem to recall, there's an automatically installed extension that's tied to the domain that runs the webservice. I might be completely wrong though.

Today, I simply lack the time to look into this further. By all means, do contribute if you get this working properly.

@Yyuzu
Copy link
Author

Yyuzu commented Jun 26, 2018

I can assure you there is no extension required on a modern Firefox, but I do understand you're lacking the resources to enable it on ofmeet.

I'm not familiar at all with jitsi so I won't be the ideal candidate for this task, maybe someone interested will pass by ? I'll edit the issue title, could you maybe leave it opened so it's visible to contributors ?

Thank you very much.

@guusdk guusdk reopened this Jun 26, 2018
@Yyuzu Yyuzu changed the title Screen sharing icon missing / not displayed [Help wanted] Enable jitsi-meet's screen sharing feature in Ofmeet Jun 26, 2018
@Yyuzu
Copy link
Author

Yyuzu commented Jun 26, 2018

Thanks, keep up the good work :)

@speedy01
Copy link

speedy01 commented Jun 27, 2018

you should be able to manually add org.jitsi.videobridge.ofmeet.desktop.sharing.firefox.enabled to your system properties with a value of true
this should enable screensharing with firefox.
you might have to also add org.jitsi.videobridge.ofmeet.desktop.sharing.firefox.max.ver.ext.required and set it to 41 (i think 42 doesn't require an extension)

I don't think entire screen sharing is working, but I think this is a firefox issue, not a jitsi one....as I recall seeing it popup somewhere

@Yyuzu
Copy link
Author

Yyuzu commented Jun 27, 2018

Hi @speedy01 , thank you very much for your help !

I've added the variables for Firefox and Chrome (unsure about the version):

org.jitsi.videobridge.ofmeet.desktop.sharing.chrome.enabled true
org.jitsi.videobridge.ofmeet.desktop.sharing.firefox.enabled true
org.jitsi.videobridge.ofmeet.desktop.sharing.firefox.max.ver.ext.required 41
org.jitsi.videobridge.ofmeet.min.chrome.ext.ver 59

Using Chromium 66 I can't see the share icon, but the variable for Chrome version is named differently than the others, could it explain this issue ?

Using Firefox, the icon is available and I can share a specific window, the video stream of the shared window appear in my thumbnail, but other people can't see it. Is there maybe another option, or something to check ?

Edit: someone seem to have this problem with upstream jitsi:
jitsi/jitsi-meet#2892

@guusdk guusdk changed the title [Help wanted] Enable jitsi-meet's screen sharing feature in Ofmeet Enable jitsi-meet's screen sharing feature in Ofmeet Jun 27, 2018
@speedy01
Copy link

Chrome is more complicated. you'll have to build a plugin and do some other things, and then set a property with the extension id. the property is org.jitsi.videobridge.ofmeet.chrome.extension.id
I think it might be best to move this conversation to the forums since this isn't really any issue with ofmeet

@deleolajide
Copy link
Member

I am able to screen share from ofmeet 0.9.4 on Firefox 61.0 to Pade on Chrome 67.0 and the other way round as well. From Pade on Chrome to ofmeet on Firefox.

For completeness, I added a third firefox user and was able to share the screen with the other firefox and Pade user.

@Yyuzu
Copy link
Author

Yyuzu commented Jul 4, 2018

Hi @deleolajide , how did you manage that ? On my side, using Firefox 60 I can start sharing and the my thumbnail stream shows the shared window, but other participants can't see a thing. And it's the same for them, they can share but I can't see the stream.

Thanks @speedy01 , I think I'll pass on chromium/chrome for now, having it work with Firefox would be enough for us at least.

@deleolajide
Copy link
Member

how did you manage that ?

When I started the test with just 2 Firefox users, it did not show. I assumed that the default p2p mode was causing that and then I added the third chrome user and the screen share appeared for both the firefox and chrome user.

@Yyuzu
Copy link
Author

Yyuzu commented Jul 4, 2018

I see, so I'd have to setup a chrome user with Pade to force ofmeet/jitsi switching to another streaming mode, right ? Or a simple chrome user without extension could do the trick ?

@deleolajide
Copy link
Member

Or a simple chrome user without extension could do the trick ?

If the issue is the p2p mode, then yes. It will force bridging. I think there is a bug with screen sharing stream switching and P2P mode.

@speedy01
Copy link

speedy01 commented Jul 5, 2018

another option may be to tell ofmeet to disable p2p and always use the bridge. I think there is a jitsi meet setting that that in the config..

@Yyuzu
Copy link
Author

Yyuzu commented Jul 18, 2018

It seems indeed having one chrome user when sharing is started helps make it available for everyone. Although, if there are only Firefox users, even 3 of them (which is quite odd), the shared stream is not showing up except in the thumbnail of the emitter.

I've seen this option on upstream jitsi meet, in config.js:

var config = {
    p2p: {
        // Enables peer to peer mode. When enabled the system will try to
        // establish a direct connection when there are exactly 2 participants
        // in the room. If that succeeds the conference will stop sending data
        // through the JVB and use the peer to peer connection instead. When a
        // 3rd participant joins the conference will be moved back to the JVB
        // connection.
        enabled: true,
[...]
}

OfMeet's using jitsi.getP2pEnabled() method, which calls:
return JiveGlobals.getBooleanProperty( "ofmeet.p2p.enabled", true );
So I just have to add a global property ofmeet.p2p.enabled set to false ?

Kind regards,

@Yyuzu
Copy link
Author

Yyuzu commented Jul 18, 2018

Adding this parameter made it work with 2 firefox users, but only the first time someone share something. Then no sharing worked even after destroying the channel / rejoining.

@enjine
Copy link

enjine commented Apr 23, 2020

i added the following config entries per @Kyoshiro-san's post earlier and it worked on Chrome v80.0.3987.163 and Firefox 75.0.

org.jitsi.videobridge.ofmeet.desktop.sharing.chrome.enabled true
org.jitsi.videobridge.ofmeet.desktop.sharing.firefox.enabled true
org.jitsi.videobridge.ofmeet.desktop.sharing.firefox.max.ver.ext.required 41
org.jitsi.videobridge.ofmeet.min.chrome.ext.ver 59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants