Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instant Stream Resumption implementation #92

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
+1,277 −83
Open

Instant Stream Resumption implementation #92

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6cb89e7
Instant Stream Resumption implementation
ramabit Oct 5, 2016
f5e3416
fix hmac exceptions catch
ramabit Oct 11, 2016
fc8fe24
improve hmac digest and add test
ramabit Oct 11, 2016
f1e9311
merge update
ramabit Oct 31, 2016
a618b5a
merge update
ramabit Nov 14, 2016
681d56b
merge update
ramabit Dec 6, 2016
a21a884
merge update
ramabit Dec 27, 2016
662f1c3
merge update
ramabit Jan 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions smack-tcp/src/main/java/org/jivesoftware/smack/isr/HMAC.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,8 @@ public static String hmacDigest(String msg, String keyString, String algo) {
hash.append(hex);
}
digest = hash.toString();
} catch (UnsupportedEncodingException e) {
} catch (InvalidKeyException e) {
} catch (NoSuchAlgorithmException e) {
} catch (UnsupportedEncodingException | InvalidKeyException | NoSuchAlgorithmException e) {
throw new IllegalStateException("HMAC digest couldn't be done correctly.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the catched Exception to the ISE, so that it doesn't get lost:

throw new IllegalStateException("HMAC digest couldn't be done correctly.", e);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Flowdalic done

}
return digest;
}
Expand Down