Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contracts use require statements instead of custom errors #9

Open
idrisssystem opened this issue Aug 19, 2022 · 2 comments
Open

Contracts use require statements instead of custom errors #9

idrisssystem opened this issue Aug 19, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@idrisssystem
Copy link
Member

Is your feature request related to a problem? Please describe.
Some of our contracts still use require, instead of custom error messages. As pointed out by @DevABDee in #7, this can lead to higher gas fees than necessary. More info can be found here.

Describe the solution you'd like
Clean our contracts by introducing custom error messages wherever it is beneficial. Please provide relevant screenshots on performed tests and compare before <--> after gas values.

Additional context
For questions, please ask here or join the discussion on Discord.

@idrisssystem idrisssystem added enhancement New feature or request good first issue Good for newcomers labels Aug 19, 2022
@TradMod
Copy link
Contributor

TradMod commented Aug 19, 2022

Really Glad to see this =D
Let's try to make every freakin contract gas optimized until the ETH Surge 💯

@TradMod TradMod mentioned this issue Sep 6, 2022
@TradMod
Copy link
Contributor

TradMod commented Sep 6, 2022

Payments.sol Fixed. PR #16 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants