Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

应该把DOMAttributes替换为SVGAttributes #9

Open
guofei0723 opened this issue Jan 27, 2021 · 1 comment
Open

应该把DOMAttributes替换为SVGAttributes #9

guofei0723 opened this issue Jan 27, 2021 · 1 comment

Comments

@guofei0723
Copy link

在图标组件与index.tsx中,接口Props都是继承自DOMAttributes,如下

interface Props extends DOMAttributes<SVGElement>

这样实际上没有继承到svg元素应有的属性,如width、height等,需要改成

interface Props extends SVGAttributes<SVGElement>
@fwh1990
Copy link
Member

fwh1990 commented Jan 27, 2021

感谢指正,已经处理

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants