Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop propagation for view events #413

Open
dpatti opened this issue Jul 6, 2016 · 0 comments
Open

Stop propagation for view events #413

dpatti opened this issue Jul 6, 2016 · 0 comments

Comments

@dpatti
Copy link

dpatti commented Jul 6, 2016

In 7a3efa2, stopPropagation was removed because users couldn't intercept key events on their text areas. I think that was a worthwhile change; however, stopPropagation was also removed on the click handler on the view. I want to say that event (and any view event) is something users will never depend on considering it is DOM that they did not initialize themselves. By not stopping it, you have click events bubbling up and causing potential unintended side-effects.

I'm happy to create a pull request if you think this is the correct behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant