Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing rebuild for the label-trigger scenario? #8

Open
icecrime opened this issue Nov 7, 2016 · 1 comment
Open

Optimizing rebuild for the label-trigger scenario? #8

icecrime opened this issue Nov 7, 2016 · 1 comment

Comments

@icecrime
Copy link
Owner

icecrime commented Nov 7, 2016

The rebuild operation currently supports a single trigger label. If you want to configure multiple label to configuration associations, you need to repeat yourself in the configuration:

- repositories:     [ "docker/docker" ]
  triggers:
      pull_request: [ labeled ]
  operations:
      - type:       rebuild
        settings: {
            configurations: [ arm ],
            label:          "rebuild/arm",
        }
      - type:       rebuild
        settings: {
            configurations: [ experimental ],
            label:          "rebuild/experimental",
        }

Question: is that a good approach, or should rebuild made aware of a label to configuration mapping?

@icecrime
Copy link
Owner Author

icecrime commented Nov 8, 2016

Also, this would prevent the following torrent of logs:

time="2016-11-08T16:33:03-05:00" level=debug msg="received GitHub event" action=labeled event="pull_request" number=27745 repository="docker/docker" 
time="2016-11-08T16:33:03-05:00" level=info msg="running operation" operation=rebuild repository="docker/docker" 
time="2016-11-08T16:33:04-05:00" level=debug msg="rejecting pull request without label \"rebuild/arm\"" 
time="2016-11-08T16:33:04-05:00" level=info msg="running operation" operation=rebuild repository="docker/docker" 
time="2016-11-08T16:33:04-05:00" level=debug msg="rejecting pull request without label \"rebuild/experimental\"" 
time="2016-11-08T16:33:04-05:00" level=info msg="running operation" operation=rebuild repository="docker/docker" 
time="2016-11-08T16:33:04-05:00" level=debug msg="rejecting pull request without label \"rebuild/janky\"" 
time="2016-11-08T16:33:04-05:00" level=info msg="running operation" operation=rebuild repository="docker/docker" 
time="2016-11-08T16:33:04-05:00" level=debug msg="rejecting pull request without label \"rebuild/userns\"" 
time="2016-11-08T16:33:04-05:00" level=info msg="running operation" operation=rebuild repository="docker/docker" 
time="2016-11-08T16:33:04-05:00" level=debug msg="rejecting pull request without label \"rebuild/vendor\"" 
time="2016-11-08T16:33:04-05:00" level=info msg="running operation" operation=rebuild repository="docker/docker" 
time="2016-11-08T16:33:04-05:00" level=debug msg="rejecting pull request without label \"rebuild/win2lin\"" 
time="2016-11-08T16:33:04-05:00" level=info msg="running operation" operation=rebuild repository="docker/docker" 
time="2016-11-08T16:33:04-05:00" level=debug msg="rejecting pull request without label \"rebuild/windowsRS1\"" 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant