-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved SamplingVQE algorithm implementation #13
Comments
A questions that I still have (should this be an issue): what is the best structure for the implementation of different encoding schemes? In result, this is starting to look similar to the VQHMapper class, that needs to call a specific method that was implemented for a specific sonification strategy. but the method it sees and calls is from a parent class called Sketching a solution: In (soon-to-be-released) v0.3.0, the |
Discussion with @schwaeti :
A two-step process for the integration:
|
For the Algorithm class:
|
Integrating a re-implementation of the
SamplingVQE
class, together with theBasisProtocol
andAmplitudeProtocol
made on commit db2b996This would also lead to an improved structure of the VQHAlgorithm class, allowing for modularity. A few considerations from @schwaeti during email exchanges:
evalutate
function specific to that problem.QuantumHardwareInterface
class would lead to each provider having their ownSampler
classTasks:
qubo_to_ising
IsingProblem
VQEAlgorithm
and replace it with the new implementations, preserving functionality (vqe/vqe_algorithm.py)The text was updated successfully, but these errors were encountered: