Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ForecastDFDataset constructor mismatch in Hugging Face Blog, Tutorial and Codebase. #224

Open
arc-arnob opened this issue Dec 10, 2024 · 2 comments

Comments

@arc-arnob
Copy link

In the tutorial and hugging face blog for PatchTST, we have:

ForecastDFDataset(
    time_series_preprocessor.preprocess(train_data),
    id_columns=id_columns,
    input_columns=forecast_columns,
    output_columns=forecast_columns,
    context_length=context_length,
    prediction_length=forecast_horizon,
)

But there are no input_columns and output_columns in the class construction definition.

Am I missing something here? Does this also cause downstream issues?

@arc-arnob
Copy link
Author

I suppose they got replaced by observable_columns and target_columns but would like to see if the author agrees as well. Cheers 😄

@wgifford
Copy link
Collaborator

wgifford commented Dec 10, 2024

@arc-arnob Thanks for your interest in granite-tsfm. I will try to update that blog post to reflect changes in the API. For the example in the blog, I believe we need to replace input/output with just a single parameter: target_columns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants