Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: installation may fail on Windows for Impala backend due to aggressive kerberos support in setup.py #2892

Closed
ZeroCool2u opened this issue Aug 4, 2021 · 1 comment
Labels
dependencies Issues or PRs related to dependencies

Comments

@ZeroCool2u
Copy link
Contributor

This is a subtle bug that was introduced by a previous PR of mine here, which was meant to simplify kerberos dependencies.

However, some updates to the Impyla library have caused this bug to become a bigger problem for folks trying to install Ibis with the Impala backend on Windows.

The source of the issue is that when an Impyla install is requested with kerberos support, pip install impyla[kerberos], Impyla now attempts to install the kerberos library here.

On *nix based platforms this is fine, but on Windows, this is a problem. The kerberos library does not seem to support Windows and based on my research the typical pattern of library authors is using winkerberos or kerberos based on the platform detected by Python in the libraries setup.py.

I think this could easily be resolved by modifying our setup.py the same way I've suggested in this Impyla issue.

@cpcloud cpcloud added the dependencies Issues or PRs related to dependencies label Dec 28, 2021
@cpcloud cpcloud changed the title BUG: Installation may fail on Windows for Impala backend due to aggressive kerberos support in setup.py bug: installation may fail on Windows for Impala backend due to aggressive kerberos support in setup.py Dec 28, 2021
@cpcloud
Copy link
Member

cpcloud commented Dec 28, 2021

I think this needs to be solved in impyla and not in ibis. The workaround is a pretty big maintenance headache.

@cpcloud cpcloud closed this as completed Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issues or PRs related to dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants