From 6a06341edfe16e68efb25cda7f7c79a0113edd87 Mon Sep 17 00:00:00 2001 From: Leonard Ehrenfried Date: Mon, 16 Sep 2024 11:11:57 +0200 Subject: [PATCH] Convert line comments to Javadoc --- .../system/OutsideSearchWindowFilter.java | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/main/java/org/opentripplanner/routing/algorithm/filterchain/filters/system/OutsideSearchWindowFilter.java b/src/main/java/org/opentripplanner/routing/algorithm/filterchain/filters/system/OutsideSearchWindowFilter.java index ca8e6586e06..cbd47080c15 100644 --- a/src/main/java/org/opentripplanner/routing/algorithm/filterchain/filters/system/OutsideSearchWindowFilter.java +++ b/src/main/java/org/opentripplanner/routing/algorithm/filterchain/filters/system/OutsideSearchWindowFilter.java @@ -14,6 +14,15 @@ *

* Itineraries matching the start(earliest-departure-time) are included and itineraries matching * the end(latest-departure-time) are not. The filter is {@code [inclusive, exclusive]}. + *

+ * For arrive by searches, the street/flex-only results are treated differently: + * Arrive-by transit result are filtered by their departure time and whether they don't depart + * after the end of the computed search window which is dependent on the heuristic's minimum + * transit time. + * This doesn't work because street/flex-only can be shorter than the transit ones and often + * end up time-shifted right up to the arrive by time. + *

+ * Further reading. */ public class OutsideSearchWindowFilter implements RemoveItineraryFlagger { @@ -42,13 +51,6 @@ public String name() { public Predicate shouldBeFlaggedForRemoval() { return it -> { var startTime = it.startTime().toInstant(); - // for arrive by searches, the street/flex-only results are treated differently: - // arrive-by transit result are filtered by their departure time and whether they don't depart - // after the end of the computed search window which is dependent on the heuristic's minimum - // transit time. - // this doesn't work because street/flex-only can be shorter than the transit ones and often - // end up time-shifted right up to the arrive by time. - // further reading: https://github.com/opentripplanner/OpenTripPlanner/issues/6046 if (it.isOnStreetAndFlexOnly() && isArriveBy) { return startTime.isBefore(earliestDepartureTime); } else {