From 8f5226732d4fef6c3763940a2d475b76c4a592a7 Mon Sep 17 00:00:00 2001 From: Dawid Parafinski Date: Thu, 10 Oct 2024 13:18:51 +0200 Subject: [PATCH] fixed minor phpstan issues --- phpstan-baseline.neon | 876 +----------------- .../BinaryBase/BinaryBaseStorage.php | 1 - src/lib/FieldType/Keyword/KeywordStorage.php | 13 - src/lib/FieldType/User/UserStorage.php | 2 - src/lib/Helper/PreviewLocationProvider.php | 7 - .../SimplifiedRequestNormalizer.php | 14 +- .../SiteAccess/Matcher/HostElement.php | 2 +- .../Symfony/SiteAccess/Matcher/HostText.php | 2 +- .../Symfony/SiteAccess/Matcher/Map/Host.php | 2 +- .../Symfony/SiteAccess/Matcher/Map/Port.php | 4 +- .../Symfony/SiteAccess/Matcher/Map/URI.php | 4 +- .../Symfony/SiteAccess/Matcher/URIElement.php | 2 +- .../Symfony/SiteAccess/Matcher/URIText.php | 2 +- src/lib/MVC/Symfony/SiteAccess/Router.php | 2 +- src/lib/Repository/URLWildcardService.php | 4 - .../ContentServiceAuthorizationTest.php | 2 + .../Core/Repository/ContentServiceTest.php | 36 +- .../FieldType/RelationIntegrationTest.php | 12 +- .../FieldType/RelationListIntegrationTest.php | 10 +- ...RelationSearchBaseIntegrationTestTrait.php | 11 +- .../Helper/PreviewLocationProviderTest.php | 7 +- tests/lib/IO/IOServiceTest.php | 2 +- tests/lib/IO/TolerantIOServiceTest.php | 2 +- .../SiteAccess/RouterHostPortURITest.php | 4 +- .../Decorator/ContentServiceDecoratorTest.php | 8 +- 25 files changed, 81 insertions(+), 950 deletions(-) diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon index 2d26781f48..ec7b048352 100644 --- a/phpstan-baseline.neon +++ b/phpstan-baseline.neon @@ -930,26 +930,6 @@ parameters: count: 1 path: src/bundle/Core/DependencyInjection/Configuration/Parser/AbstractFieldTypeParser.php - - - message: "#^Cannot access offset 'name' on array\\|bool\\|float\\|int\\|string\\|null\\.$#" - count: 1 - path: src/bundle/Core/DependencyInjection/Configuration/Parser/Common.php - - - - message: "#^Method Ibexa\\\\Bundle\\\\Core\\\\DependencyInjection\\\\Configuration\\\\Parser\\\\Common\\:\\:addDatabaseConfigSuggestion\\(\\) has no return type specified\\.$#" - count: 1 - path: src/bundle/Core/DependencyInjection/Configuration/Parser/Common.php - - - - message: "#^Method Ibexa\\\\Bundle\\\\Core\\\\DependencyInjection\\\\Configuration\\\\Parser\\\\Common\\:\\:addDatabaseConfigSuggestion\\(\\) has parameter \\$databaseConfig with no value type specified in iterable type array\\.$#" - count: 1 - path: src/bundle/Core/DependencyInjection/Configuration/Parser/Common.php - - - - message: "#^Method Ibexa\\\\Bundle\\\\Core\\\\DependencyInjection\\\\Configuration\\\\Parser\\\\Common\\:\\:addDatabaseConfigSuggestion\\(\\) has parameter \\$sa with no type specified\\.$#" - count: 1 - path: src/bundle/Core/DependencyInjection/Configuration/Parser/Common.php - - message: "#^Method Ibexa\\\\Bundle\\\\Core\\\\DependencyInjection\\\\Configuration\\\\Parser\\\\Common\\:\\:addSemanticConfig\\(\\) has no return type specified\\.$#" count: 1 @@ -970,11 +950,6 @@ parameters: count: 1 path: src/bundle/Core/DependencyInjection/Configuration/Parser/Common.php - - - message: "#^Method Ibexa\\\\Bundle\\\\Core\\\\DependencyInjection\\\\Configuration\\\\Parser\\\\Common\\:\\:setSuggestionCollector\\(\\) has no return type specified\\.$#" - count: 1 - path: src/bundle/Core/DependencyInjection/Configuration/Parser/Common.php - - message: "#^Method Ibexa\\\\Bundle\\\\Core\\\\DependencyInjection\\\\Configuration\\\\Parser\\\\Content\\:\\:addSemanticConfig\\(\\) has no return type specified\\.$#" count: 1 @@ -1065,11 +1040,6 @@ parameters: count: 1 path: src/bundle/Core/DependencyInjection/Configuration/Parser/Image.php - - - message: "#^Method Ibexa\\\\Bundle\\\\Core\\\\DependencyInjection\\\\Configuration\\\\Parser\\\\Image\\:\\:setSuggestionCollector\\(\\) has no return type specified\\.$#" - count: 1 - path: src/bundle/Core/DependencyInjection/Configuration/Parser/Image.php - - message: "#^Method Ibexa\\\\Bundle\\\\Core\\\\DependencyInjection\\\\Configuration\\\\Parser\\\\Languages\\:\\:addSemanticConfig\\(\\) has no return type specified\\.$#" count: 1 @@ -1805,16 +1775,6 @@ parameters: count: 1 path: src/bundle/Core/DependencyInjection/IbexaCoreExtension.php - - - message: "#^Method Ibexa\\\\Bundle\\\\Core\\\\DependencyInjection\\\\IbexaCoreExtension\\:\\:registerImageMagickConfiguration\\(\\) has no return type specified\\.$#" - count: 1 - path: src/bundle/Core/DependencyInjection/IbexaCoreExtension.php - - - - message: "#^Method Ibexa\\\\Bundle\\\\Core\\\\DependencyInjection\\\\IbexaCoreExtension\\:\\:registerImageMagickConfiguration\\(\\) has parameter \\$config with no value type specified in iterable type array\\.$#" - count: 1 - path: src/bundle/Core/DependencyInjection/IbexaCoreExtension.php - - message: "#^Method Ibexa\\\\Bundle\\\\Core\\\\DependencyInjection\\\\IbexaCoreExtension\\:\\:registerOrmConfiguration\\(\\) has parameter \\$config with no value type specified in iterable type array\\.$#" count: 1 @@ -1925,11 +1885,6 @@ parameters: count: 1 path: src/bundle/Core/DependencyInjection/Security/PolicyProvider/PolicyProviderInterface.php - - - message: "#^Method Ibexa\\\\Bundle\\\\Core\\\\DependencyInjection\\\\Security\\\\PolicyProvider\\\\RepositoryPolicyProvider\\:\\:getFiles\\(\\) return type has no value type specified in iterable type array\\.$#" - count: 1 - path: src/bundle/Core/DependencyInjection/Security/PolicyProvider/RepositoryPolicyProvider.php - - message: "#^Method Ibexa\\\\Bundle\\\\Core\\\\DependencyInjection\\\\Security\\\\PolicyProvider\\\\YamlPolicyProvider\\:\\:addPolicies\\(\\) has no return type specified\\.$#" count: 1 @@ -3795,16 +3750,6 @@ parameters: count: 1 path: src/bundle/Core/Routing/DefaultRouter.php - - - message: "#^Parameter \\#1 \\$httpPort of method Symfony\\\\Component\\\\Routing\\\\RequestContext\\:\\:setHttpPort\\(\\) expects int, string given\\.$#" - count: 1 - path: src/bundle/Core/Routing/DefaultRouter.php - - - - message: "#^Parameter \\#1 \\$httpsPort of method Symfony\\\\Component\\\\Routing\\\\RequestContext\\:\\:setHttpsPort\\(\\) expects int, string given\\.$#" - count: 1 - path: src/bundle/Core/Routing/DefaultRouter.php - - message: "#^Property Ibexa\\\\Bundle\\\\Core\\\\Routing\\\\DefaultRouter\\:\\:\\$nonSiteAccessAwareRoutes has no type specified\\.$#" count: 1 @@ -4000,11 +3945,6 @@ parameters: count: 1 path: src/bundle/Core/Variation/VariationHandlerResolver.php - - - message: "#^Method Ibexa\\\\Bundle\\\\Core\\\\View\\\\Manager\\:\\:setSiteAccess\\(\\) has no return type specified\\.$#" - count: 1 - path: src/bundle/Core/View/Manager.php - - message: "#^Method Ibexa\\\\Bundle\\\\Core\\\\View\\\\Provider\\\\Configured\\:\\:setSiteAccess\\(\\) has no return type specified\\.$#" count: 1 @@ -4755,11 +4695,6 @@ parameters: count: 1 path: src/bundle/RepositoryInstaller/IbexaRepositoryInstallerBundle.php - - - message: "#^Method Ibexa\\\\Bundle\\\\RepositoryInstaller\\\\Installer\\\\CoreInstaller\\:\\:createConfiguration\\(\\) has no return type specified\\.$#" - count: 1 - path: src/bundle/RepositoryInstaller/Installer/CoreInstaller.php - - message: "#^Method Ibexa\\\\Bundle\\\\RepositoryInstaller\\\\Installer\\\\CoreInstaller\\:\\:importBinaries\\(\\) has no return type specified\\.$#" count: 1 @@ -4810,11 +4745,6 @@ parameters: count: 1 path: src/bundle/RepositoryInstaller/Installer/DbBasedInstaller.php - - - message: "#^Method Ibexa\\\\Bundle\\\\RepositoryInstaller\\\\Installer\\\\Installer\\:\\:createConfiguration\\(\\) has no return type specified\\.$#" - count: 1 - path: src/bundle/RepositoryInstaller/Installer/Installer.php - - message: "#^Method Ibexa\\\\Bundle\\\\RepositoryInstaller\\\\Installer\\\\Installer\\:\\:importBinaries\\(\\) has no return type specified\\.$#" count: 1 @@ -4880,11 +4810,6 @@ parameters: count: 1 path: src/contracts/Container/Encore/ConfigurationDumper.php - - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\FieldType\\\\BinaryBase\\\\PathGenerator\\:\\:getStoragePathForField\\(\\) has no return type specified\\.$#" - count: 1 - path: src/contracts/FieldType/BinaryBase/PathGenerator.php - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\FieldType\\\\BinaryBase\\\\PathGeneratorInterface\\:\\:getStoragePathForField\\(\\) has no return type specified\\.$#" count: 1 @@ -4900,11 +4825,6 @@ parameters: count: 1 path: src/contracts/FieldType/BinaryBase/RouteAwarePathGenerator.php - - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\FieldType\\\\FieldStorage\\:\\:deleteFieldData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/contracts/FieldType/FieldStorage.php - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\FieldType\\\\FieldStorage\\:\\:deleteFieldData\\(\\) has parameter \\$fieldIds with no value type specified in iterable type array\\.$#" count: 1 @@ -4915,21 +4835,6 @@ parameters: count: 1 path: src/contracts/FieldType/FieldStorage.php - - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\FieldType\\\\FieldStorage\\:\\:getFieldData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/contracts/FieldType/FieldStorage.php - - - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\FieldType\\\\FieldStorage\\:\\:getIndexData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/contracts/FieldType/FieldStorage.php - - - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\FieldType\\\\FieldStorage\\:\\:storeFieldData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/contracts/FieldType/FieldStorage.php - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\FieldType\\\\FieldType\\:\\:applyDefaultSettings\\(\\) has no return type specified\\.$#" count: 1 @@ -4965,11 +4870,6 @@ parameters: count: 1 path: src/contracts/FieldType/FieldType.php - - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\FieldType\\\\GatewayBasedStorage\\:\\:copyLegacyField\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/contracts/FieldType/GatewayBasedStorage.php - - message: "#^Method Ibexa\\\\Contracts\\\\Core\\\\FieldType\\\\Generic\\\\Type\\:\\:fieldSettingsFromHash\\(\\) has parameter \\$fieldSettingsHash with no value type specified in iterable type array\\.$#" count: 1 @@ -7755,11 +7655,6 @@ parameters: count: 1 path: src/lib/Base/Container/Compiler/Storage/ExternalStorageRegistryPass.php - - - message: "#^Parameter \\#1 \\$object_or_class of function is_subclass_of expects object\\|string, array\\|bool\\|float\\|int\\|string\\|null given\\.$#" - count: 1 - path: src/lib/Base/Container/Compiler/Storage/ExternalStorageRegistryPass.php - - message: "#^Method Ibexa\\\\Core\\\\Base\\\\Container\\\\Compiler\\\\Storage\\\\Legacy\\\\RoleLimitationConverterPass\\:\\:process\\(\\) has no return type specified\\.$#" count: 1 @@ -8620,16 +8515,6 @@ parameters: count: 1 path: src/lib/FieldType/BinaryBase/BinaryBaseStorage.php - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\BinaryBase\\\\BinaryBaseStorage\\:\\:copyLegacyField\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/BinaryBase/BinaryBaseStorage.php - - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\BinaryBase\\\\BinaryBaseStorage\\:\\:deleteFieldData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/BinaryBase/BinaryBaseStorage.php - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\BinaryBase\\\\BinaryBaseStorage\\:\\:deleteFieldData\\(\\) has parameter \\$fieldIds with no value type specified in iterable type array\\.$#" count: 1 @@ -8650,36 +8535,16 @@ parameters: count: 1 path: src/lib/FieldType/BinaryBase/BinaryBaseStorage.php - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\BinaryBase\\\\BinaryBaseStorage\\:\\:getFieldData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/BinaryBase/BinaryBaseStorage.php - - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\BinaryBase\\\\BinaryBaseStorage\\:\\:getIndexData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/BinaryBase/BinaryBaseStorage.php - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\BinaryBase\\\\BinaryBaseStorage\\:\\:removeOldFile\\(\\) has no return type specified\\.$#" count: 1 path: src/lib/FieldType/BinaryBase/BinaryBaseStorage.php - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\BinaryBase\\\\BinaryBaseStorage\\:\\:removeOldFile\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/BinaryBase/BinaryBaseStorage.php - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\BinaryBase\\\\BinaryBaseStorage\\:\\:setDownloadUrlGenerator\\(\\) has no return type specified\\.$#" count: 1 path: src/lib/FieldType/BinaryBase/BinaryBaseStorage.php - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\BinaryBase\\\\BinaryBaseStorage\\:\\:storeFieldData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/BinaryBase/BinaryBaseStorage.php - - message: "#^Parameter \\#2 \\$versionNo of method Ibexa\\\\Core\\\\FieldType\\\\BinaryBase\\\\BinaryBaseStorage\\:\\:removeOldFile\\(\\) expects string, int given\\.$#" count: 1 @@ -8695,11 +8560,6 @@ parameters: count: 1 path: src/lib/FieldType/BinaryBase/BinaryBaseStorage.php - - - message: "#^Property Ibexa\\\\Core\\\\FieldType\\\\BinaryBase\\\\BinaryBaseStorage\\:\\:\\$downloadUrlGenerator \\(Ibexa\\\\Contracts\\\\Core\\\\FieldType\\\\BinaryBase\\\\PathGenerator\\) in isset\\(\\) is not nullable\\.$#" - count: 2 - path: src/lib/FieldType/BinaryBase/BinaryBaseStorage.php - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\BinaryBase\\\\BinaryBaseStorage\\\\Gateway\\:\\:countFileReferences\\(\\) has parameter \\$files with no value type specified in iterable type array\\.$#" count: 1 @@ -9125,21 +8985,6 @@ parameters: count: 1 path: src/lib/FieldType/FieldType.php - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\GatewayBasedStorage\\:\\:addGateway\\(\\) has no return type specified\\.$#" - count: 1 - path: src/lib/FieldType/GatewayBasedStorage.php - - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\GatewayBasedStorage\\:\\:copyLegacyField\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/GatewayBasedStorage.php - - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\GatewayBasedStorage\\:\\:getGateway\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/GatewayBasedStorage.php - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\Handler\\:\\:initWithFieldTypeValue\\(\\) has no return type specified\\.$#" count: 1 @@ -9265,11 +9110,6 @@ parameters: count: 1 path: src/lib/FieldType/Image/ImageStorage.php - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\Image\\\\ImageStorage\\:\\:deleteFieldData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/Image/ImageStorage.php - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\Image\\\\ImageStorage\\:\\:deleteFieldData\\(\\) has parameter \\$fieldIds with no value type specified in iterable type array\\.$#" count: 1 @@ -9285,21 +9125,6 @@ parameters: count: 1 path: src/lib/FieldType/Image/ImageStorage.php - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\Image\\\\ImageStorage\\:\\:getFieldData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/Image/ImageStorage.php - - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\Image\\\\ImageStorage\\:\\:getIndexData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/Image/ImageStorage.php - - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\Image\\\\ImageStorage\\:\\:storeFieldData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/Image/ImageStorage.php - - message: "#^Parameter \\#1 \\.\\.\\.\\$arrays of function array_merge expects array, array\\|bool\\|float\\|int\\|string given\\.$#" count: 1 @@ -9510,11 +9335,6 @@ parameters: count: 1 path: src/lib/FieldType/Keyword/KeywordStorage.php - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\Keyword\\\\KeywordStorage\\:\\:deleteFieldData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/Keyword/KeywordStorage.php - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\Keyword\\\\KeywordStorage\\:\\:deleteFieldData\\(\\) has parameter \\$fieldIds with no value type specified in iterable type array\\.$#" count: 1 @@ -9525,21 +9345,6 @@ parameters: count: 1 path: src/lib/FieldType/Keyword/KeywordStorage.php - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\Keyword\\\\KeywordStorage\\:\\:getFieldData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/Keyword/KeywordStorage.php - - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\Keyword\\\\KeywordStorage\\:\\:getIndexData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/Keyword/KeywordStorage.php - - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\Keyword\\\\KeywordStorage\\:\\:storeFieldData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/Keyword/KeywordStorage.php - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\Keyword\\\\KeywordStorage\\\\Gateway\\:\\:deleteFieldData\\(\\) has no return type specified\\.$#" count: 1 @@ -9660,11 +9465,6 @@ parameters: count: 1 path: src/lib/FieldType/MapLocation/MapLocationStorage.php - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\MapLocation\\\\MapLocationStorage\\:\\:deleteFieldData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/MapLocation/MapLocationStorage.php - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\MapLocation\\\\MapLocationStorage\\:\\:deleteFieldData\\(\\) has parameter \\$fieldIds with no value type specified in iterable type array\\.$#" count: 1 @@ -9680,21 +9480,6 @@ parameters: count: 1 path: src/lib/FieldType/MapLocation/MapLocationStorage.php - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\MapLocation\\\\MapLocationStorage\\:\\:getFieldData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/MapLocation/MapLocationStorage.php - - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\MapLocation\\\\MapLocationStorage\\:\\:getIndexData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/MapLocation/MapLocationStorage.php - - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\MapLocation\\\\MapLocationStorage\\:\\:storeFieldData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/MapLocation/MapLocationStorage.php - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\MapLocation\\\\MapLocationStorage\\\\Gateway\\:\\:deleteFieldData\\(\\) has no return type specified\\.$#" count: 1 @@ -9870,21 +9655,11 @@ parameters: count: 1 path: src/lib/FieldType/Null/Type.php - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\NullStorage\\:\\:copyLegacyField\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/NullStorage.php - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\NullStorage\\:\\:copyLegacyField\\(\\) should return bool\\|null but empty return statement found\\.$#" count: 1 path: src/lib/FieldType/NullStorage.php - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\NullStorage\\:\\:deleteFieldData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/NullStorage.php - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\NullStorage\\:\\:deleteFieldData\\(\\) has parameter \\$fieldIds with no value type specified in iterable type array\\.$#" count: 1 @@ -9895,21 +9670,6 @@ parameters: count: 1 path: src/lib/FieldType/NullStorage.php - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\NullStorage\\:\\:getFieldData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/NullStorage.php - - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\NullStorage\\:\\:getIndexData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/NullStorage.php - - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\NullStorage\\:\\:storeFieldData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/NullStorage.php - - message: "#^Parameter \\#1 \\$array of function reset expects array\\|object, array\\|bool\\|float\\|int\\|string\\|null given\\.$#" count: 1 @@ -10075,11 +9835,6 @@ parameters: count: 1 path: src/lib/FieldType/Url/UrlStorage.php - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\Url\\\\UrlStorage\\:\\:deleteFieldData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/Url/UrlStorage.php - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\Url\\\\UrlStorage\\:\\:deleteFieldData\\(\\) has parameter \\$fieldIds with no value type specified in iterable type array\\.$#" count: 1 @@ -10095,21 +9850,6 @@ parameters: count: 1 path: src/lib/FieldType/Url/UrlStorage.php - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\Url\\\\UrlStorage\\:\\:getFieldData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/Url/UrlStorage.php - - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\Url\\\\UrlStorage\\:\\:getIndexData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/Url/UrlStorage.php - - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\Url\\\\UrlStorage\\:\\:storeFieldData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/Url/UrlStorage.php - - message: "#^Property Ibexa\\\\Core\\\\FieldType\\\\Url\\\\UrlStorage\\:\\:\\$logger \\(Psr\\\\Log\\\\LoggerInterface\\) does not accept Psr\\\\Log\\\\LoggerInterface\\|null\\.$#" count: 1 @@ -10245,31 +9985,11 @@ parameters: count: 1 path: src/lib/FieldType/User/UserStorage.php - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\User\\\\UserStorage\\:\\:deleteFieldData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/User/UserStorage.php - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\User\\\\UserStorage\\:\\:getFieldData\\(\\) has no return type specified\\.$#" count: 1 path: src/lib/FieldType/User/UserStorage.php - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\User\\\\UserStorage\\:\\:getFieldData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/User/UserStorage.php - - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\User\\\\UserStorage\\:\\:getIndexData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/User/UserStorage.php - - - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\User\\\\UserStorage\\:\\:storeFieldData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/FieldType/User/UserStorage.php - - message: "#^Method Ibexa\\\\Core\\\\FieldType\\\\User\\\\UserStorage\\\\Gateway\\:\\:getFieldData\\(\\) return type has no value type specified in iterable type array\\.$#" count: 1 @@ -10860,31 +10580,6 @@ parameters: count: 1 path: src/lib/IO/IOServiceInterface.php - - - message: "#^Method Ibexa\\\\Core\\\\IO\\\\MetadataHandler\\:\\:extract\\(\\) return type has no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/IO/MetadataHandler.php - - - - message: "#^Cannot access offset 'mime' on array\\{0\\: int\\<0, max\\>, 1\\: int\\<0, max\\>, 2\\: int, 3\\: string, mime\\: string, channels\\?\\: int, bits\\?\\: int\\}\\|false\\.$#" - count: 1 - path: src/lib/IO/MetadataHandler/ImageSize.php - - - - message: "#^Cannot access offset 0 on array\\{0\\: int\\<0, max\\>, 1\\: int\\<0, max\\>, 2\\: int, 3\\: string, mime\\: string, channels\\?\\: int, bits\\?\\: int\\}\\|false\\.$#" - count: 1 - path: src/lib/IO/MetadataHandler/ImageSize.php - - - - message: "#^Cannot access offset 1 on array\\{0\\: int\\<0, max\\>, 1\\: int\\<0, max\\>, 2\\: int, 3\\: string, mime\\: string, channels\\?\\: int, bits\\?\\: int\\}\\|false\\.$#" - count: 1 - path: src/lib/IO/MetadataHandler/ImageSize.php - - - - message: "#^Method Ibexa\\\\Core\\\\IO\\\\MetadataHandler\\\\ImageSize\\:\\:extract\\(\\) return type has no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/IO/MetadataHandler/ImageSize.php - - message: "#^Property Ibexa\\\\Core\\\\IO\\\\MimeTypeDetector\\\\FileInfo\\:\\:\\$fileInfo \\(finfo\\) in isset\\(\\) is not nullable\\.$#" count: 1 @@ -11355,16 +11050,6 @@ parameters: count: 1 path: src/lib/MVC/Symfony/Event/APIContentExceptionEvent.php - - - message: "#^Method Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\Event\\\\ContentCacheClearEvent\\:\\:addLocationToClear\\(\\) has no return type specified\\.$#" - count: 1 - path: src/lib/MVC/Symfony/Event/ContentCacheClearEvent.php - - - - message: "#^Method Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\Event\\\\ContentCacheClearEvent\\:\\:setLocationsToClear\\(\\) has no return type specified\\.$#" - count: 1 - path: src/lib/MVC/Symfony/Event/ContentCacheClearEvent.php - - message: "#^Method Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\Event\\\\PostSiteAccessMatchEvent\\:\\:__construct\\(\\) has parameter \\$requestType with no type specified\\.$#" count: 1 @@ -11410,6 +11095,11 @@ parameters: count: 1 path: src/lib/MVC/Symfony/EventListener/SiteAccessMatchListener.php + - + message: "#^Parameter \\#1 \\$properties of class Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\Routing\\\\SimplifiedRequest constructor expects array, string given\\.$#" + count: 1 + path: src/lib/MVC/Symfony/EventListener/SiteAccessMatchListener.php + - message: "#^Parameter \\#1 \\$serializedGroups of method Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\EventListener\\\\SiteAccessMatchListener\\:\\:buildGroups\\(\\) expects array\\, array\\ given\\.$#" count: 1 @@ -11510,11 +11200,6 @@ parameters: count: 1 path: src/lib/MVC/Symfony/Locale/LocaleConverter.php - - - message: "#^Method Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\Locale\\\\LocaleConverter\\:\\:convertToEz\\(\\) should return string\\|null but empty return statement found\\.$#" - count: 1 - path: src/lib/MVC/Symfony/Locale/LocaleConverter.php - - message: "#^Method Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\Locale\\\\LocaleConverter\\:\\:convertToPOSIX\\(\\) should return string\\|null but empty return statement found\\.$#" count: 1 @@ -11715,16 +11400,6 @@ parameters: count: 1 path: src/lib/MVC/Symfony/Routing/Generator.php - - - message: "#^Parameter \\#1 \\$httpPort of method Symfony\\\\Component\\\\Routing\\\\RequestContext\\:\\:setHttpPort\\(\\) expects int, string given\\.$#" - count: 1 - path: src/lib/MVC/Symfony/Routing/Generator.php - - - - message: "#^Parameter \\#1 \\$httpsPort of method Symfony\\\\Component\\\\Routing\\\\RequestContext\\:\\:setHttpsPort\\(\\) expects int, string given\\.$#" - count: 1 - path: src/lib/MVC/Symfony/Routing/Generator.php - - message: "#^Property Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\Routing\\\\Generator\\:\\:\\$logger \\(Psr\\\\Log\\\\LoggerInterface\\) does not accept Psr\\\\Log\\\\LoggerInterface\\|null\\.$#" count: 1 @@ -11865,6 +11540,11 @@ parameters: count: 1 path: src/lib/MVC/Symfony/Routing/SimplifiedRequest.php + - + message: "#^Method Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\Routing\\\\SimplifiedRequest\\:\\:__construct\\(\\) has parameter \\$properties with no value type specified in iterable type array\\.$#" + count: 1 + path: src/lib/MVC/Symfony/Routing/SimplifiedRequest.php + - message: "#^Method Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\Routing\\\\SimplifiedRequest\\:\\:setHeaders\\(\\) has no return type specified\\.$#" count: 1 @@ -12285,11 +11965,6 @@ parameters: count: 1 path: src/lib/MVC/Symfony/SiteAccess/Matcher/Map/Port.php - - - message: "#^Parameter \\#1 \\$key of method Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\SiteAccess\\\\Matcher\\\\Map\\:\\:setMapKey\\(\\) expects string, int\\|string given\\.$#" - count: 1 - path: src/lib/MVC/Symfony/SiteAccess/Matcher/Map/Port.php - - message: "#^Method Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\SiteAccess\\\\Matcher\\\\Map\\\\URI\\:\\:setRequest\\(\\) has no return type specified\\.$#" count: 1 @@ -12325,46 +12000,6 @@ parameters: count: 1 path: src/lib/MVC/Symfony/SiteAccess/Matcher/Regex.php - - - message: "#^Method Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\SiteAccess\\\\Matcher\\\\Regex\\\\Host\\:\\:__construct\\(\\) has parameter \\$siteAccessesConfiguration with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/MVC/Symfony/SiteAccess/Matcher/Regex/Host.php - - - - message: "#^Method Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\SiteAccess\\\\Matcher\\\\Regex\\\\Host\\:\\:setRequest\\(\\) has no return type specified\\.$#" - count: 1 - path: src/lib/MVC/Symfony/SiteAccess/Matcher/Regex/Host.php - - - - message: "#^Property Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\SiteAccess\\\\Matcher\\\\Regex\\\\Host\\:\\:\\$siteAccessesConfiguration is never read, only written\\.$#" - count: 1 - path: src/lib/MVC/Symfony/SiteAccess/Matcher/Regex/Host.php - - - - message: "#^Property Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\SiteAccess\\\\Matcher\\\\Regex\\\\Host\\:\\:\\$siteAccessesConfiguration type has no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/MVC/Symfony/SiteAccess/Matcher/Regex/Host.php - - - - message: "#^Method Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\SiteAccess\\\\Matcher\\\\Regex\\\\URI\\:\\:__construct\\(\\) has parameter \\$siteAccessesConfiguration with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/MVC/Symfony/SiteAccess/Matcher/Regex/URI.php - - - - message: "#^Method Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\SiteAccess\\\\Matcher\\\\Regex\\\\URI\\:\\:setRequest\\(\\) has no return type specified\\.$#" - count: 1 - path: src/lib/MVC/Symfony/SiteAccess/Matcher/Regex/URI.php - - - - message: "#^Property Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\SiteAccess\\\\Matcher\\\\Regex\\\\URI\\:\\:\\$siteAccessesConfiguration is never read, only written\\.$#" - count: 1 - path: src/lib/MVC/Symfony/SiteAccess/Matcher/Regex/URI.php - - - - message: "#^Property Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\SiteAccess\\\\Matcher\\\\Regex\\\\URI\\:\\:\\$siteAccessesConfiguration type has no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/MVC/Symfony/SiteAccess/Matcher/Regex/URI.php - - message: "#^Method Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\SiteAccess\\\\Matcher\\\\URIElement\\:\\:__construct\\(\\) has parameter \\$elementNumber with no value type specified in iterable type array\\.$#" count: 1 @@ -13405,36 +13040,6 @@ parameters: count: 1 path: src/lib/MVC/Symfony/View/Manager.php - - - message: "#^Method Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\View\\\\Manager\\:\\:addContentViewProvider\\(\\) has no return type specified\\.$#" - count: 1 - path: src/lib/MVC/Symfony/View/Manager.php - - - - message: "#^Method Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\View\\\\Manager\\:\\:addLocationViewProvider\\(\\) has no return type specified\\.$#" - count: 1 - path: src/lib/MVC/Symfony/View/Manager.php - - - - message: "#^Method Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\View\\\\Manager\\:\\:addViewProvider\\(\\) has no return type specified\\.$#" - count: 1 - path: src/lib/MVC/Symfony/View/Manager.php - - - - message: "#^Method Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\View\\\\Manager\\:\\:addViewProvider\\(\\) has parameter \\$property with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/MVC/Symfony/View/Manager.php - - - - message: "#^Method Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\View\\\\Manager\\:\\:getAllContentViewProviders\\(\\) should return array\\ but returns array\\\\.$#" - count: 1 - path: src/lib/MVC/Symfony/View/Manager.php - - - - message: "#^Method Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\View\\\\Manager\\:\\:getAllLocationViewProviders\\(\\) should return array\\ but returns array\\\\.$#" - count: 1 - path: src/lib/MVC/Symfony/View/Manager.php - - message: "#^Method Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\View\\\\Manager\\:\\:renderContent\\(\\) has parameter \\$parameters with no value type specified in iterable type array\\.$#" count: 1 @@ -13450,36 +13055,11 @@ parameters: count: 1 path: src/lib/MVC/Symfony/View/Manager.php - - - message: "#^Method Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\View\\\\Manager\\:\\:sortViewProviders\\(\\) has parameter \\$property with no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/MVC/Symfony/View/Manager.php - - - - message: "#^Property Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\View\\\\Manager\\:\\:\\$contentViewProviders type has no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/MVC/Symfony/View/Manager.php - - - - message: "#^Property Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\View\\\\Manager\\:\\:\\$locationViewProviders type has no value type specified in iterable type array\\.$#" - count: 1 - path: src/lib/MVC/Symfony/View/Manager.php - - message: "#^Property Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\View\\\\Manager\\:\\:\\$logger \\(Psr\\\\Log\\\\LoggerInterface\\) does not accept Psr\\\\Log\\\\LoggerInterface\\|null\\.$#" count: 1 path: src/lib/MVC/Symfony/View/Manager.php - - - message: "#^Property Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\View\\\\Manager\\:\\:\\$sortedContentViewProviders \\(array\\\\) does not accept array\\\\.$#" - count: 1 - path: src/lib/MVC/Symfony/View/Manager.php - - - - message: "#^Property Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\View\\\\Manager\\:\\:\\$sortedLocationViewProviders \\(array\\\\) does not accept array\\\\.$#" - count: 1 - path: src/lib/MVC/Symfony/View/Manager.php - - message: "#^Method Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\View\\\\ParametersInjector\\:\\:injectViewParameters\\(\\) has no return type specified\\.$#" count: 1 @@ -20770,21 +20350,6 @@ parameters: count: 1 path: src/lib/Repository/URLWildcardService.php - - - message: "#^Result of \\|\\| is always false\\.$#" - count: 1 - path: src/lib/Repository/URLWildcardService.php - - - - message: "#^Variable \\$patterns in empty\\(\\) always exists and is not falsy\\.$#" - count: 1 - path: src/lib/Repository/URLWildcardService.php - - - - message: "#^Variable \\$placeholders in empty\\(\\) always exists and is not falsy\\.$#" - count: 1 - path: src/lib/Repository/URLWildcardService.php - - message: "#^Parameter \\#3 \\$hashType of method Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\PasswordHashService\\:\\:isValidPassword\\(\\) expects int\\|null, string given\\.$#" count: 1 @@ -23240,16 +22805,6 @@ parameters: count: 1 path: tests/bundle/Core/DependencyInjection/Configuration/Parser/CommonTest.php - - - message: "#^Method Ibexa\\\\Tests\\\\Bundle\\\\Core\\\\DependencyInjection\\\\Configuration\\\\Parser\\\\CommonTest\\:\\:testDatabaseSingleSiteaccess\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/bundle/Core/DependencyInjection/Configuration/Parser/CommonTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Bundle\\\\Core\\\\DependencyInjection\\\\Configuration\\\\Parser\\\\CommonTest\\:\\:testDatabaseSiteaccessGroup\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/bundle/Core/DependencyInjection/Configuration/Parser/CommonTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Bundle\\\\Core\\\\DependencyInjection\\\\Configuration\\\\Parser\\\\CommonTest\\:\\:testDefaultPage\\(\\) has no return type specified\\.$#" count: 1 @@ -23310,11 +22865,6 @@ parameters: count: 1 path: tests/bundle/Core/DependencyInjection/Configuration/Parser/CommonTest.php - - - message: "#^Property Ibexa\\\\Tests\\\\Bundle\\\\Core\\\\DependencyInjection\\\\Configuration\\\\Parser\\\\CommonTest\\:\\:\\$suggestionCollector is never read, only written\\.$#" - count: 1 - path: tests/bundle/Core/DependencyInjection/Configuration/Parser/CommonTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Bundle\\\\Core\\\\DependencyInjection\\\\Configuration\\\\Parser\\\\ContentTest\\:\\:contentSettingsProvider\\(\\) has no return type specified\\.$#" count: 1 @@ -25980,21 +25530,6 @@ parameters: count: 1 path: tests/integration/Core/IO/BinarydataHandler/FlysystemTest.php - - - message: "#^Generator expects value type array\\{Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Image\\\\ImageStorage\\\\Ibexa\\\\Contracts\\\\Core\\\\Persistence\\\\Content\\\\VersionInfo, Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Image\\\\ImageStorage\\\\Ibexa\\\\Contracts\\\\Core\\\\Persistence\\\\Content\\\\Field\\}, array\\{Ibexa\\\\Contracts\\\\Core\\\\Persistence\\\\Content\\\\VersionInfo, Ibexa\\\\Contracts\\\\Core\\\\Persistence\\\\Content\\\\Field\\} given\\.$#" - count: 1 - path: tests/integration/Core/Image/ImageStorage/ImageStorageTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Image\\\\ImageStorage\\\\ImageStorageTest\\:\\:providerOfFieldData\\(\\) has invalid return type Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Image\\\\ImageStorage\\\\Ibexa\\\\Contracts\\\\Core\\\\Persistence\\\\Content\\\\Field\\.$#" - count: 1 - path: tests/integration/Core/Image/ImageStorage/ImageStorageTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Image\\\\ImageStorage\\\\ImageStorageTest\\:\\:providerOfFieldData\\(\\) has invalid return type Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Image\\\\ImageStorage\\\\Ibexa\\\\Contracts\\\\Core\\\\Persistence\\\\Content\\\\VersionInfo\\.$#" - count: 1 - path: tests/integration/Core/Image/ImageStorage/ImageStorageTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Limitation\\\\MemberOfLimitationTest\\:\\:testCanUserAssignRoleToUser\\(\\) has parameter \\$limitations with no value type specified in iterable type array\\.$#" count: 1 @@ -26605,11 +26140,6 @@ parameters: count: 2 path: tests/integration/Core/Repository/ContentServiceAuthorizationTest.php - - - message: "#^Parameter \\#1 \\$value of function count expects array\\|Countable, iterable\\ given\\.$#" - count: 4 - path: tests/integration/Core/Repository/ContentServiceAuthorizationTest.php - - message: "#^Access to an undefined property object\\:\\:\\$content\\.$#" count: 6 @@ -26710,11 +26240,6 @@ parameters: count: 1 path: tests/integration/Core/Repository/ContentServiceTest.php - - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\ContentServiceTest\\:\\:testAddRelation\\(\\) should return array\\ but returns iterable\\\\.$#" - count: 1 - path: tests/integration/Core/Repository/ContentServiceTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\ContentServiceTest\\:\\:testAddRelationAddsRelationToContent\\(\\) has no return type specified\\.$#" count: 1 @@ -26825,11 +26350,6 @@ parameters: count: 1 path: tests/integration/Core/Repository/ContentServiceTest.php - - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\ContentServiceTest\\:\\:testCreateContentDraftWithRelations\\(\\) should return array\\ but returns iterable\\\\.$#" - count: 1 - path: tests/integration/Core/Repository/ContentServiceTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\ContentServiceTest\\:\\:testCreateContentDraftWithRelationsCreatesExpectedRelations\\(\\) has no return type specified\\.$#" count: 1 @@ -27070,11 +26590,6 @@ parameters: count: 1 path: tests/integration/Core/Repository/ContentServiceTest.php - - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\ContentServiceTest\\:\\:testLoadAllContentDrafts\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/integration/Core/Repository/ContentServiceTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\ContentServiceTest\\:\\:testLoadContent\\(\\) has no return type specified\\.$#" count: 1 @@ -27140,21 +26655,6 @@ parameters: count: 1 path: tests/integration/Core/Repository/ContentServiceTest.php - - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\ContentServiceTest\\:\\:testLoadContentDraftListWithForUserWithLimitation\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/integration/Core/Repository/ContentServiceTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\ContentServiceTest\\:\\:testLoadContentDraftListWithPaginationParameters\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/integration/Core/Repository/ContentServiceTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\ContentServiceTest\\:\\:testLoadContentDrafts\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/integration/Core/Repository/ContentServiceTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\ContentServiceTest\\:\\:testLoadContentDraftsReturnsEmptyArrayByDefault\\(\\) has no return type specified\\.$#" count: 1 @@ -27240,11 +26740,6 @@ parameters: count: 1 path: tests/integration/Core/Repository/ContentServiceTest.php - - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\ContentServiceTest\\:\\:testLoadRelations\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/integration/Core/Repository/ContentServiceTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\ContentServiceTest\\:\\:testLoadRelationsSkipsArchivedContent\\(\\) has no return type specified\\.$#" count: 1 @@ -27555,11 +27050,6 @@ parameters: count: 1 path: tests/integration/Core/Repository/ContentServiceTest.php - - - message: "#^Parameter \\#1 \\$array of function array_values expects array\\, iterable\\ given\\.$#" - count: 1 - path: tests/integration/Core/Repository/ContentServiceTest.php - - message: "#^Parameter \\#1 \\$fields of method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\ContentServiceTest\\:\\:assertAllFieldsEquals\\(\\) expects array\\, iterable\\ given\\.$#" count: 1 @@ -27595,11 +27085,6 @@ parameters: count: 1 path: tests/integration/Core/Repository/ContentServiceTest.php - - - message: "#^Parameter \\#1 \\$value of function count expects array\\|Countable, iterable\\ given\\.$#" - count: 1 - path: tests/integration/Core/Repository/ContentServiceTest.php - - message: "#^Parameter \\#1 \\$value of function count expects array\\|Countable, iterable\\ given\\.$#" count: 2 @@ -29925,41 +29410,16 @@ parameters: count: 1 path: tests/integration/Core/Repository/FieldType/MapLocationIntegrationTest.php - - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\FieldType\\\\RelationIntegrationTest\\:\\:assertCopiedFieldDataLoadedCorrectly\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/integration/Core/Repository/FieldType/RelationIntegrationTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\FieldType\\\\RelationIntegrationTest\\:\\:assertFieldDataLoadedCorrect\\(\\) has no return type specified\\.$#" count: 1 path: tests/integration/Core/Repository/FieldType/RelationIntegrationTest.php - - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\FieldType\\\\RelationIntegrationTest\\:\\:assertUpdatedFieldDataLoadedCorrect\\(\\) return type has no value type specified in iterable type array\\.$#" - count: 1 - path: tests/integration/Core/Repository/FieldType/RelationIntegrationTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\FieldType\\\\RelationIntegrationTest\\:\\:assertUpdatedFieldDataLoadedCorrect\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: tests/integration/Core/Repository/FieldType/RelationIntegrationTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\FieldType\\\\RelationIntegrationTest\\:\\:getSettingsSchema\\(\\) return type has no value type specified in iterable type array\\.$#" count: 1 path: tests/integration/Core/Repository/FieldType/RelationIntegrationTest.php - - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\FieldType\\\\RelationIntegrationTest\\:\\:getValidUpdateFieldData\\(\\) return type has no value type specified in iterable type array\\.$#" - count: 1 - path: tests/integration/Core/Repository/FieldType/RelationIntegrationTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\FieldType\\\\RelationIntegrationTest\\:\\:getValidUpdateFieldData\\(\\) should return array but returns Ibexa\\\\Core\\\\FieldType\\\\Relation\\\\Value\\.$#" - count: 1 - path: tests/integration/Core/Repository/FieldType/RelationIntegrationTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\FieldType\\\\RelationIntegrationTest\\:\\:getValidatorSchema\\(\\) return type has no value type specified in iterable type array\\.$#" count: 1 @@ -30015,51 +29475,16 @@ parameters: count: 1 path: tests/integration/Core/Repository/FieldType/RelationIntegrationTest.php - - - message: "#^Parameter \\#1 \\$relations of method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\FieldType\\\\RelationIntegrationTest\\:\\:normalizeRelations\\(\\) expects array\\, array\\ given\\.$#" - count: 5 - path: tests/integration/Core/Repository/FieldType/RelationIntegrationTest.php - - - - message: "#^Parameter \\#1 \\$relations of method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\FieldType\\\\RelationIntegrationTest\\:\\:normalizeRelations\\(\\) expects array\\, iterable\\ given\\.$#" - count: 5 - path: tests/integration/Core/Repository/FieldType/RelationIntegrationTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\FieldType\\\\RelationListIntegrationTest\\:\\:assertCopiedFieldDataLoadedCorrectly\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/integration/Core/Repository/FieldType/RelationListIntegrationTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\FieldType\\\\RelationListIntegrationTest\\:\\:assertFieldDataLoadedCorrect\\(\\) has no return type specified\\.$#" count: 1 path: tests/integration/Core/Repository/FieldType/RelationListIntegrationTest.php - - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\FieldType\\\\RelationListIntegrationTest\\:\\:assertUpdatedFieldDataLoadedCorrect\\(\\) return type has no value type specified in iterable type array\\.$#" - count: 1 - path: tests/integration/Core/Repository/FieldType/RelationListIntegrationTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\FieldType\\\\RelationListIntegrationTest\\:\\:assertUpdatedFieldDataLoadedCorrect\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: tests/integration/Core/Repository/FieldType/RelationListIntegrationTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\FieldType\\\\RelationListIntegrationTest\\:\\:getSettingsSchema\\(\\) return type has no value type specified in iterable type array\\.$#" count: 1 path: tests/integration/Core/Repository/FieldType/RelationListIntegrationTest.php - - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\FieldType\\\\RelationListIntegrationTest\\:\\:getValidUpdateFieldData\\(\\) return type has no value type specified in iterable type array\\.$#" - count: 1 - path: tests/integration/Core/Repository/FieldType/RelationListIntegrationTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\FieldType\\\\RelationListIntegrationTest\\:\\:getValidUpdateFieldData\\(\\) should return array but returns Ibexa\\\\Core\\\\FieldType\\\\RelationList\\\\Value\\.$#" - count: 1 - path: tests/integration/Core/Repository/FieldType/RelationListIntegrationTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\FieldType\\\\RelationListIntegrationTest\\:\\:getValidatorSchema\\(\\) return type has no value type specified in iterable type array\\.$#" count: 1 @@ -30115,16 +29540,6 @@ parameters: count: 1 path: tests/integration/Core/Repository/FieldType/RelationListIntegrationTest.php - - - message: "#^Parameter \\#1 \\$relations of method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\FieldType\\\\RelationListIntegrationTest\\:\\:normalizeRelations\\(\\) expects array\\, array\\ given\\.$#" - count: 5 - path: tests/integration/Core/Repository/FieldType/RelationListIntegrationTest.php - - - - message: "#^Parameter \\#1 \\$relations of method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\FieldType\\\\RelationListIntegrationTest\\:\\:normalizeRelations\\(\\) expects array\\, iterable\\ given\\.$#" - count: 5 - path: tests/integration/Core/Repository/FieldType/RelationListIntegrationTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Integration\\\\Core\\\\Repository\\\\FieldType\\\\SearchBaseIntegrationTest\\:\\:assertFindResult\\(\\) has no return type specified\\.$#" count: 1 @@ -39441,7 +38856,7 @@ parameters: path: tests/lib/Base/Container/Compiler/Storage/Legacy/RoleLimitationConverterPassTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Base\\\\Container\\\\Compiler\\\\Stubs\\\\GatewayBasedStorageHandler\\:\\:deleteFieldData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" + message: "#^Class Ibexa\\\\Tests\\\\Core\\\\Base\\\\Container\\\\Compiler\\\\Stubs\\\\GatewayBasedStorageHandler extends generic class Ibexa\\\\Contracts\\\\Core\\\\FieldType\\\\GatewayBasedStorage but does not specify its types\\: T$#" count: 1 path: tests/lib/Base/Container/Compiler/Stubs/GatewayBasedStorageHandler.php @@ -39460,26 +38875,11 @@ parameters: count: 1 path: tests/lib/Base/Container/Compiler/Stubs/GatewayBasedStorageHandler.php - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Base\\\\Container\\\\Compiler\\\\Stubs\\\\GatewayBasedStorageHandler\\:\\:getFieldData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: tests/lib/Base/Container/Compiler/Stubs/GatewayBasedStorageHandler.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Base\\\\Container\\\\Compiler\\\\Stubs\\\\GatewayBasedStorageHandler\\:\\:getIndexData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: tests/lib/Base/Container/Compiler/Stubs/GatewayBasedStorageHandler.php - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Base\\\\Container\\\\Compiler\\\\Stubs\\\\GatewayBasedStorageHandler\\:\\:hasFieldData\\(\\) should return bool but return statement is missing\\.$#" count: 1 path: tests/lib/Base/Container/Compiler/Stubs/GatewayBasedStorageHandler.php - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Base\\\\Container\\\\Compiler\\\\Stubs\\\\GatewayBasedStorageHandler\\:\\:storeFieldData\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#" - count: 1 - path: tests/lib/Base/Container/Compiler/Stubs/GatewayBasedStorageHandler.php - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Base\\\\Container\\\\Compiler\\\\TaggedServiceIdsIterator\\\\DeprecationErrorCollector\\:\\:getErrors\\(\\) return type has no value type specified in iterable type array\\.$#" count: 1 @@ -42100,11 +41500,6 @@ parameters: count: 1 path: tests/lib/FieldType/Image/IO/LegacyTest.php - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\FieldType\\\\Image\\\\IO\\\\LegacyTest\\:\\:testGetExternalPath\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/FieldType/Image/IO/LegacyTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\FieldType\\\\Image\\\\IO\\\\LegacyTest\\:\\:testGetFileContents\\(\\) has no return type specified\\.$#" count: 1 @@ -42120,11 +41515,6 @@ parameters: count: 1 path: tests/lib/FieldType/Image/IO/LegacyTest.php - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\FieldType\\\\Image\\\\IO\\\\LegacyTest\\:\\:testGetInternalPath\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/FieldType/Image/IO/LegacyTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\FieldType\\\\Image\\\\IO\\\\LegacyTest\\:\\:testGetMimeType\\(\\) has no return type specified\\.$#" count: 1 @@ -42840,11 +42230,6 @@ parameters: count: 2 path: tests/lib/FieldType/Url/UrlStorageTest.php - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\FieldType\\\\Url\\\\UrlStorageTest\\:\\:getContext\\(\\) return type has no value type specified in iterable type array\\.$#" - count: 1 - path: tests/lib/FieldType/Url/UrlStorageTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\FieldType\\\\Url\\\\UrlStorageTest\\:\\:testDeleteFieldData\\(\\) has no return type specified\\.$#" count: 1 @@ -43100,11 +42485,6 @@ parameters: count: 1 path: tests/lib/Helper/PreviewLocationProviderTest.php - - - message: "#^Property Ibexa\\\\Tests\\\\Core\\\\Helper\\\\PreviewLocationProviderTest\\:\\:\\$contentService \\(Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\LocationService&PHPUnit\\\\Framework\\\\MockObject\\\\MockObject\\) does not accept Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\ContentService&PHPUnit\\\\Framework\\\\MockObject\\\\MockObject\\.$#" - count: 1 - path: tests/lib/Helper/PreviewLocationProviderTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Helper\\\\TranslationHelperTest\\:\\:getTranslatedField\\(\\) has no return type specified\\.$#" count: 1 @@ -43210,11 +42590,6 @@ parameters: count: 1 path: tests/lib/Helper/TranslationHelperTest.php - - - message: "#^Parameter \\#1 \\$internalId of method Ibexa\\\\Core\\\\IO\\\\ConfigScopeChangeAwareIOService\\:\\:getExternalPath\\(\\) expects string, int given\\.$#" - count: 1 - path: tests/lib/IO/ConfigScopeChangeAwareIOServiceTest.php - - message: "#^Property Ibexa\\\\Tests\\\\Core\\\\IO\\\\ConfigScopeChangeAwareIOServiceTest\\:\\:\\$innerIOService \\(Ibexa\\\\Core\\\\IO\\\\ConfigScopeChangeAwareIOService&PHPUnit\\\\Framework\\\\MockObject\\\\MockObject\\) does not accept Ibexa\\\\Core\\\\IO\\\\IOServiceInterface&PHPUnit\\\\Framework\\\\MockObject\\\\MockObject\\.$#" count: 1 @@ -43400,26 +42775,11 @@ parameters: count: 1 path: tests/lib/IO/IOServiceTest.php - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\IO\\\\IOServiceTest\\:\\:testNewBinaryCreateStructFromUploadedFile\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/IO/IOServiceTest.php - - message: "#^Property Ibexa\\\\Contracts\\\\Core\\\\IO\\\\BinaryFile\\:\\:\\$size \\(int\\) does not accept int\\<0, max\\>\\|false\\.$#" count: 1 path: tests/lib/IO/IOServiceTest.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: tests/lib/IO/IOServiceTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\IO\\\\MetadataHandler\\\\ImageSizeTest\\:\\:testExtract\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/IO/MetadataHandler/ImageSizeTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\IO\\\\MimeTypeDetector\\\\FileInfoTest\\:\\:testGetFromBuffer\\(\\) has no return type specified\\.$#" count: 1 @@ -44620,6 +43980,11 @@ parameters: count: 1 path: tests/lib/Limitation/SubtreeLimitationTypeTest.php + - + message: "#^Parameter \\#1 \\$properties of class Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\Routing\\\\SimplifiedRequest constructor expects array, string given\\.$#" + count: 1 + path: tests/lib/MVC/Symfony/Component/Serializer/SimplifiedRequestNormalizerTest.php + - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\MVC\\\\Symfony\\\\Component\\\\Serializer\\\\Stubs\\\\CompoundStub\\:\\:__construct\\(\\) has parameter \\$subMatchers with no value type specified in iterable type array\\.$#" count: 1 @@ -44685,21 +44050,6 @@ parameters: count: 2 path: tests/lib/MVC/Symfony/Controller/QueryRenderControllerTest.php - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\MVC\\\\Symfony\\\\Event\\\\ContentCacheClearEventTest\\:\\:setLocationsToClear\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/MVC/Symfony/Event/ContentCacheClearEventTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\MVC\\\\Symfony\\\\Event\\\\ContentCacheClearEventTest\\:\\:testAddLocationsToClear\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/MVC/Symfony/Event/ContentCacheClearEventTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\MVC\\\\Symfony\\\\Event\\\\ContentCacheClearEventTest\\:\\:testConstruct\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/MVC/Symfony/Event/ContentCacheClearEventTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\MVC\\\\Symfony\\\\Event\\\\RouteReferenceGenerationEventTest\\:\\:testConstruct\\(\\) has no return type specified\\.$#" count: 1 @@ -46301,19 +45651,9 @@ parameters: path: tests/lib/MVC/Symfony/SiteAccess/RouterHostPortURITest.php - - message: "#^Class Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\SiteAccess\\\\Matcher\\\\Regex\\\\Host constructor invoked with 2 parameters, 1 required\\.$#" - count: 1 - path: tests/lib/MVC/Symfony/SiteAccess/RouterHostRegexTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\MVC\\\\Symfony\\\\SiteAccess\\\\RouterHostRegexTest\\:\\:matchProvider\\(\\) return type has no value type specified in iterable type array\\.$#" - count: 1 - path: tests/lib/MVC/Symfony/SiteAccess/RouterHostRegexTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\MVC\\\\Symfony\\\\SiteAccess\\\\RouterHostRegexTest\\:\\:testGetName\\(\\) has no return type specified\\.$#" + message: "#^Parameter \\#1 \\$properties of class Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\Routing\\\\SimplifiedRequest constructor expects array, string given\\.$#" count: 1 - path: tests/lib/MVC/Symfony/SiteAccess/RouterHostRegexTest.php + path: tests/lib/MVC/Symfony/SiteAccess/RouterHostPortURITest.php - message: "#^Class Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\SiteAccess\\\\Matcher\\\\HostText constructor invoked with 2 parameters, 1 required\\.$#" @@ -46555,26 +45895,6 @@ parameters: count: 1 path: tests/lib/MVC/Symfony/SiteAccess/RouterURIElementTest.php - - - message: "#^Class Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\SiteAccess\\\\Matcher\\\\Regex\\\\URI constructor invoked with 2 parameters, 1 required\\.$#" - count: 1 - path: tests/lib/MVC/Symfony/SiteAccess/RouterURIRegexTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\MVC\\\\Symfony\\\\SiteAccess\\\\RouterURIRegexTest\\:\\:matchProvider\\(\\) return type has no value type specified in iterable type array\\.$#" - count: 1 - path: tests/lib/MVC/Symfony/SiteAccess/RouterURIRegexTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\MVC\\\\Symfony\\\\SiteAccess\\\\RouterURIRegexTest\\:\\:testGetName\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/MVC/Symfony/SiteAccess/RouterURIRegexTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\MVC\\\\Symfony\\\\SiteAccess\\\\RouterURIRegexTest\\:\\:testSerialize\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/MVC/Symfony/SiteAccess/RouterURIRegexTest.php - - message: "#^Class Ibexa\\\\Core\\\\MVC\\\\Symfony\\\\SiteAccess\\\\Matcher\\\\URIText constructor invoked with 2 parameters, 1 required\\.$#" count: 1 @@ -47230,36 +46550,6 @@ parameters: count: 1 path: tests/lib/MVC/Symfony/View/VariableProviderRegistryTest.php - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\MVC\\\\Symfony\\\\View\\\\ViewManagerTest\\:\\:createContentViewProviderMocks\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/MVC/Symfony/View/ViewManagerTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\MVC\\\\Symfony\\\\View\\\\ViewManagerTest\\:\\:createLocationViewProviderMocks\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/MVC/Symfony/View/ViewManagerTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\MVC\\\\Symfony\\\\View\\\\ViewManagerTest\\:\\:testAddContentViewProvider\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/MVC/Symfony/View/ViewManagerTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\MVC\\\\Symfony\\\\View\\\\ViewManagerTest\\:\\:testAddLocationViewProvider\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/MVC/Symfony/View/ViewManagerTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\MVC\\\\Symfony\\\\View\\\\ViewManagerTest\\:\\:testContentViewProvidersPriority\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/MVC/Symfony/View/ViewManagerTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\MVC\\\\Symfony\\\\View\\\\ViewManagerTest\\:\\:testLocationViewProvidersPriority\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/MVC/Symfony/View/ViewManagerTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\MVC\\\\Symfony\\\\View\\\\ViewManagerTest\\:\\:testRenderContent\\(\\) has no return type specified\\.$#" count: 1 @@ -54375,11 +53665,6 @@ parameters: count: 1 path: tests/lib/Repository/Decorator/ContentServiceDecoratorTest.php - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Decorator\\\\ContentServiceDecoratorTest\\:\\:testLoadContentDraftsDecorator\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/Repository/Decorator/ContentServiceDecoratorTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Decorator\\\\ContentServiceDecoratorTest\\:\\:testLoadContentInfoByRemoteIdDecorator\\(\\) has no return type specified\\.$#" count: 1 @@ -54400,11 +53685,6 @@ parameters: count: 1 path: tests/lib/Repository/Decorator/ContentServiceDecoratorTest.php - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Decorator\\\\ContentServiceDecoratorTest\\:\\:testLoadRelationsDecorator\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/Repository/Decorator/ContentServiceDecoratorTest.php - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Decorator\\\\ContentServiceDecoratorTest\\:\\:testLoadReverseRelationsDecorator\\(\\) has no return type specified\\.$#" count: 1 @@ -54465,11 +53745,6 @@ parameters: count: 1 path: tests/lib/Repository/Decorator/ContentServiceDecoratorTest.php - - - message: "#^Parameter \\#1 \\$innerService of class class@anonymous/tests/lib/Repository/Decorator/ContentServiceDecoratorTest\\.php\\:35 constructor expects Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\ContentService, PHPUnit\\\\Framework\\\\MockObject\\\\MockObject given\\.$#" - count: 1 - path: tests/lib/Repository/Decorator/ContentServiceDecoratorTest.php - - message: "#^Parameter \\#2 \\$locationCreateStructs of method Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\ContentService\\:\\:createContent\\(\\) expects array\\, array\\ given\\.$#" count: 1 @@ -57255,121 +56530,6 @@ parameters: count: 1 path: tests/lib/Repository/Service/Mock/PermissionTest.php - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionsCriterionHandlerTest\\:\\:getPermissionResolverMock\\(\\) has parameter \\$methods with no type specified\\.$#" - count: 1 - path: tests/lib/Repository/Service/Mock/PermissionsCriterionHandlerTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionsCriterionHandlerTest\\:\\:mockServices\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/Repository/Service/Mock/PermissionsCriterionHandlerTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionsCriterionHandlerTest\\:\\:mockServices\\(\\) has parameter \\$criterionMock with no type specified\\.$#" - count: 1 - path: tests/lib/Repository/Service/Mock/PermissionsCriterionHandlerTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionsCriterionHandlerTest\\:\\:mockServices\\(\\) has parameter \\$limitationCount with no type specified\\.$#" - count: 1 - path: tests/lib/Repository/Service/Mock/PermissionsCriterionHandlerTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionsCriterionHandlerTest\\:\\:mockServices\\(\\) has parameter \\$permissionSets with no type specified\\.$#" - count: 1 - path: tests/lib/Repository/Service/Mock/PermissionsCriterionHandlerTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionsCriterionHandlerTest\\:\\:providerForTestAddPermissionsCriterion\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/Repository/Service/Mock/PermissionsCriterionHandlerTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionsCriterionHandlerTest\\:\\:providerForTestAddPermissionsCriterionWithBooleanPermission\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/Repository/Service/Mock/PermissionsCriterionHandlerTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionsCriterionHandlerTest\\:\\:providerForTestGetPermissionsCriterion\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/Repository/Service/Mock/PermissionsCriterionHandlerTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionsCriterionHandlerTest\\:\\:providerForTestGetPermissionsCriterionBooleanPermissionSets\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/Repository/Service/Mock/PermissionsCriterionHandlerTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionsCriterionHandlerTest\\:\\:testAddPermissionsCriterion\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/Repository/Service/Mock/PermissionsCriterionHandlerTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionsCriterionHandlerTest\\:\\:testAddPermissionsCriterion\\(\\) has parameter \\$expectedCriterion with no type specified\\.$#" - count: 1 - path: tests/lib/Repository/Service/Mock/PermissionsCriterionHandlerTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionsCriterionHandlerTest\\:\\:testAddPermissionsCriterion\\(\\) has parameter \\$givenCriterion with no type specified\\.$#" - count: 1 - path: tests/lib/Repository/Service/Mock/PermissionsCriterionHandlerTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionsCriterionHandlerTest\\:\\:testAddPermissionsCriterion\\(\\) has parameter \\$permissionsCriterionMock with no type specified\\.$#" - count: 1 - path: tests/lib/Repository/Service/Mock/PermissionsCriterionHandlerTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionsCriterionHandlerTest\\:\\:testAddPermissionsCriterionWithBooleanPermission\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/Repository/Service/Mock/PermissionsCriterionHandlerTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionsCriterionHandlerTest\\:\\:testAddPermissionsCriterionWithBooleanPermission\\(\\) has parameter \\$permissionsCriterion with no type specified\\.$#" - count: 1 - path: tests/lib/Repository/Service/Mock/PermissionsCriterionHandlerTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionsCriterionHandlerTest\\:\\:testGetPermissionsCriterion\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/Repository/Service/Mock/PermissionsCriterionHandlerTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionsCriterionHandlerTest\\:\\:testGetPermissionsCriterion\\(\\) has parameter \\$criterionMock with no type specified\\.$#" - count: 1 - path: tests/lib/Repository/Service/Mock/PermissionsCriterionHandlerTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionsCriterionHandlerTest\\:\\:testGetPermissionsCriterion\\(\\) has parameter \\$expectedCriterion with no type specified\\.$#" - count: 1 - path: tests/lib/Repository/Service/Mock/PermissionsCriterionHandlerTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionsCriterionHandlerTest\\:\\:testGetPermissionsCriterion\\(\\) has parameter \\$limitationCount with no type specified\\.$#" - count: 1 - path: tests/lib/Repository/Service/Mock/PermissionsCriterionHandlerTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionsCriterionHandlerTest\\:\\:testGetPermissionsCriterion\\(\\) has parameter \\$permissionSets with no type specified\\.$#" - count: 1 - path: tests/lib/Repository/Service/Mock/PermissionsCriterionHandlerTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionsCriterionHandlerTest\\:\\:testGetPermissionsCriterionBooleanPermissionSets\\(\\) has no return type specified\\.$#" - count: 1 - path: tests/lib/Repository/Service/Mock/PermissionsCriterionHandlerTest.php - - - - message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionsCriterionHandlerTest\\:\\:testGetPermissionsCriterionBooleanPermissionSets\\(\\) has parameter \\$permissionSets with no type specified\\.$#" - count: 1 - path: tests/lib/Repository/Service/Mock/PermissionsCriterionHandlerTest.php - - - - message: "#^Property Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionsCriterionHandlerTest\\:\\:\\$permissionResolverMock has no type specified\\.$#" - count: 1 - path: tests/lib/Repository/Service/Mock/PermissionsCriterionHandlerTest.php - - message: "#^Call to an undefined method Ibexa\\\\Contracts\\\\Core\\\\Persistence\\\\Content\\\\Location\\\\Handler\\:\\:expects\\(\\)\\.$#" count: 2 diff --git a/src/lib/FieldType/BinaryBase/BinaryBaseStorage.php b/src/lib/FieldType/BinaryBase/BinaryBaseStorage.php index b53a4665dd..7a19ebb623 100644 --- a/src/lib/FieldType/BinaryBase/BinaryBaseStorage.php +++ b/src/lib/FieldType/BinaryBase/BinaryBaseStorage.php @@ -131,7 +131,6 @@ public function copyLegacyField(VersionInfo $versionInfo, Field $field, Field $o * * @param mixed $fieldId * @param string $versionNo - * @param array $context */ protected function removeOldFile($fieldId, $versionNo) { diff --git a/src/lib/FieldType/Keyword/KeywordStorage.php b/src/lib/FieldType/Keyword/KeywordStorage.php index 5ad704a033..6fe2a16422 100644 --- a/src/lib/FieldType/Keyword/KeywordStorage.php +++ b/src/lib/FieldType/Keyword/KeywordStorage.php @@ -26,10 +26,6 @@ class KeywordStorage extends GatewayBasedStorage /** * @see \Ibexa\Contracts\Core\FieldType\FieldStorage * - * @param \Ibexa\Contracts\Core\Persistence\Content\VersionInfo $versionInfo - * @param \Ibexa\Contracts\Core\Persistence\Content\Field $field - * @param array $context - * * @return mixed */ public function storeFieldData(VersionInfo $versionInfo, Field $field) @@ -45,11 +41,7 @@ public function getFieldData(VersionInfo $versionInfo, Field $field) } /** - * @param \Ibexa\Contracts\Core\Persistence\Content\VersionInfo $versionInfo * @param array $fieldIds - * @param array $context - * - * @return bool */ public function deleteFieldData(VersionInfo $versionInfo, array $fieldIds): bool { @@ -60,11 +52,6 @@ public function deleteFieldData(VersionInfo $versionInfo, array $fieldIds): bool return true; } - /** - * Checks if field type has external data to deal with. - * - * @return bool - */ public function hasFieldData(): bool { return true; diff --git a/src/lib/FieldType/User/UserStorage.php b/src/lib/FieldType/User/UserStorage.php index 25718712f2..e09ef60329 100644 --- a/src/lib/FieldType/User/UserStorage.php +++ b/src/lib/FieldType/User/UserStorage.php @@ -46,9 +46,7 @@ public function getFieldData(VersionInfo $versionInfo, Field $field) } /** - * @param \Ibexa\Contracts\Core\Persistence\Content\VersionInfo $versionInfo * @param int[] $fieldIds Array of field Ids - * @param array $context * * @return bool * diff --git a/src/lib/Helper/PreviewLocationProvider.php b/src/lib/Helper/PreviewLocationProvider.php index 2cc03b9431..4da6a3642e 100644 --- a/src/lib/Helper/PreviewLocationProvider.php +++ b/src/lib/Helper/PreviewLocationProvider.php @@ -8,7 +8,6 @@ namespace Ibexa\Core\Helper; use Ibexa\Contracts\Core\Persistence\Content\Location\Handler as PersistenceLocationHandler; -use Ibexa\Contracts\Core\Repository\ContentService; use Ibexa\Contracts\Core\Repository\LocationService; use Ibexa\Contracts\Core\Repository\Values\Content\Content as APIContent; use Ibexa\Contracts\Core\Repository\Values\Content\Location as APILocation; @@ -22,24 +21,18 @@ class PreviewLocationProvider /** @var \Ibexa\Contracts\Core\Repository\LocationService */ private $locationService; - /** @var \Ibexa\Contracts\Core\Repository\ContentService */ - private $contentService; - /** @var \Ibexa\Contracts\Core\Persistence\Content\Location\Handler */ private $locationHandler; /** * @param \Ibexa\Contracts\Core\Repository\LocationService $locationService - * @param \Ibexa\Contracts\Core\Repository\ContentService $contentService * @param \Ibexa\Contracts\Core\Persistence\Content\Location\Handler $locationHandler */ public function __construct( LocationService $locationService, - ContentService $contentService, PersistenceLocationHandler $locationHandler ) { $this->locationService = $locationService; - $this->contentService = $contentService; $this->locationHandler = $locationHandler; } diff --git a/src/lib/MVC/Symfony/Component/Serializer/SimplifiedRequestNormalizer.php b/src/lib/MVC/Symfony/Component/Serializer/SimplifiedRequestNormalizer.php index 9ed0944cce..1251e143f0 100644 --- a/src/lib/MVC/Symfony/Component/Serializer/SimplifiedRequestNormalizer.php +++ b/src/lib/MVC/Symfony/Component/Serializer/SimplifiedRequestNormalizer.php @@ -16,13 +16,13 @@ final class SimplifiedRequestNormalizer extends PropertyNormalizer * @param \Ibexa\Core\MVC\Symfony\Routing\SimplifiedRequest $object * * @return array{ - * scheme: string, - * host: string, - * port: string, - * pathinfo: string, - * queryParams: array, - * languages: string[], - * headers: array{} + * scheme: ?string, + * host: ?string, + * port: ?int, + * pathinfo: ?string, + * queryParams: ?array, + * languages: ?string[], + * headers: ?array{} * } * * @see \Symfony\Component\Serializer\Normalizer\NormalizerInterface::normalize diff --git a/src/lib/MVC/Symfony/SiteAccess/Matcher/HostElement.php b/src/lib/MVC/Symfony/SiteAccess/Matcher/HostElement.php index 682fcabb50..dba77ecc6e 100644 --- a/src/lib/MVC/Symfony/SiteAccess/Matcher/HostElement.php +++ b/src/lib/MVC/Symfony/SiteAccess/Matcher/HostElement.php @@ -83,7 +83,7 @@ public function getRequest() public function reverseMatch($siteAccessName) { - $hostElements = explode('.', $this->request->getHost()); + $hostElements = explode('.', (string)$this->request->getHost()); $elementNumber = $this->elementNumber - 1; if (!isset($hostElements[$elementNumber])) { return null; diff --git a/src/lib/MVC/Symfony/SiteAccess/Matcher/HostText.php b/src/lib/MVC/Symfony/SiteAccess/Matcher/HostText.php index fd8a47f515..d169a9801e 100644 --- a/src/lib/MVC/Symfony/SiteAccess/Matcher/HostText.php +++ b/src/lib/MVC/Symfony/SiteAccess/Matcher/HostText.php @@ -30,7 +30,7 @@ public function getName(): string public function setRequest(SimplifiedRequest $request): void { if (!$this->element) { - $this->setMatchElement($request->getHost()); + $this->setMatchElement((string)$request->getHost()); } parent::setRequest($request); diff --git a/src/lib/MVC/Symfony/SiteAccess/Matcher/Map/Host.php b/src/lib/MVC/Symfony/SiteAccess/Matcher/Map/Host.php index 7d098a4968..b629c409d5 100644 --- a/src/lib/MVC/Symfony/SiteAccess/Matcher/Map/Host.php +++ b/src/lib/MVC/Symfony/SiteAccess/Matcher/Map/Host.php @@ -25,7 +25,7 @@ public function getName(): string public function setRequest(SimplifiedRequest $request) { if (!$this->key) { - $this->setMapKey($request->getHost()); + $this->setMapKey((string)$request->getHost()); } parent::setRequest($request); diff --git a/src/lib/MVC/Symfony/SiteAccess/Matcher/Map/Port.php b/src/lib/MVC/Symfony/SiteAccess/Matcher/Map/Port.php index c43c2f3690..75f6d0d0d3 100644 --- a/src/lib/MVC/Symfony/SiteAccess/Matcher/Map/Port.php +++ b/src/lib/MVC/Symfony/SiteAccess/Matcher/Map/Port.php @@ -39,7 +39,7 @@ public function setRequest(SimplifiedRequest $request) } } - $this->setMapKey($key); + $this->setMapKey((string)$key); } parent::setRequest($request); @@ -49,7 +49,7 @@ public function reverseMatch($siteAccessName) { $matcher = parent::reverseMatch($siteAccessName); if ($matcher instanceof self) { - $matcher->getRequest()->setPort($matcher->getMapKey()); + $matcher->getRequest()->setPort((int)$matcher->getMapKey()); } return $matcher; diff --git a/src/lib/MVC/Symfony/SiteAccess/Matcher/Map/URI.php b/src/lib/MVC/Symfony/SiteAccess/Matcher/Map/URI.php index e4bf94a8eb..a940b8bb8c 100644 --- a/src/lib/MVC/Symfony/SiteAccess/Matcher/Map/URI.php +++ b/src/lib/MVC/Symfony/SiteAccess/Matcher/Map/URI.php @@ -21,7 +21,7 @@ class URI extends Map implements URILexer public function setRequest(SimplifiedRequest $request) { if (!$this->key) { - sscanf($request->getPathInfo(), '/%[^/]', $key); + sscanf((string)$request->getPathInfo(), '/%[^/]', $key); $this->setMapKey(rawurldecode((string)$key)); } @@ -82,7 +82,7 @@ public function reverseMatch($siteAccessName) if ($matcher instanceof self) { $request = $matcher->getRequest(); // Clean up "old" siteaccess prefix and add the new prefix. - $request->setPathinfo($this->analyseLink($request->getPathInfo())); + $request->setPathinfo($this->analyseLink((string)$request->getPathInfo())); } return $matcher; diff --git a/src/lib/MVC/Symfony/SiteAccess/Matcher/URIElement.php b/src/lib/MVC/Symfony/SiteAccess/Matcher/URIElement.php index 2f384ddfce..49dddd748a 100644 --- a/src/lib/MVC/Symfony/SiteAccess/Matcher/URIElement.php +++ b/src/lib/MVC/Symfony/SiteAccess/Matcher/URIElement.php @@ -178,7 +178,7 @@ public function reverseMatch($siteAccessName) return null; } - $pathinfo = '/' . implode('/', $elements) . '/' . ltrim($this->request->getPathInfo(), '/'); + $pathinfo = '/' . implode('/', $elements) . '/' . ltrim((string)$this->request->getPathInfo(), '/'); $this->request->setPathinfo($pathinfo); return $this; diff --git a/src/lib/MVC/Symfony/SiteAccess/Matcher/URIText.php b/src/lib/MVC/Symfony/SiteAccess/Matcher/URIText.php index f6e2fbf93a..eeef01066e 100644 --- a/src/lib/MVC/Symfony/SiteAccess/Matcher/URIText.php +++ b/src/lib/MVC/Symfony/SiteAccess/Matcher/URIText.php @@ -31,7 +31,7 @@ public function getName(): string public function setRequest(SimplifiedRequest $request): void { if (!$this->element) { - $this->setMatchElement($request->getPathInfo()); + $this->setMatchElement((string)$request->getPathInfo()); } parent::setRequest($request); diff --git a/src/lib/MVC/Symfony/SiteAccess/Router.php b/src/lib/MVC/Symfony/SiteAccess/Router.php index 706969aafb..5242945875 100644 --- a/src/lib/MVC/Symfony/SiteAccess/Router.php +++ b/src/lib/MVC/Symfony/SiteAccess/Router.php @@ -222,7 +222,7 @@ public function matchByName($siteAccessName): ?SiteAccess $request = clone $this->request; // Be sure to have a clean pathinfo, without SiteAccess part in it. if ($this->siteAccess && $this->siteAccess->matcher instanceof URILexer) { - $request->setPathinfo($this->siteAccess->matcher->analyseURI($request->getPathInfo())); + $request->setPathinfo($this->siteAccess->matcher->analyseURI((string)$request->getPathInfo())); } $siteAccessClass = $this->siteAccessClass; diff --git a/src/lib/Repository/URLWildcardService.php b/src/lib/Repository/URLWildcardService.php index ba998af10f..3623370c99 100644 --- a/src/lib/Repository/URLWildcardService.php +++ b/src/lib/Repository/URLWildcardService.php @@ -317,10 +317,6 @@ private function validateUrls(string $sourceUrl, string $destinationUrl): void preg_match_all('(\\*)', $sourceUrl, $patterns); preg_match_all('({(\d+)})', $destinationUrl, $placeholders); - if (empty($patterns) || empty($placeholders)) { - throw new ContentValidationException('Invalid URL wildcards provided.'); - } - $patterns = array_map('intval', $patterns[0]); $placeholders = array_map('intval', $placeholders[1]); diff --git a/tests/integration/Core/Repository/ContentServiceAuthorizationTest.php b/tests/integration/Core/Repository/ContentServiceAuthorizationTest.php index 42501fc2bf..94710f5c9a 100644 --- a/tests/integration/Core/Repository/ContentServiceAuthorizationTest.php +++ b/tests/integration/Core/Repository/ContentServiceAuthorizationTest.php @@ -11,6 +11,7 @@ use Ibexa\Contracts\Core\Repository\Repository; use Ibexa\Contracts\Core\Repository\Values\Content\ContentInfo; use Ibexa\Contracts\Core\Repository\Values\Content\Location; +use Ibexa\Contracts\Core\Repository\Values\Content\Relation; use Ibexa\Contracts\Core\Repository\Values\User\Limitation\LanguageLimitation; use Ibexa\Contracts\Core\Repository\Values\User\Limitation\LocationLimitation; use Ibexa\Contracts\Core\Repository\Values\User\Limitation\SubtreeLimitation; @@ -1199,6 +1200,7 @@ public function testLoadRelationsWithUnauthorizedRelations() * @var \Ibexa\Contracts\Core\Repository\Values\Content\RelationList\RelationListItemInterface $relationListItem */ foreach ($actualRelations as $relationListItem) { + /** @var \Ibexa\Contracts\Core\Repository\Values\Content\Relation $relation */ $relation = $relationListItem->getRelation(); $destination = $relation->destinationContentInfo; $expected = $expectedRelations[$destination->id]->destinationContentInfo; diff --git a/tests/integration/Core/Repository/ContentServiceTest.php b/tests/integration/Core/Repository/ContentServiceTest.php index cfec986d21..c0212b4c70 100644 --- a/tests/integration/Core/Repository/ContentServiceTest.php +++ b/tests/integration/Core/Repository/ContentServiceTest.php @@ -2419,7 +2419,7 @@ public function testLoadContentDraftsReturnsEmptyArrayByDefault() * * @depends testCreateContentDraft */ - public function testLoadContentDraftList() + public function testLoadContentDraftList(): void { // "Media" content object $mediaContentInfo = $this->contentService->loadContentInfoByRemoteId(self::MEDIA_REMOTE_ID); @@ -2435,11 +2435,17 @@ public function testLoadContentDraftList() /** @var \Ibexa\Contracts\Core\Repository\Values\Content\DraftList\ContentDraftListItemInterface[] $draftedVersions */ $draftedVersions = iterator_to_array($this->contentService->loadContentDraftList()->getIterator()); + /** @var \Ibexa\Contracts\Core\Repository\Values\Content\VersionInfo $draftedVersionInfo0 */ + $draftedVersionInfo0 = $draftedVersions[0]->getVersionInfo(); + + /** @var \Ibexa\Contracts\Core\Repository\Values\Content\VersionInfo $draftedVersionInfo1 */ + $draftedVersionInfo1 = $draftedVersions[1]->getVersionInfo(); + $actual = [ - $draftedVersions[0]->getVersionInfo()->status, - $draftedVersions[0]->getVersionInfo()->getContentInfo()->remoteId, - $draftedVersions[1]->getVersionInfo()->status, - $draftedVersions[1]->getVersionInfo()->getContentInfo()->remoteId, + $draftedVersionInfo0->status, + $draftedVersionInfo0->getContentInfo()->remoteId, + $draftedVersionInfo1->status, + $draftedVersionInfo1->getContentInfo()->remoteId, ]; sort($actual, SORT_STRING); @@ -2483,19 +2489,21 @@ public function testLoadContentDraftsWithFirstParameter() self::assertSame([], $oldCurrentUserDrafts); + /** @var \Ibexa\Contracts\Core\Repository\Values\Content\VersionInfo $newCurrentUserDraftVersionInfo */ + $newCurrentUserDraftVersionInfo = $newCurrentUserDrafts[0]->getVersionInfo(); self::assertEquals( [ VersionInfo::STATUS_DRAFT, self::MEDIA_REMOTE_ID, ], [ - $newCurrentUserDrafts[0]->getVersionInfo()->status, - $newCurrentUserDrafts[0]->getVersionInfo()->getContentInfo()->remoteId, + $newCurrentUserDraftVersionInfo->status, + $newCurrentUserDraftVersionInfo->getContentInfo()->remoteId, ] ); - self::assertTrue($newCurrentUserDrafts[0]->getVersionInfo()->isDraft()); - self::assertFalse($newCurrentUserDrafts[0]->getVersionInfo()->isArchived()); - self::assertFalse($newCurrentUserDrafts[0]->getVersionInfo()->isPublished()); + self::assertTrue($newCurrentUserDraftVersionInfo->isDraft()); + self::assertFalse($newCurrentUserDraftVersionInfo->isArchived()); + self::assertFalse($newCurrentUserDraftVersionInfo->isPublished()); } /** @@ -2503,7 +2511,7 @@ public function testLoadContentDraftsWithFirstParameter() * * @covers \Ibexa\Contracts\Core\Repository\ContentService::loadContentDraftList() */ - public function testLoadContentDraftListWithPaginationParameters() + public function testLoadContentDraftListWithPaginationParameters(): void { // Create some drafts $publishedContent = $this->createContentVersion1(); @@ -2529,7 +2537,7 @@ public function testLoadContentDraftListWithPaginationParameters() * * @covers \Ibexa\Contracts\Core\Repository\ContentService::loadContentDraftList($user) */ - public function testLoadContentDraftListWithForUserWithLimitation() + public function testLoadContentDraftListWithForUserWithLimitation(): void { $oldUser = $this->permissionResolver->getCurrentUserReference(); @@ -2568,7 +2576,7 @@ public function testLoadContentDraftListWithForUserWithLimitation() * * @covers \Ibexa\Contracts\Core\Repository\ContentService::loadContentDraftList() */ - public function testLoadAllContentDraftList() + public function testLoadAllContentDraftList(): void { // Create more drafts then default pagination limit $this->createContentDrafts(12); @@ -6757,7 +6765,7 @@ private function createParentLocationsForHideReveal(int $parentLocationId): arra $this->createFolder([self::ENG_US => 'P3'], $parentLocationId)->contentInfo->mainLocationId, ]; - return array_values($this->locationService->loadLocationList($parentFoldersLocationsIds)); + return array_values([...$this->locationService->loadLocationList($parentFoldersLocationsIds)]); } /** diff --git a/tests/integration/Core/Repository/FieldType/RelationIntegrationTest.php b/tests/integration/Core/Repository/FieldType/RelationIntegrationTest.php index f1ed678eb4..ca1403263e 100644 --- a/tests/integration/Core/Repository/FieldType/RelationIntegrationTest.php +++ b/tests/integration/Core/Repository/FieldType/RelationIntegrationTest.php @@ -109,7 +109,7 @@ public function getSettingsSchema() } /** - * @covers \Ibexa\Contracts\Core\Repository\Tests\FieldType\BaseIntegrationTest::getValidatorSchema() + * @covers \Ibexa\Tests\Integration\Core\Repository\FieldType\BaseIntegrationTest::getValidatorSchema() */ public function getValidatorSchema() { @@ -230,10 +230,8 @@ public function provideInvalidCreationFieldData() /** * Get update field externals data. - * - * @return array */ - public function getValidUpdateFieldData() + public function getValidUpdateFieldData(): RelationValue { return new RelationValue(49); } @@ -242,10 +240,8 @@ public function getValidUpdateFieldData() * Get externals updated field data values. * * This is a PHPUnit data provider - * - * @return array */ - public function assertUpdatedFieldDataLoadedCorrect(Field $field) + public function assertUpdatedFieldDataLoadedCorrect(Field $field): void { self::assertInstanceOf(RelationValue::class, $field->value); @@ -271,7 +267,7 @@ public function provideInvalidUpdateFieldData() * * @param \Ibexa\Contracts\Core\Repository\Values\Content\Field $field */ - public function assertCopiedFieldDataLoadedCorrectly(Field $field) + public function assertCopiedFieldDataLoadedCorrectly(Field $field): void { self::assertInstanceOf( RelationValue::class, diff --git a/tests/integration/Core/Repository/FieldType/RelationListIntegrationTest.php b/tests/integration/Core/Repository/FieldType/RelationListIntegrationTest.php index 19fd77c786..5da099b74c 100644 --- a/tests/integration/Core/Repository/FieldType/RelationListIntegrationTest.php +++ b/tests/integration/Core/Repository/FieldType/RelationListIntegrationTest.php @@ -259,10 +259,8 @@ public function provideInvalidCreationFieldData() /** * Get update field externals data. - * - * @return array */ - public function getValidUpdateFieldData() + public function getValidUpdateFieldData(): RelationListValue { return new RelationListValue([49, 54, 4]); } @@ -271,10 +269,8 @@ public function getValidUpdateFieldData() * Get externals updated field data values. * * This is a PHPUnit data provider - * - * @return array */ - public function assertUpdatedFieldDataLoadedCorrect(Field $field) + public function assertUpdatedFieldDataLoadedCorrect(Field $field): void { self::assertInstanceOf(RelationListValue::class, $field->value); @@ -300,7 +296,7 @@ public function provideInvalidUpdateFieldData() * * @param \Ibexa\Contracts\Core\Repository\Values\Content\Field $field */ - public function assertCopiedFieldDataLoadedCorrectly(Field $field) + public function assertCopiedFieldDataLoadedCorrectly(Field $field): void { self::assertInstanceOf( RelationListValue::class, diff --git a/tests/integration/Core/Repository/FieldType/RelationSearchBaseIntegrationTestTrait.php b/tests/integration/Core/Repository/FieldType/RelationSearchBaseIntegrationTestTrait.php index 2a1b148b66..7e6662dcab 100644 --- a/tests/integration/Core/Repository/FieldType/RelationSearchBaseIntegrationTestTrait.php +++ b/tests/integration/Core/Repository/FieldType/RelationSearchBaseIntegrationTestTrait.php @@ -9,6 +9,7 @@ use Ibexa\Contracts\Core\Repository\Values\Content\Content; use Ibexa\Contracts\Core\Repository\Values\Content\LocationCreateStruct; +use Ibexa\Contracts\Core\Repository\Values\Content\Relation as RelationContract; use Ibexa\Contracts\Core\Repository\Values\Content\RelationList; use Ibexa\Contracts\Core\Repository\Values\Content\RelationList\RelationListItemInterface; use Ibexa\Core\Repository\Values\Content\Relation; @@ -79,7 +80,7 @@ public function testUpdateContentRelationsProcessedCorrect() /** * Normalizes given $relations for easier comparison. * - * @param \Ibexa\Core\Repository\Values\Content\Relation[] $relations + * @param \Ibexa\Contracts\Core\Repository\Values\Content\Relation[] $relations * * @return \Ibexa\Core\Repository\Values\Content\Relation[] */ @@ -87,7 +88,7 @@ protected function normalizeRelations(array $relations) { usort( $relations, - static function (Relation $a, Relation $b): int { + static function (RelationContract $a, RelationContract $b): int { if ($a->type == $b->type) { return $a->destinationContentInfo->id < $b->destinationContentInfo->id ? 1 : -1; } @@ -96,7 +97,7 @@ static function (Relation $a, Relation $b): int { } ); $normalized = array_map( - static function (Relation $relation) { + static function (RelationContract $relation) { $newRelation = new Relation( [ 'id' => null, @@ -181,12 +182,12 @@ public function testSubtreeCopyContentCopiesFieldRelations() } /** - * @return \Ibexa\Core\Repository\Values\Content\Relation[] + * @return \Ibexa\Contracts\Core\Repository\Values\Content\Relation[] */ private function getRelations(RelationList $relationList): array { return array_filter(array_map( - static fn (RelationListItemInterface $relationListItem): ?Relation => $relationListItem->getRelation(), + static fn (RelationListItemInterface $relationListItem): ?RelationContract => $relationListItem->getRelation(), $relationList->items )); } diff --git a/tests/lib/Helper/PreviewLocationProviderTest.php b/tests/lib/Helper/PreviewLocationProviderTest.php index c5a41758a8..2db4957a3e 100644 --- a/tests/lib/Helper/PreviewLocationProviderTest.php +++ b/tests/lib/Helper/PreviewLocationProviderTest.php @@ -8,7 +8,6 @@ namespace Ibexa\Tests\Core\Helper; use Ibexa\Contracts\Core\Persistence\Content\Location\Handler as SPILocationHandler; -use Ibexa\Contracts\Core\Repository\ContentService; use Ibexa\Contracts\Core\Repository\LocationService; use Ibexa\Contracts\Core\Repository\Values\Content\ContentInfo as APIContentInfo; use Ibexa\Contracts\Core\Repository\Values\Content\Location as APILocation; @@ -20,9 +19,6 @@ class PreviewLocationProviderTest extends TestCase { - /** @var \Ibexa\Contracts\Core\Repository\LocationService|\PHPUnit\Framework\MockObject\MockObject */ - private $contentService; - /** @var \Ibexa\Contracts\Core\Repository\LocationService|\PHPUnit\Framework\MockObject\MockObject */ private $locationService; @@ -36,10 +32,9 @@ protected function setUp(): void { parent::setUp(); - $this->contentService = $this->createMock(ContentService::class); $this->locationService = $this->createMock(LocationService::class); $this->locationHandler = $this->createMock(SPILocationHandler::class); - $this->provider = new PreviewLocationProvider($this->locationService, $this->contentService, $this->locationHandler); + $this->provider = new PreviewLocationProvider($this->locationService, $this->locationHandler); } public function testGetPreviewLocationDraft() diff --git a/tests/lib/IO/IOServiceTest.php b/tests/lib/IO/IOServiceTest.php index 4e0dc0e3ad..5d865b19b7 100644 --- a/tests/lib/IO/IOServiceTest.php +++ b/tests/lib/IO/IOServiceTest.php @@ -330,7 +330,7 @@ public function testDeleteDirectory() $this->getIOService()->deleteDirectory('some/directory'); } - public function testDeleteBinaryFileNotFound() + public function testDeleteBinaryFileNotFound(): void { $this->expectException(BinaryFileNotFoundException::class); diff --git a/tests/lib/IO/TolerantIOServiceTest.php b/tests/lib/IO/TolerantIOServiceTest.php index dd6107cad8..7c248f2f71 100644 --- a/tests/lib/IO/TolerantIOServiceTest.php +++ b/tests/lib/IO/TolerantIOServiceTest.php @@ -58,7 +58,7 @@ public function testCreateMissingBinaryFile() /** * Overridden to change the expected exception (none). */ - public function testDeleteBinaryFileNotFound() + public function testDeleteBinaryFileNotFound(): void { $this->deleteBinaryFileNotFound(); } diff --git a/tests/lib/MVC/Symfony/SiteAccess/RouterHostPortURITest.php b/tests/lib/MVC/Symfony/SiteAccess/RouterHostPortURITest.php index b319addddf..332bd6d14f 100644 --- a/tests/lib/MVC/Symfony/SiteAccess/RouterHostPortURITest.php +++ b/tests/lib/MVC/Symfony/SiteAccess/RouterHostPortURITest.php @@ -126,7 +126,7 @@ public function testSetGetRequestMapPort() $matcher = new Port(['foo' => $mapKey]); $matcher->setRequest($request); self::assertSame($request, $matcher->getRequest()); - self::assertSame($mapKey, $matcher->getMapKey()); + self::assertSame((string)$mapKey, $matcher->getMapKey()); } public function testReversePortMatchFail() @@ -146,7 +146,7 @@ public function testReverseMatchPort() $request = new SimplifiedRequest('http', 'ibexa.co'); $matcher = new Port($config); $matcher->setRequest($request); - self::assertSame(80, $matcher->getMapKey()); + self::assertSame('80', $matcher->getMapKey()); $result = $matcher->reverseMatch('ibexa_demo_site'); self::assertInstanceOf(Port::class, $result); diff --git a/tests/lib/Repository/Decorator/ContentServiceDecoratorTest.php b/tests/lib/Repository/Decorator/ContentServiceDecoratorTest.php index 2583a08429..3f5f8f2766 100644 --- a/tests/lib/Repository/Decorator/ContentServiceDecoratorTest.php +++ b/tests/lib/Repository/Decorator/ContentServiceDecoratorTest.php @@ -32,13 +32,13 @@ class ContentServiceDecoratorTest extends TestCase private const EXAMPLE_CONTENT_REMOTE_ID = 'example'; private const EXAMPLE_VERSION_NO = 1; - protected function createDecorator(MockObject $service): ContentService + protected function createDecorator(ContentService&MockObject $service): ContentService { return new class($service) extends ContentServiceDecorator { }; } - protected function createServiceMock(): MockObject + protected function createServiceMock(): ContentService&MockObject { return $this->createMock(ContentService::class); } @@ -250,7 +250,7 @@ public function testCreateContentDraftDecorator() $decoratedService->createContentDraft(...$parameters); } - public function testLoadContentDraftListDecorator() + public function testLoadContentDraftListDecorator(): void { $serviceMock = $this->createServiceMock(); $decoratedService = $this->createDecorator($serviceMock); @@ -329,7 +329,7 @@ public function testCopyContentDecorator() $decoratedService->copyContent(...$parameters); } - public function testLoadRelationListDecorator() + public function testLoadRelationListDecorator(): void { $serviceMock = $this->createServiceMock(); $decoratedService = $this->createDecorator($serviceMock);