Doc Strings #2
Comments
ibaoger
pushed a commit
that referenced
this issue
Jun 5, 2024
The new version of MSan (rolled by [1]) detects the following:
```
==39908==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x5591400a52ef in GetPlayoutDelayMs ./../../modules/audio_coding/neteq/decision_logic.cc:466:35
#1 0x5591400a52ef in webrtc::DecisionLogic::ExpectedPacketAvailable(webrtc::NetEqController::NetEqStatus) ./../../modules/audio_coding/neteq/decision_logic.cc:311:36
#2 0x5591400a39e9 in webrtc::DecisionLogic::GetDecision(webrtc::NetEqController::NetEqStatus const&, bool*) ./../../modules/audio_coding/neteq/decision_logic.cc:0:0
#3 0x55913cf590c9 in webrtc::DecisionLogicTest_PreemptiveExpand_Test::TestBody() ./../../modules/audio_coding/neteq/decision_logic_unittest.cc:139:3
#4 0x55913ef28283 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:3
#5 0x55913ef28283 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2710:5
#6 0x55913ef2ab46 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2856:11
#7 0x55913ef2da34 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3034:30
#8 0x55913ef621e8 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5964:44
#9 0x55913ef60f54 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
#10 0x55913ef60f54 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5543:10
#11 0x55913ee1a944 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2334:73
#12 0x55913ee1a944 in webrtc::(anonymous namespace)::TestMainImpl::Run(int, char**) ./../../test/test_main_lib.cc:203:21
#13 0x55913cbd36b8 in main ./../../test/test_main.cc:72:16
#14 0x7fdb18c73082 in __libc_start_main /build/glibc-LcI20x/glibc-2.31/csu/../csu/libc-start.c:308:16
#15 0x55913cb3e1a9 in _start ??:0:0
```
[1] - https://webrtc-review.googlesource.com/c/src/+/353620
Bug: b/344970813
Change-Id: I9b5d7791e68b4c494168ba9f007a3099ae21fed4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/353581
Auto-Submit: Mirko Bonadei <[email protected]>
Reviewed-by: Jakob Ivarsson <[email protected]>
Commit-Queue: Jakob Ivarsson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#42433}
ibaoger
pushed a commit
that referenced
this issue
Nov 29, 2024
Two fixes to deflake, 1. Increase the ramp up time for all layers - short time was flaky for 720p. 2. Wait for both the scalability mode AND implementation name to update. Sometimes the implementation name would change before the scalability mode did due to a race, so some OutboundRtpStats would have the wrong values. To achieve #2 (and #1 with some debugging) a new utility WaitForCondition was added in order to apply matchers to a condition. This is used instead of EXPECT_WAIT_EQ and similar because it gives clear feedback on failure. I have made 500 runs without a further flake. Bug: webrtc:381216372 Change-Id: I0132377774e379857664e9a0c20f432bc9dc9fb7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/369742 Reviewed-by: Olga Sharonova <[email protected]> Commit-Queue: Olga Sharonova <[email protected]> Auto-Submit: Evan Shrubsole <[email protected]> Reviewed-by: Henrik Boström <[email protected]> Cr-Commit-Position: refs/heads/main@{#43472}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Just wanted to offer my assistance if possible. I am wanting to add doc strings to your files, I can do about 8 files a week, hopefully cover most of them, that way it makes it a bit more easier for future contributors to understand what is happening as they will see explanations of the code.
The text was updated successfully, but these errors were encountered: