You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I believe the text and icon parameters in Style could be redesigned. In deed, the both describe content of labels. text is for all eventual text written within a label and icon for an eventual icon. Therefore, we could have the following structure :
Style: {label: {text: {// all the current Style.text properties could go here},icon: {// all the current Style.icon properties could go here},// other eventual properties could be added directly to Style.label}}
This structure would offer a more rigorous naming for Style properties. It would also grant the possibility to add properties that concern labels but which are not specifically related to labels text or icon.
The structure given here is an example, and the existence of a better structure should be checked before refactoring anything.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I believe the
text
andicon
parameters inStyle
could be redesigned. In deed, the both describe content of labels.text
is for all eventual text written within a label andicon
for an eventual icon. Therefore, we could have the following structure :This structure would offer a more rigorous naming for Style properties. It would also grant the possibility to add properties that concern labels but which are not specifically related to labels text or icon.
The structure given here is an example, and the existence of a better structure should be checked before refactoring anything.
Beta Was this translation helpful? Give feedback.
All reactions